New issue
Advanced search Search tips

Issue 850971 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Labels not vertically centered on new dropdown

Project Member Reported by ftirelo@chromium.org, Jun 8 2018 
Chrome Version: M68+
OS: all

In the new dropdown, the label view is centered, but the text doesn't look so. We need to find a way of setting the line height taking into account both the label and the sublabel heights.

Screenshots in a few languages: https://drive.google.com/open?id=1Ir8zJJBp_FjabzhcGptU9mbnzZzRKFYq

Comment 1 Deleted

Comment 2 Deleted

Comment 4 by ftirelo@chromium.org, Jul 19

Labels: RegressedIn-69 Target-69 FoundIn-69

Comment 5 by ftirelo@chromium.org, Jul 19

Owner: ftirelo@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by ftirelo@chromium.org, Jul 19

Labels: -RegressedIn-69 RegressedIn-68

Comment 7 by ftirelo@chromium.org, Jul 19

Labels: FoundIn-68

Comment 8 by ftirelo@chromium.org, Jul 19 

This happens on Windows only.

Steps for repro in case this needs to be merged to the M69 branch:

(1) Enable chrome://flags/#upcoming-ui-features
(2) Navigate to https://rsolomakhin.github.io/autofill, scroll up to the top of the page and click on field "Name", section "Profile Autofill" (if you don't see the autofill dropdown, go to chrome://settings/autofill and add a new address)

What should happen?
Labels should be vertically centered in the suggestion/footer row.

What happens instead?
Labels are slightly off-centered, and sometimes the last pixel of each row in the dropdown for ‘g’ and ‘y’ is cut off
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f98e67b8bded614f51fc1a8d3104abb07b6f405

commit 1f98e67b8bded614f51fc1a8d3104abb07b6f405
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Thu Jul 19 16:25:43 2018

[AF] Fix label vertical alignment on Autofill dropdown

This changes the cross axis alignment for the suggestion view's
BoxLayout to CROSS_AXIS_ALIGNMENT_STRETCH, so that labels will
vertically center themselves on the view.

Screenshots (Googlers only): https://drive.google.com/open?id=1Cfn9vBcJahBGj9oSl_5xRwBt9LDINa60

Bug:  850971 
Change-Id: I877988889a6d0a3a07dbca34cb194bd3eef0668a
Reviewed-on: https://chromium-review.googlesource.com/1142371
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576517}
[modify] https://crrev.com/1f98e67b8bded614f51fc1a8d3104abb07b6f405/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Comment 10 by ftirelo@chromium.org, Jul 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment