New issue
Advanced search Search tips

Issue 850959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2%-8.8% regression in system_health.memory_mobile at 1528324311:1528342354

Project Member Reported by mustaq@chromium.org, Jun 8 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=850959

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=769ad2d380746d3b1cb44eabfe3a4829729266a4565c411a8171762fa289bdbe


Bot(s) for this bug's original alert(s):

health-plan-clankium-low-end-phone
health-plan-clankium-phone
health-plan-webview-low-end-phone
health-plan-webview-phone
perf-go-phone-1024
perf-go-phone-512

=== BISECT JOB RESULTS ===
Bisect was unable to run to completion

Error: INFRA_FAILURE

The bisect was able to narrow the range, you can try running with:
  good_revision: b9413fec9958c624e6e50de370267a10104c2893
  bad_revision : aaa3a1ddb127e166efede5f74523f93c4f598cf6

If failures persist contact the team (see below) and report the error.


Bisect Details
  Configuration: go-phone-512-perf-bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:private_footprint_size_avg/browse_social/browse_social_facebook_infinite_scroll
  Change       : 8.01% | 91550378.6667 -> 98879488.0

Revision                                       Result                   N
android-chrome@43664d4f70                      91550379 +- 615886       6      good
android-chrome@cf80bde8c3                      91129173 +- 801417       6      good
android-chrome@02815fd20b                      90873856 +- 472168       6      good
android-chrome@02815fd20b,chromium@564911      91381077 +- 1328422      6      good
android-chrome@02815fd20b,chromium@564917      91682816 +- 799011       6      good
android-chrome@02815fd20b,chromium@564923      98811221 +- 1074160      6      bad
android-chrome@2958fe5b33                      99186005 +- 649996       6      bad
android-chrome@80ef1ad1f9                      98879488 +- 1217671      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.facebook.infinite.scroll system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8944274345621234192


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 10 2018

Cc: keishi@chromium.org
Owner: keishi@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author keishi@chromium.org ===

Hi keishi@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Keishi Hattori
  Commit : eb0f64796188dd6fd739f73d97ef455ca9c0a593
  Date   : Wed Jun 06 16:39:56 2018
  Subject: Oilpan: Fix unexpected GCState transition for incremental idle gc

Bisect Details
  Configuration: webview-low-end-phone-perf-bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:private_footprint_size_avg/browse_shopping/browse_shopping_amazon
  Change       : 5.80% | 58473813.3333 -> 61868032.0

Revision                                       Result                  N
android-chrome@43664d4f70                      58473813 +- 502647      6      good
android-chrome@cf80bde8c3                      58327723 +- 348670      6      good
android-chrome@02815fd20b                      57879211 +- 576269      6      good
android-chrome@02815fd20b,chromium@564911      58243755 +- 286658      6      good
android-chrome@02815fd20b,chromium@564917      58399403 +- 248579      6      good
android-chrome@02815fd20b,chromium@564920      58303147 +- 404891      6      good
android-chrome@02815fd20b,chromium@564921      57761792 +- 589568      6      good
android-chrome@02815fd20b,chromium@564922      62106965 +- 484170      6      bad       <--
android-chrome@02815fd20b,chromium@564923      62481067 +- 430898      6      bad
android-chrome@2958fe5b33                      61744469 +- 604771      6      bad
android-chrome@80ef1ad1f9                      61868032 +- 438381      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.shopping.amazon system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8944274391155890752


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Jun 10 2018

Cc: hayato@chromium.org
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12bd8931240000

Oilpan: Refactor idle gc scheduling and add tests by keishi@chromium.org
https://chromium.googlesource.com/chromium/src/+/b0b361c56cb33ea6dba45876013367f382362c60
6.092e+07 → 5.282e+07 (-8.1e+06)

Clear slot's assigned nodes if the slot assignment is dirty when the slot is removed by hayato@chromium.org
https://chromium.googlesource.com/chromium/src/+/4b04a57e793d228aca724525a50d2c5cb7572e13
5.282e+07 → 5.374e+07 (+9.152e+05)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 8 by keishi@chromium.org, Jun 10 2018

Status: Fixed (was: Assigned)
https://chromium.googlesource.com/chromium/src/+/b0b361c56cb33ea6dba45876013367f382362c60
Seems to have fixed the regression

Sign in to add a comment