There is a new version of the Geo Language Mappings available. The data used by GeoLanguageProvider should be updated to use the new mappings.
+frechette@ who's looking into this
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3e1b548e4e88a8819db4848ee9b50b177103e52 commit d3e1b548e4e88a8819db4848ee9b50b177103e52 Author: Alexandre Frechette <frechette@chromium.org> Date: Thu Dec 13 14:40:50 2018 [Improved Geo-language] Prepare for a new language code locator. Abstracts away the current language code locator implementation. Adds the boilerplate for a feature toggling between possible implementations. Bug: 850947 Change-Id: I620c8f6ceb95cd45dab68222fb34fcaa1d44c7ab Reviewed-on: https://chromium-review.googlesource.com/c/1352683 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#616306} [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/chrome/browser/about_flags.cc [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/chrome/browser/flag-metadata.json [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/chrome/browser/flag_descriptions.h [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/BUILD.gn [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/geo_language_provider.cc [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/language_code_locator.h [rename] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/regional_language_code_locator.cc [add] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/regional_language_code_locator.h [rename] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/regional_language_code_locator_unittest.cc [rename] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/content/browser/template/regional_language_code_locator_helper.h.tmpl [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/core/common/language_experiments.cc [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/components/language/core/common/language_experiments.h [modify] https://crrev.com/d3e1b548e4e88a8819db4848ee9b50b177103e52/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6063cec9d2bfb3da334dd430a8a17c1236ffe85f commit 6063cec9d2bfb3da334dd430a8a17c1236ffe85f Author: Alexandre Frechette <frechette@chromium.org> Date: Tue Jan 08 19:56:02 2019 [Improved Geo-language] Add improved language locator. After this change, the improved ulp_language_locator reads (test) data and returns most spoken language (according to data). Future CL will add production data and ability to return multiple languages. - Re-organizing language code locator implementations. - Adding read-only quad tree implementation. - Adding new improved ULP language code locator. - Adding language code locator factory to select implementation. Bug: 850947 Change-Id: Iae662062e9dd0025d4caa89eceb4df3a1e079a6f Reviewed-on: https://chromium-review.googlesource.com/c/1358633 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#620846} [modify] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/BUILD.gn [modify] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/geo_language_provider.cc [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/language_code_locator_provider.cc [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/language_code_locator_provider.h [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/BUILD.gn [rename] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/adminregionsdata.csv [rename] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/convert_s2_cell.py [rename] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/regional_language_code_locator.cc [rename] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/regional_language_code_locator.h [rename] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/regional_language_code_locator_unittest.cc [rename] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/regional_language_code_locator/template/regional_language_code_locator_helper.h.tmpl [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/BUILD.gn [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/geolanguage-data_rank0.txt [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/s2langquadtree.cc [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/s2langquadtree.h [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/s2langquadtree_unittest.cc [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.cc [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.h [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_helper.h.tmpl [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_unittest.cc [add] https://crrev.com/6063cec9d2bfb3da334dd430a8a17c1236ffe85f/components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fda01685a6ba0a24d34163439bd1801cbff4fd5 commit 7fda01685a6ba0a24d34163439bd1801cbff4fd5 Author: Alexandre Frechette <frechette@chromium.org> Date: Fri Jan 11 19:36:10 2019 Unit test to cross check serialized data against complete data. (1) Adds an optional test to check serialized data against complete data. (2) Add script to move data from a single arbitrary folder to the correct locations in chromium. (3) Update data to latest version. (4) Fix serialized data to C script so that bytes to uint32 conversion is done manually. Bug: 850947 Change-Id: I84d5a6e34a99eee60c973525f2c8358c583d3a87 Reviewed-on: https://chromium-review.googlesource.com/c/1383351 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#622095} [modify] https://crrev.com/7fda01685a6ba0a24d34163439bd1801cbff4fd5/.gitignore [modify] https://crrev.com/7fda01685a6ba0a24d34163439bd1801cbff4fd5/components/language/content/browser/ulp_language_code_locator/BUILD.gn [modify] https://crrev.com/7fda01685a6ba0a24d34163439bd1801cbff4fd5/components/language/content/browser/ulp_language_code_locator/geolanguage-data_rank0.txt [add] https://crrev.com/7fda01685a6ba0a24d34163439bd1801cbff4fd5/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_datatest.cc [modify] https://crrev.com/7fda01685a6ba0a24d34163439bd1801cbff4fd5/components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py [add] https://crrev.com/7fda01685a6ba0a24d34163439bd1801cbff4fd5/components/language/content/browser/ulp_language_code_locator/update_data.sh
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/244e2590bc07355f06550bd8938e4cbb7ccefd9a commit 244e2590bc07355f06550bd8938e4cbb7ccefd9a Author: Alexandre Frechette <frechette@chromium.org> Date: Tue Jan 15 03:54:28 2019 Adding geo language provider unit test. Bug: 850947 Change-Id: Ieef2136383341d37d43deb274b7f9ec4cf44f38b Reviewed-on: https://chromium-review.googlesource.com/c/1407590 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#622719} [modify] https://crrev.com/244e2590bc07355f06550bd8938e4cbb7ccefd9a/components/language/content/browser/BUILD.gn [modify] https://crrev.com/244e2590bc07355f06550bd8938e4cbb7ccefd9a/components/language/content/browser/geo_language_provider_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6b6b4d6a3693171a005916d33aa3368cc1114b4 commit e6b6b4d6a3693171a005916d33aa3368cc1114b4 Author: Alexandre Frechette <frechette@chromium.org> Date: Fri Jan 18 17:09:09 2019 Return more than a single language with ULP language code locator. - Modifies UlpLanguageCodeLocator and its helper functions to support more than a single quadtree. - Adds second and third most spoken languages data, and modifies BUILD process to embed them into the helper functions. - Augments the test for this extended functionality. Bug: 850947 Change-Id: Ie2c44bbb562d8905454fb2dcf594d7eb4df9a3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1409606 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#624169} [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/geo_language_provider.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/geo_language_provider_unittest.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/language_code_locator.h [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/language_code_locator_provider.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/regional_language_code_locator/regional_language_code_locator.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/regional_language_code_locator/regional_language_code_locator.h [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/regional_language_code_locator/regional_language_code_locator_unittest.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/BUILD.gn [add] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/geolanguage-data_rank1.txt [add] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/geolanguage-data_rank2.txt [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/s2langquadtree.h [rename] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/s2langquadtree_datatest.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator.h [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_helper.h.tmpl [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/ulp_language_code_locator_unittest.cc [modify] https://crrev.com/e6b6b4d6a3693171a005916d33aa3368cc1114b4/components/language/content/browser/ulp_language_code_locator/ulp_serialized_to_static_c.py
Comment 1 by anthonyvd@chromium.org
, Jun 8 2018