New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850878 link

Starred by 3 users
Status: Fixed
Owner:
marinaciocea@chromium.org
Closed: Sep 12
Cc:
ossu@chromium.org
rsesek@chromium.org
solenberg@chromium.org
█ olka@chromium.org
█ penny...@chromium.org
dcheng@chromium.org
maxmorin@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Feature

Blocking:
issue 851959
issue 874784


Participants' hotlists:
Audio-Service


Sign in to add a comment

Sandbox the audio service to the extent possible

Project Member Reported by maxmorin@chromium.org, Jun 8 2018 
Tracking bug for sandboxing-related work.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d29b59221e6e89c9ede343c487d38399eaeb368a

commit d29b59221e6e89c9ede343c487d38399eaeb368a
Author: Max Morin <maxmorin@chromium.org>
Date: Fri Jun 08 09:42:17 2018

Remove unused CoreAudioUtil::GetDxDiagDetails.

We want to simplify the code as much as possible to enable sandboxing.
DXDiag seems like something that we won't give access to by default.

Bug:  850878 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I450cb6b6caf64c4299d286b8c38940fbe65e1432
Reviewed-on: https://chromium-review.googlesource.com/1092495
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565597}
[modify] https://crrev.com/d29b59221e6e89c9ede343c487d38399eaeb368a/media/audio/win/core_audio_util_win.cc
[modify] https://crrev.com/d29b59221e6e89c9ede343c487d38399eaeb368a/media/audio/win/core_audio_util_win.h
[modify] https://crrev.com/d29b59221e6e89c9ede343c487d38399eaeb368a/media/audio/win/core_audio_util_win_unittest.cc

Comment 2 by maxmorin@chromium.org, Jun 12 2018

Blocking: 851959

Comment 3 by maxmorin@chromium.org, Jun 13 2018

Owner: marinaciocea@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20b0900c15faee4ec41c5fae408a8ea5821099ec

commit 20b0900c15faee4ec41c5fae408a8ea5821099ec
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Jul 10 16:38:54 2018

In --message-loop-type-ui utility processes do not use an NSApplication loop.

These utility processes just need an NSRunLoop to pump system work
rather than a full NSApp loop. From a sandboxing perspective,
initializing NSApplication is undesirable and unnecessary.

Bug:  850878 , 851556
Change-Id: I50864bff78d1d97b5a6eab543fd3552fa590f9b6
Reviewed-on: https://chromium-review.googlesource.com/1131514
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573765}
[modify] https://crrev.com/20b0900c15faee4ec41c5fae408a8ea5821099ec/content/utility/utility_main.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8b7b43d60f590eba54721bde22a485dfe21716d

commit f8b7b43d60f590eba54721bde22a485dfe21716d
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Fri Jul 13 09:53:33 2018

Sandbox audio service process on Windows.

Add sandboxing for audio service process, in preparation for moving APM to audio service[1].

Audio process privilege requirements:
- Lockdown level of USER_LIMITED
- Delayed integrity level of INTEGRITY_LEVEL_LOW
For audio streams to create shared memory regions (using CreateFileMapping()), both settings
are needed.

[1] APM design doc: http://doc/1HJnii4kuBXshVM202TVPJt_9iDmlaCX-VhatjRxRbC4#heading=h.hv3b16z7nhgt
Audio service Windows Sandboxing design draft: http://doc/15rT2e5tzfPBCwmdQjnC49lxIgjrSzbCDZbLxU9QxeT0#heading=h.xgjl2srtytjt

Bug:  850878 
Change-Id: I9b615e58f23ffee89bc41ab921a5878eed1b4b17
Reviewed-on: https://chromium-review.googlesource.com/1128888
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Penny MacNeil <pennymac@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574869}
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/content/browser/utility_process_host.cc
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/content/browser/webrtc/webrtc_audio_browsertest.cc
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/audio/BUILD.gn
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/audio/DEPS
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/audio/OWNERS
[add] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/audio/audio_sandbox_win.cc
[add] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/audio/audio_sandbox_win.h
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/audio/manifest.json
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/features.cc
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/features.h
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/sandbox_type.cc
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/sandbox_type.h
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/switches.cc
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/switches.h
[modify] https://crrev.com/f8b7b43d60f590eba54721bde22a485dfe21716d/services/service_manager/sandbox/win/sandbox_win.cc

Comment 6 by dalecur...@chromium.org, Jul 19

Labels: M-69

Comment 7 by olka@chromium.org, Jul 24

Status: Started (was: Assigned)

Comment 9 by dalecur...@chromium.org, Jul 27 

You're the owner of a Pri-1 M-69 chrome media issue. M-69 is now in beta and will ship to stable in coming weeks. See go/chromeschedule. Please work on resolving your issue ASAP if it needs fixing for the M-69 branch.

Pri-1 means the work is required for the branch. Alternatively, update the milestone to M-70 or remove the milestone and drop the priority to P-3.

Comment 10 by marinaciocea@chromium.org, Jul 30

Labels: -M-69 M-70
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc7c07308016766a798dac600d8a9cb2bb44a43d

commit dc7c07308016766a798dac600d8a9cb2bb44a43d
Author: Robert Sesek <rsesek@chromium.org>
Date: Fri Aug 03 22:18:24 2018

[Mac] Bring up the audio service sandbox.

This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox

Bug:  850878 
Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
Reviewed-on: https://chromium-review.googlesource.com/1152080
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580672}
[modify] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/services/service_manager/sandbox/mac/BUILD.gn
[add] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/dc7c07308016766a798dac600d8a9cb2bb44a43d/services/service_manager/sandbox/sandbox_type.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/581f1e6240de644f7f3bcd671355187f28d3fd00

commit 581f1e6240de644f7f3bcd671355187f28d3fd00
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 06 03:03:15 2018

Revert "[Mac] Bring up the audio service sandbox."

This reverts commit dc7c07308016766a798dac600d8a9cb2bb44a43d.

Reason for revert: suspected of breakage in 'browser_tests' on Mac:  crbug.com/871106 

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761


Original change's description:
> [Mac] Bring up the audio service sandbox.
> 
> This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> 
> Bug:  850878 
> Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> Reviewed-on: https://chromium-review.googlesource.com/1152080
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580672}

TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  850878 , 871106 
Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
Reviewed-on: https://chromium-review.googlesource.com/1163230
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580793}
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/mac/BUILD.gn
[delete] https://crrev.com/2ce2ffc84e03b4e03e019ae89d536e2126f1372d/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/sandbox_type.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 6

Labels: merge-merged-3514
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3792c7a03e8548e70b3457a6ea4710b8b72a363c

commit 3792c7a03e8548e70b3457a6ea4710b8b72a363c
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 06 15:02:20 2018

Revert "[Mac] Bring up the audio service sandbox."

This reverts commit dc7c07308016766a798dac600d8a9cb2bb44a43d.

Reason for revert: suspected of breakage in 'browser_tests' on Mac:  crbug.com/871106 

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761


Original change's description:
> [Mac] Bring up the audio service sandbox.
> 
> This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> 
> Bug:  850878 
> Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> Reviewed-on: https://chromium-review.googlesource.com/1152080
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580672}

TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  850878 , 871106 
Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
Reviewed-on: https://chromium-review.googlesource.com/1163230
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580793}(cherry picked from commit 581f1e6240de644f7f3bcd671355187f28d3fd00)
Reviewed-on: https://chromium-review.googlesource.com/1162117
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3514@{#3}
Cr-Branched-From: d614235c00db75b9ab192974fcbd16755a557471-refs/heads/master@{#580790}
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/mac/BUILD.gn
[delete] https://crrev.com/4d5325a62a5be7f88c50524f8e4f4807908cd514/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/sandbox_type.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135

commit aec2d9df7e61a6d5fb13e8a6ec018a06126c1135
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Wed Aug 08 08:27:55 2018

Reland "[Mac] Bring up the audio service sandbox."

This reverts commit 581f1e6240de644f7f3bcd671355187f28d3fd00.

Reason for revert: Found issue causing initial revert, minor fix required.

Original change's description:
> Revert "[Mac] Bring up the audio service sandbox."
>
> This reverts commit dc7c07308016766a798dac600d8a9cb2bb44a43d.
>
> Reason for revert: suspected of breakage in 'browser_tests' on Mac:  crbug.com/871106 
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761
>
>
> Original change's description:
> > [Mac] Bring up the audio service sandbox.
> >
> > This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> >
> > Bug:  850878 
> > Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> > Reviewed-on: https://chromium-review.googlesource.com/1152080
> > Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Robert Sesek <rsesek@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580672}
>
> TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug:  850878 , 871106 
> Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
> Reviewed-on: https://chromium-review.googlesource.com/1163230
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580793}

TBR=avi@chromium.org,ksakamoto@chromium.org,kerrnel@chromium.org,rsesek@chromium.org


Bug:  850878 ,  871106 
Change-Id: I88ac82097e8cd0af0bc72c7cac3b90f63dcf633b
Reviewed-on: https://chromium-review.googlesource.com/1164983
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581500}
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/BUILD.gn
[add] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/sandbox_type.cc

Comment 15 by dalecur...@chromium.org, Aug 9

Cc: rsesek@chromium.org
+rsesek for tracking, since I'm not sure why the sandbox enables Video.

Comment 16 by rsesek@chromium.org, Aug 13 

That line doesn't enable video support, it just lets files from that directory be read. If testing that removing the line is okay, then we can do so.
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f055fc33a54066b737f624e2a0fe97ceff82676

commit 1f055fc33a54066b737f624e2a0fe97ceff82676
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Aug 21 17:25:17 2018

Remove unnecessary /Library/Video path from audio.sb.

Bug:  850878 
Change-Id: Id8a8a9546a18671ec8654e8a73156de77a377b26
Reviewed-on: https://chromium-review.googlesource.com/1183621
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584814}
[modify] https://crrev.com/1f055fc33a54066b737f624e2a0fe97ceff82676/services/service_manager/sandbox/mac/audio.sb
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03

commit 2ea45c062c0d59ed81ec5f185a23ffb39c34ff03
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Fri Aug 31 18:55:36 2018

Sandbox audio service on Linux.

Run audio service process in sandboxed mode on Linux. Sandbox is enabled behind finch experiment flag:
--enable-features=AudioServiceStreams,AudioServiceOutOfProcess,AudioServiceSandbox

TBR=mpdenton@chromium.org, palmer@chromium.org, tsepez@chromium.com


Bug:  850878 
Change-Id: Iba6b84adc8c4a62ac4c20d5b36aa4f21b36a1574
Reviewed-on: https://chromium-review.googlesource.com/1160844
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588100}
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/content/browser/utility_process_host.cc
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/content/utility/utility_main.cc
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/audio/BUILD.gn
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/audio/DEPS
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/audio/OWNERS
[add] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/audio/audio_sandbox_hook_linux.cc
[add] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/audio/audio_sandbox_hook_linux.h
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/service_manager/sandbox/BUILD.gn
[add] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc
[add] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/service_manager/sandbox/linux/bpf_audio_policy_linux.h
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc
[modify] https://crrev.com/2ea45c062c0d59ed81ec5f185a23ffb39c34ff03/services/service_manager/sandbox/sandbox_type.cc

Comment 19 Deleted

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/140b50023d81c79086ca94ce9cf77e574e5840e3

commit 140b50023d81c79086ca94ce9cf77e574e5840e3
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Aug 31 19:35:30 2018

Revert "Sandbox audio service on Linux."

This reverts commit 2ea45c062c0d59ed81ec5f185a23ffb39c34ff03.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 588100 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJlYTQ1YzA2MmMwZDU5ZWQ4MWVjNWYxODVhMjNmZmIzOWMzNGZmMDMM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/87361

Sample Failed Step: compile

Original change's description:
> Sandbox audio service on Linux.
> 
> Run audio service process in sandboxed mode on Linux. Sandbox is enabled behind finch experiment flag:
> --enable-features=AudioServiceStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> 
> TBR=mpdenton@chromium.org, palmer@chromium.org, tsepez@chromium.com
> 
> 
> Bug:  850878 
> Change-Id: Iba6b84adc8c4a62ac4c20d5b36aa4f21b36a1574
> Reviewed-on: https://chromium-review.googlesource.com/1160844
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588100}

Change-Id: I64a6f98f7b2a89e47324a37bf8e91fda6caa0e7d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  850878 
Reviewed-on: https://chromium-review.googlesource.com/1199855
Cr-Commit-Position: refs/heads/master@{#588121}
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/content/browser/utility_process_host.cc
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/content/utility/utility_main.cc
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/services/audio/BUILD.gn
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/services/audio/DEPS
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/services/audio/OWNERS
[delete] https://crrev.com/d9e3f4b3e76514558d471655b4ee72baeaccdccd/services/audio/audio_sandbox_hook_linux.cc
[delete] https://crrev.com/d9e3f4b3e76514558d471655b4ee72baeaccdccd/services/audio/audio_sandbox_hook_linux.h
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/services/service_manager/sandbox/BUILD.gn
[delete] https://crrev.com/d9e3f4b3e76514558d471655b4ee72baeaccdccd/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc
[delete] https://crrev.com/d9e3f4b3e76514558d471655b4ee72baeaccdccd/services/service_manager/sandbox/linux/bpf_audio_policy_linux.h
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc
[modify] https://crrev.com/140b50023d81c79086ca94ce9cf77e574e5840e3/services/service_manager/sandbox/sandbox_type.cc

Comment 21 by marinaciocea@chromium.org, Aug 31

Labels: -Merge-Request-70
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2fc90bb74a05cffde6b4363ee575fcca7c45197

commit f2fc90bb74a05cffde6b4363ee575fcca7c45197
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Mon Sep 03 08:47:08 2018

Reland "Sandbox audio service on Linux."

This is a reland of 2ea45c062c0d59ed81ec5f185a23ffb39c34ff03

Reason for reland: Fixed i386 build.

TBR=rsesek@chromium.org, nasko@chromium.org, olka@chromium.org


Original change's description:
> Sandbox audio service on Linux.
>
> Run audio service process in sandboxed mode on Linux. Sandbox is enabled behind finch experiment flag:
> --enable-features=AudioServiceStreams,AudioServiceOutOfProcess,AudioServiceSandbox
>
> TBR=mpdenton@chromium.org, palmer@chromium.org, tsepez@chromium.com
>
>
> Bug:  850878 
> Change-Id: Iba6b84adc8c4a62ac4c20d5b36aa4f21b36a1574
> Reviewed-on: https://chromium-review.googlesource.com/1160844
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588100}


Bug:  850878 
Change-Id: Id56fb1b95cfcc8b78c013e7f1a90b63a419205ba
Reviewed-on: https://chromium-review.googlesource.com/1199506
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588351}
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/content/browser/utility_process_host.cc
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/content/utility/utility_main.cc
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/audio/BUILD.gn
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/audio/DEPS
[add] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/audio/audio_sandbox_hook_linux.cc
[add] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/audio/audio_sandbox_hook_linux.h
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/service_manager/sandbox/BUILD.gn
[add] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc
[add] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/service_manager/sandbox/linux/bpf_audio_policy_linux.h
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc
[modify] https://crrev.com/f2fc90bb74a05cffde6b4363ee575fcca7c45197/services/service_manager/sandbox/sandbox_type.cc
Project Member

Comment 23 by bugdroid1@chromium.org, Sep 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c52a018e2b83e04de2a89721f954f8c03e369877

commit c52a018e2b83e04de2a89721f954f8c03e369877
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Mon Sep 03 09:05:45 2018

Add linux sandbox owners for audio sandbox hook.

Bug:  850878 
Change-Id: I215d84b4e3c8234ba8e318fd27ecb22739f950d3
Reviewed-on: https://chromium-review.googlesource.com/1201842
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588356}
[modify] https://crrev.com/c52a018e2b83e04de2a89721f954f8c03e369877/services/audio/OWNERS

Comment 24 by marinaciocea@chromium.org, Sep 4

Labels: Merge-Request-70
Requesting merge for Linux sandbox CL (#22).
Project Member

Comment 25 by sheriffbot@chromium.org, Sep 4

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 26 by abdulsyed@google.com, Sep 4

Labels: -Merge-Review-70 Merge-Approved-70
Approving merge to M70.
Project Member

Comment 27 by cr-audit...@appspot.gserviceaccount.com, Sep 5

Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 193308c2957090e1ff7081e2c5739bddcaee1c20 was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!

Comment 28 by marinaciocea@chromium.org, Sep 5 

Re #27: I merged #22 based on #26 approval.

Perhaps OnlyMergeApprovedChange rule failed because this bug contains multiple CLs?

Comment 29 by abdulsyed@google.com, Sep 5

Labels: -CommitLog-Audit-Violation

Comment 30 by abdulsyed@google.com, Sep 5 

You can ignore that label for now. There was a bug in the script.

Comment 31 by abdulsyed@google.com, Sep 5

Labels: -Merge-Without-Approval
Project Member

Comment 32 by bugdroid1@chromium.org, Sep 5

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/193308c2957090e1ff7081e2c5739bddcaee1c20

commit 193308c2957090e1ff7081e2c5739bddcaee1c20
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Wed Sep 05 07:27:41 2018

Reland "Sandbox audio service on Linux."

This is a reland of 2ea45c062c0d59ed81ec5f185a23ffb39c34ff03

Reason for reland: Fixed i386 build.

TBR=rsesek@chromium.org, nasko@chromium.org, olka@chromium.org


Original change's description:
> Sandbox audio service on Linux.
>
> Run audio service process in sandboxed mode on Linux. Sandbox is enabled behind finch experiment flag:
> --enable-features=AudioServiceStreams,AudioServiceOutOfProcess,AudioServiceSandbox
>
> TBR=mpdenton@chromium.org, palmer@chromium.org, tsepez@chromium.com
>
>
> Bug:  850878 
> Change-Id: Iba6b84adc8c4a62ac4c20d5b36aa4f21b36a1574
> Reviewed-on: https://chromium-review.googlesource.com/1160844
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588100}


Bug:  850878 
Change-Id: Id56fb1b95cfcc8b78c013e7f1a90b63a419205ba
Reviewed-on: https://chromium-review.googlesource.com/1199506
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588351}(cherry picked from commit f2fc90bb74a05cffde6b4363ee575fcca7c45197)
Reviewed-on: https://chromium-review.googlesource.com/1206330
Cr-Commit-Position: refs/branch-heads/3538@{#43}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/content/browser/utility_process_host.cc
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/content/utility/utility_main.cc
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/audio/BUILD.gn
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/audio/DEPS
[add] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/audio/audio_sandbox_hook_linux.cc
[add] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/audio/audio_sandbox_hook_linux.h
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/service_manager/sandbox/BUILD.gn
[add] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/service_manager/sandbox/linux/bpf_audio_policy_linux.cc
[add] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/service_manager/sandbox/linux/bpf_audio_policy_linux.h
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/service_manager/sandbox/linux/sandbox_seccomp_bpf_linux.cc
[modify] https://crrev.com/193308c2957090e1ff7081e2c5739bddcaee1c20/services/service_manager/sandbox/sandbox_type.cc

Comment 33 by marinaciocea@chromium.org, Sep 12

Status: Fixed (was: Started)

Comment 34 by ossu@chromium.org, Oct 3

Blocking: 874784
►

Sign in to add a comment