New issue
Advanced search Search tips

Issue 850877 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted scroll bar is seen on extension option overlay even when text content is short

Reported by aiman.an...@etouch.net, Jun 8 2018

Issue description

Version: 69.0.3452.0 (Official Build) Revision 0d0b79e107ffa727bd13f2636984c125ffc2040c-refs/branch-heads/3452@{#1}(32/64-bit)

OS: Windows(7,8,8.1,10), Linux (14.04 LTS), Mac (10.12.6,10.13.1,10.13.6).

Pre-condition : Install the https://chrome.google.com/webstore/detail/pulse-extension/jjbjdleccaiklfpcblgekgmjadjdclkp

What steps will reproduce the problem?
1. Launch chrome, right click on extension icon in omnibox and select Option from extension context menu
2. Observe the Extension option overlay.
 
Actual: Unwanted scroll bar is seen on extension option overlay even when text content is short.
Expected: Scroll bar should be seen when text content is more.

This is regression issue, broken in ‘M 69’ and below is the bisect info :
Good build: 69.0.3450.0 (Revision:564324).
Bad build: 69.0.3451.0 (Revision:564768).

You are probably looking for a change made after 564711 (known good), but no later than 564712 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b11ce870921e1483cac76e0292fa1e646e12f2ef..fc9eab356c74d336af3dce361b462c5bf32a870e

Suspect :https://chromium.googlesource.com/chromium/src/+/fc9eab356c74d336af3dce361b462c5bf32a870e

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!

 
 
Actual Result.mp4
339 KB View Download
Expected Result.mp4
246 KB View Download
Status: Assigned (was: Unconfirmed)

Comment 2 by aee@chromium.org, Jun 8 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9e104e25242f36ddd3f0e6450499495823fbc3

commit 0d9e104e25242f36ddd3f0e6450499495823fbc3
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jun 13 18:48:02 2018

Extensions WebUI: replace hardcoded value causing body scroll with value from element

Bug:  850877 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idc3c4520ab26400fbbca3490e038b1d25f4a8727
Reviewed-on: https://chromium-review.googlesource.com/1093262
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566934}
[modify] https://crrev.com/0d9e104e25242f36ddd3f0e6450499495823fbc3/chrome/browser/resources/md_extensions/options_dialog.js

Comment 4 by aee@chromium.org, Jun 13 2018

Status: Fixed (was: Started)

Sign in to add a comment