New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850871 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug


Participants' hotlists:
Audio-Service


Sign in to add a comment

Add observed audio service downtime after stop UMA metrics

Project Member Reported by marinaciocea@chromium.org, Jun 8 2018

Issue description

Add metric measuring time between service stop and service start.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a80079af10fb187c280bcf8a0625e8863d8eb2d

commit 9a80079af10fb187c280bcf8a0625e8863d8eb2d
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Sat Jun 09 03:24:55 2018

Split observed audio service downtime UMA metric.

Previously observed downtime metric is split into:
- Initial downtime, representing the time interval between audio service listener
  construction (or browser start) and first audio service start.
- Downtime(2), representing the time interval between service stop and and the next
  service startup.
This split is needed to help adjust the duration of audio service quit timeout.

Audio service design doc: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit?usp=sharing

Unrelated change: shorten some unittest names to fit into 80 characters long lines.

Bug:  850871 
Change-Id: If3a3bebaa4104a6b8c354629259c9e5a74c05d13
Reviewed-on: https://chromium-review.googlesource.com/1092537
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565832}
[modify] https://crrev.com/9a80079af10fb187c280bcf8a0625e8863d8eb2d/content/browser/renderer_host/media/audio_service_listener.cc
[modify] https://crrev.com/9a80079af10fb187c280bcf8a0625e8863d8eb2d/content/browser/renderer_host/media/audio_service_listener.h
[modify] https://crrev.com/9a80079af10fb187c280bcf8a0625e8863d8eb2d/content/browser/renderer_host/media/audio_service_listener_unittest.cc
[modify] https://crrev.com/9a80079af10fb187c280bcf8a0625e8863d8eb2d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Merge-Request-68 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
This change is needed in Beta release for analyzing audio service quit timeout, and adjust it accordingly.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 12 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving it for M68. BRanch:3440
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 12 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e86bf9a6b996348f0c437334899d2c3e26d005

commit 02e86bf9a6b996348f0c437334899d2c3e26d005
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Tue Jun 12 19:14:09 2018

Split observed audio service downtime UMA metric.

Previously observed downtime metric is split into:
- Initial downtime, representing the time interval between audio service listener
  construction (or browser start) and first audio service start.
- Downtime(2), representing the time interval between service stop and and the next
  service startup.
This split is needed to help adjust the duration of audio service quit timeout.

Audio service design doc: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit?usp=sharing

Unrelated change: shorten some unittest names to fit into 80 characters long lines.

Bug:  850871 
Change-Id: If3a3bebaa4104a6b8c354629259c9e5a74c05d13
Reviewed-on: https://chromium-review.googlesource.com/1092537
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565832}(cherry picked from commit 9a80079af10fb187c280bcf8a0625e8863d8eb2d)
Reviewed-on: https://chromium-review.googlesource.com/1097715
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#308}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/02e86bf9a6b996348f0c437334899d2c3e26d005/content/browser/renderer_host/media/audio_service_listener.cc
[modify] https://crrev.com/02e86bf9a6b996348f0c437334899d2c3e26d005/content/browser/renderer_host/media/audio_service_listener.h
[modify] https://crrev.com/02e86bf9a6b996348f0c437334899d2c3e26d005/content/browser/renderer_host/media/audio_service_listener_unittest.cc
[modify] https://crrev.com/02e86bf9a6b996348f0c437334899d2c3e26d005/tools/metrics/histograms/histograms.xml

Sign in to add a comment