gn args:

dcheck_always_on = true
is_asan = true
is_component_build = false
is_debug = false
is_lsan = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1
use_goma = true


invocation:

$ ASAN_OPTIONS="symbolize=1 external_symbolizer_path=third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer detect_leaks=1" out/release/content_browsertests --gtest_filter=MediaSessionServiceImplBrowserTest.CrashMessageOnUnload

It reproduces locally with pinned clang (332838-1.tgz) too.

But it didn't repro on tryjobs with this whitespace change:
https://chromium-review.googlesource.com/c/chromium/src/+/1090917

I was using Chromium #564891.

Is it the same on trunk?

Yes, reproduces with #565592 too. No idea why the whitespace change doesn't show this, then.

$ gn clean out/release
$ gn gen out/release
$ ninja -C out/release -j1000 content_browsertests

Still repros. Definitely a trunk problem, then.

Attaching the output

Deleted: out.txt 142 KB

out.txt 142 KB View Download

The test is not new; it was added here: https://codereview.chromium.org/2711293003

Tried syncing back to January 1 (#527141) with the same result.

Oh, but the buildbot is passing --no-sandbox to the invocation:

$ ASAN_OPTIONS="symbolize=1 external_symbolizer_path=third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer detect_leaks=1" out/release/content_browsertests --gtest_filter=MediaSessionServiceImplBrowserTest.CrashMessageOnUnload --no-sandbox

With that, I don't see any leak on trunk, but I do after the clang roll.

So to summarize, the test fails under LSan on trunk when invoked straight-up, i.e. like this:

$ ASAN_OPTIONS="symbolize=1 external_symbolizer_path=third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer detect_leaks=1" out/release/content_browsertests --gtest_filter=MediaSessionServiceImplBrowserTest.CrashMessageOnUnload

So far this hasn't showed on bots, because they run it with --no-sandbox, which for some reason hid the problem until recent Clang versions.

It seems the way forward is to get the leaks fixed and suppressing until that's done.

Disabling the test under lsan: https://chromium-review.googlesource.com/c/chromium/src/+/1092737

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c1aa9424a2e275f07cb7ee03964a4d584af4c3d

commit 1c1aa9424a2e275f07cb7ee03964a4d584af4c3d
Author: Hans Wennborg <hans@chromium.org>
Date: Mon Jun 11 13:33:09 2018

Disable MediaSessionServiceImplBrowserTest.CrashMessageOnUnload under LSan

It seems it's been leaking for some time, but this didn't show on
buildbots running it with --no-sandbox. With recent Clang versions
the leaks are starting to show up anyway.

These are hard to suppress because they are in callbacks, some of which
run without anything MediaSession related on the stack, so instead this
disables the test under LSan until it's fixed.

Bug: 850870
Change-Id: Ib9d098c64f4a6db3cb68fb796a35219fdba74f35
Reviewed-on: https://chromium-review.googlesource.com/1092737
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565985}
[modify] https://crrev.com/1c1aa9424a2e275f07cb7ee03964a4d584af4c3d/content/browser/media/session/media_session_service_impl_browsertest.cc

That should unblock the clang roll.

-> mlamouri for tackling the leaks at some point

 Issue 851933  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdb62454c0662e0dadb7065aa635c5920225c7a2

commit cdb62454c0662e0dadb7065aa635c5920225c7a2
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Jun 12 14:58:15 2018

Disable MediaSessionServiceImplBrowserTest.* under LSan

One of the tests was previously disabled in #565985, but the other tests
fail in the same way, so this disables them too.

TBR=mlamouri

Bug: 850870
Change-Id: I3c222c3d2e7b01dec946cf93f46fa5239f8c13de
Reviewed-on: https://chromium-review.googlesource.com/1097328
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566424}
[modify] https://crrev.com/cdb62454c0662e0dadb7065aa635c5920225c7a2/content/browser/media/session/media_session_service_impl_browsertest.cc

Keyword MediaSessionServiceImplBrowserTest.DontResetServiceForSameDocumentNavigation from the dupe