Files.App test code JS auto formatter needs improvement |
||||||
Issue descriptionThere are cases where the 'git cl format --js blah' results are not so great for our Files.App test code in some cases. We should have a way to tell the formatter to "please leave this section of the code alone: we are very happy with the hand-written format thanks".
,
Sep 13
+calamity does this affect you sometimes.
,
Sep 13
// clang-format off
a = [
'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a',
'a', 'a', 'a', 'a', 'a', 'a',
'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a', 'a',
];
// clang-format on
That'll do it.
,
Sep 13
Coolio, adding that to our docs.
,
Sep 21
,
Sep 21
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32be5d8a20a0f9d3ddaf0b574b9e639eec38738c commit 32be5d8a20a0f9d3ddaf0b574b9e639eec38738c Author: Noel Gordon <noel@chromium.org> Date: Fri Sep 21 08:44:28 2018 gear_menus.js: add a trailing comma to preserve list style The JS auto-formatter will keep "list-style" iff Object or Array lists have a trailing comma. Bug: 850843 Change-Id: I35a7898524d2db824cebdb7dff4dec95c3c153c8 Reviewed-on: https://chromium-review.googlesource.com/1237756 Reviewed-by: Stuart Langley <slangley@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593123} [modify] https://crrev.com/32be5d8a20a0f9d3ddaf0b574b9e639eec38738c/ui/file_manager/integration_tests/file_manager/gear_menu.js
,
Sep 21
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sashab@chromium.org
, Jun 8 2018Labels: CrOSFilesCategory-Testing
Status: Available (was: Untriaged)