New issue
Advanced search Search tips

Issue 850840 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Today
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

Check OnActivityResult in ARCoreJavaUtils to check when the ARCore install intent returns

Project Member Reported by ijamardo@chromium.org, Jun 8 2018

Issue description

Right now ARCoreDevice checks deferred callbacks when ResumeTracking is called (assuming that the page is resumed after returning from the intent to install ARCore).
 
Labels: -projXR-AR AR-Cleanup Proj-XR-AR
Components: Blink>WebXR>AR
Will changes in how we install ARCore affect this? If so, we may want to implement that first.
Owner: bialpio@chromium.org
Status: Started (was: Available)
Assigning to myself as I have a CL pending that should fix this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d0280d6ec272b6f935e877a6fac648ca2a20ef3

commit 1d0280d6ec272b6f935e877a6fac648ca2a20ef3
Author: Piotr Bialecki <bialpio@chromium.org>
Date: Fri Jan 18 21:47:03 2019

Start leveraging ARCore SDK's InstallActivity

More significant changes:
- rename nativeOnRequestInstallSupportedArCoreCanceled into
  nativeOnRequestInstallSupportedArCoreResult and add boolean parameter
  to it in order to propagate result of installation
- modify ArCoreJavaUtils to start using ArCoreApk.requestInstall via
  reflection
- notify ArDelegate when ChromeActivity's onResumeWithNative
  gets called
- ArDelegate will notify ArCoreJavaUtils that the activity is
  being resumed

Bug:  916651 ,  850840 
Change-Id: I0d906f3bee7f19f36e1f532670e079018d4120b0
Reviewed-on: https://chromium-review.googlesource.com/c/1406192
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624303}
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/chrome_public_apk_tmpl.gni
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreJavaUtils.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreShim.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArCoreShimImpl.java
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegate.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegateImpl.java
[add] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java/src/org/chromium/chrome/browser/vr/ArDelegateProvider.java
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/java_sources.gni
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/android/modules/ar/ar_module_tmpl.gni
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/BUILD.gn
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_device.cc
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_device.h
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_java_utils.cc
[modify] https://crrev.com/1d0280d6ec272b6f935e877a6fac648ca2a20ef3/chrome/browser/android/vr/arcore_device/arcore_java_utils.h

Comment 6 by bialpio@chromium.org, Today (12 hours ago)

Status: Fixed (was: Started)
Our current approach of installing ARCore via ArCoreApk.requestInstall() from ARCore SDK makes this bug no longer applicable as we have a different approach of checking the status of installation.

Sign in to add a comment