Chrome Version: M69 OS: Android The bottom toolbar should be shown immediately but this is currently not possible since its flag is only available after native is loaded.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ff8c965710cb73bfbbf481cf146716c853c9750 commit 4ff8c965710cb73bfbbf481cf146716c853c9750 Author: Pedro Amaral <amaralp@chromium.org> Date: Fri Jun 08 02:47:30 2018 Cache bottom toolbar flag The bottom toolbar will need to be shown before native libraries are loaded so we cache the toolbar flag. Bug: 850804 Change-Id: I4699207e5d14cbaa2787479dec86dda9b4a51e79 Reviewed-on: https://chromium-review.googlesource.com/1091918 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#565520} [modify] https://crrev.com/4ff8c965710cb73bfbbf481cf146716c853c9750/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/4ff8c965710cb73bfbbf481cf146716c853c9750/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c775b3bc687d725a500a5d029e77e6d0e966540 commit 7c775b3bc687d725a500a5d029e77e6d0e966540 Author: Pedro Amaral <amaralp@chromium.org> Date: Tue Jun 12 01:42:18 2018 Show bottom toolbar immediately Previously the bottom toolbar was shown after native was loaded. Now it loads immediately and native dependencies are added once they become available. Bug: 850804 Change-Id: I1f72cbe39e77ec64a47e8defbb4ed3a11ede160e Reviewed-on: https://chromium-review.googlesource.com/1094015 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#566236} [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ScrollingBottomViewSceneLayer.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarController.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabSwitcherButtonCoordinator.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/7c775b3bc687d725a500a5d029e77e6d0e966540/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c1234f353dbf6289ebbc1069dc656e42d39855c commit 3c1234f353dbf6289ebbc1069dc656e42d39855c Author: Ted Choc <tedchoc@google.com> Date: Thu Jun 14 19:51:47 2018 Fix crash in bottom bar early startup before native. ScrollingBottomViewSceneLayer extends from SceneLayer and that does a native call in its constructor, which can cause a crash if native isn't loaded. This moves the scene layer to the model and into initializeWithNative. This might be a better short term fix than long term design practice though. BUG= 850804 , 852468 Change-Id: I5cda1e24787ea6558d7ac07b3ef49f6503c32243 Reviewed-on: https://chromium-review.googlesource.com/1100130 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#567381} [modify] https://crrev.com/3c1234f353dbf6289ebbc1069dc656e42d39855c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarController.java [modify] https://crrev.com/3c1234f353dbf6289ebbc1069dc656e42d39855c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java [modify] https://crrev.com/3c1234f353dbf6289ebbc1069dc656e42d39855c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ScrollingBottomViewResourceFrameLayout.java
Comment 1 by bugdroid1@chromium.org
, Jun 8 2018