New issue
Advanced search Search tips

Issue 850799 link

Starred by 1 user
Status: Assigned
Owner:
magchen@chromium.org
Cc:
zmo@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Re-measure the hardware performance/power if the swapchain format is changed from YUY2 to RGBA

Project Member Reported by magchen@chromium.org, Jun 8 2018 
Chrome Version: M69
OS: Win10

The current design in DCLayerTree::SwapChainPresenter::PresentToSwapChain() changes the swapchain format from YUY2 to RGBA (see ShoudBeYUY2()) if the swapchain cannot be promoted to hardware overlay. This result can be queried through swap_chain_media->GetFrameStatisticsMedia(&stats). If the hardware is utilized, stats.CompositionMode is MODE_OVERLAY. Otherwise it shows MODE_COMPOSED. 

The purpose of this change is for performance and power improvement. We should re-measure it on the new hardware, like Intel kabylake, to make sure this design gives us the most benefit.

Also, we should collect separate data for protected videos.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774b7e72621374ab7613a247e2b229d7ae073491

commit 774b7e72621374ab7613a247e2b229d7ae073491
Author: Maggie Chen <magchen@chromium.org>
Date: Wed Jun 20 01:22:43 2018

Always use YUY2 swap chain for protected video.

Don't fallback to BGRA swap chain if DWM fails to promote video to hardware
overlay to make it easier to debug protected video playback. Reassess perf/
power impact later to see if falling back to BGRA is necessary.

BUG=850799,843814

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5222214b0dd11c6c1c922cc1c6904e2ded816086
Reviewed-on: https://chromium-review.googlesource.com/1107099
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568681}
[modify] https://crrev.com/774b7e72621374ab7613a247e2b229d7ae073491/gpu/ipc/service/direct_composition_surface_win.cc
►

Sign in to add a comment