New issue
Advanced search Search tips

Issue 850793 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

sync_stage_unittest failing

Project Member Reported by dgarr...@chromium.org, Jun 8 2018

Issue description

After https://crrev.com/c/1088349, when I run sync_stage_unittest fails for me when run outside the chroot. I don't understand why.



======================================================================
FAIL: [chromite.cbuildbot.stages.sync_stages_unittest] PreCQLauncherStageTest.testPreCQEarlyCrashes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/google/home/dgarrett/sand/clean/chromite/lib/timeout_util.py", line 191, in TimeoutWrapper
    return func(*args, **kwargs)
  File "/usr/local/google/home/dgarrett/sand/clean/chromite/cbuildbot/stages/sync_stages_unittest.py", line 1188, in testPreCQEarlyCrashes
    self.assertAllStatuses(changes, constants.CL_PRECQ_CONFIG_STATUS_LAUNCHED)
  File "/usr/local/google/home/dgarrett/sand/clean/chromite/cbuildbot/stages/sync_stages_unittest.py", line 956, in assertAllStatuses
    self.assertEqual(progress_map[change][config][0], status)
AssertionError: 'pending' != 'launched'

----------------------------------------------------------------------
Ran 57 tests in 44.096s

FAILED (failures=1)

 
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/52064637896b22b79878ab34707ce85ab6ae9f7a

commit 52064637896b22b79878ab34707ce85ab6ae9f7a
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jun 08 06:33:34 2018

run_tests: Move sync_stages_unittest inside chroot.

CL:1088349 modified the sync_stages_unittests in a why which appears
to fail outside the chroot, so move it inside the chroot during the
standard test run.

BUG= chromium:850793 
TEST=run_tests

Change-Id: I5f621073ad732c9b0f2fe3d5b91f17c8578b49a5
Reviewed-on: https://chromium-review.googlesource.com/1092038
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/52064637896b22b79878ab34707ce85ab6ae9f7a/cbuildbot/run_tests.py

Status: Fixed (was: Started)

Sign in to add a comment