New issue
Advanced search Search tips

Issue 850774 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 842296



Sign in to add a comment

Remove usages of blacklist and whitelist in Declarative Net Request code

Project Member Reported by karandeepb@chromium.org, Jun 8 2018

Issue description

See issue 842296 for more detail
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2860433068296b76190c08acdf857a0a5d4cabc3

commit 2860433068296b76190c08acdf857a0a5d4cabc3
Author: karandeepb <karandeepb@chromium.org>
Date: Sat Jun 16 01:47:19 2018

Declarative Net Request: Replace usages of 'blacklist' and 'whitelist'.

This CL replaces the usages of 'blacklist' and 'whitelist' in the Declarative
Net Request code. It introduces the following changes to the public API:
  - RuleActionType blacklist -> RuleActionType block
  - RuleActionType whitelist -> RuleActionType allow
  - MAX_NUMBER_OF_WHITELISTED_PAGES -> MAX_NUMBER_OF_ALLOWED_PAGES
  - addWhitelistedPages -> addAllowedPages
  - removeWhitelistedPages -> removeAllowedPages
  - getWhitelistedPages -> getAllowedPages

As a result of this change, existing extensions using the Declarative Net
Request API will need to be updated. Usages of these terms in enums and
preference keys are kept as-is.

BUG= 850774 , 842296

Change-Id: Id4aaac5ec3123fd56a1591e22025a455d7cb6941
Reviewed-on: https://chromium-review.googlesource.com/1094141
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567858}
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_apitest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/browser/extensions/api/declarative_net_request/ruleset_manager_unittest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/extension_with_no_ruleset/background.js
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/page_allowing_api/background.js
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/page_allowing_api/manifest.json
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/api_test/declarative_net_request/page_allowing_api/rules_file_empty.json
[rename] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/chrome/test/data/extensions/declarative_net_request/allowing_api.html
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/declarative_net_request_api.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat/extension_ruleset.fbs
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat_ruleset_indexer.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat_ruleset_indexer.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/flat_ruleset_indexer_unittest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/indexed_rule.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/indexed_rule_unittest.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/rules_monitor_service.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_manager.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_manager.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_matcher.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/api/declarative_net_request/ruleset_matcher.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/extension_prefs.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/browser/extension_prefs.h
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/common/api/declarative_net_request.idl
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/extensions/common/api/declarative_net_request/test_utils.cc
[modify] https://crrev.com/2860433068296b76190c08acdf857a0a5d4cabc3/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment