New issue
Advanced search Search tips

Issue 850757 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocked on:
issue 851003



Sign in to add a comment

Update #include sites from <fdio/...> to <lib/fdio/...>

Project Member Reported by w...@chromium.org, Jun 7 2018

Issue description

The FDIO library's headers have moved. We have temporarily updated our include-path for the package.  Once dependencies have been updated we should remove the hack and update the #includes in Chromium.

 

Comment 1 by w...@chromium.org, Jun 8 2018

Blockedon: 851003
Status: Assigned (was: Started)
Temporary #include patch landed in https://chromium-review.googlesource.com/c/chromium/src/+/1092312, but we weren't able to roll the SDK yet, until  issue 851003  is resolved.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c3c6f150cfabd4db88c40ee49036eff2ec995a0

commit 5c3c6f150cfabd4db88c40ee49036eff2ec995a0
Author: Wez <wez@chromium.org>
Date: Sat Jun 09 18:24:02 2018

[Fuchsia] Fix FDIO includes in Chromium to match their new location.

- Update #include sites, and the paths in //third_party/fuchsia-sdk's
  build rules.
- Add //third_party/fuchsia-sdk to the set of "gn check" directories.

TBR: thakis, rockot
Bug:  850757 
Change-Id: I012d50f405ed93fa49ed4aaa0f25783d1e7e9e4b
Reviewed-on: https://chromium-review.googlesource.com/1094145
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565889}
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/.gn
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/fuchsia/component_context.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/fuchsia/services_directory_unittest.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/native_library_fuchsia.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/process/launch.h
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/process/launch_fuchsia.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/process/process_metrics_fuchsia.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/base/process/process_util_unittest.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/mojo/edk/embedder/platform_handle.h
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/mojo/edk/system/channel_fuchsia.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/mojo/public/cpp/platform/platform_handle.cc
[modify] https://crrev.com/5c3c6f150cfabd4db88c40ee49036eff2ec995a0/third_party/fuchsia-sdk/BUILD.gn

Comment 3 by w...@chromium.org, Jun 11 2018

Owner: fdegans@chromium.org
Status: Started (was: Assigned)
Assigning to fdegans@, who is shepherding the necessary dependency rolls, to wrap this up, remove the fdio include_dirs hack, and close out. Thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408ec2cbbca7d90cd5016ebba53497573fb8daa3

commit 408ec2cbbca7d90cd5016ebba53497573fb8daa3
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon Jun 11 21:21:08 2018

Roll src/third_party/googletest/src/ 145d05750..9077ec7ef (11 commits)

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/145d05750b15..9077ec7efe5b

$ git log 145d05750..9077ec7ef --date=short --no-merges --format='%ad %ae %s'
2018-06-11 misterg Removed "Documentation.md" not adding value and not consitent with internal docs
2018-06-11 misterg Rename Samples.md to samples.md and adjust the links
2018-06-11 misterg Rename FAQ.md to faq.md and adjust the links.
2018-06-11 misterg Rename AdvancedGuide.md to advanced.md and adjust the links. Part of documentation rationalization work
2018-06-11 misterg Rename "Primer.md" to "primer.md" and adjust links. Part of the documentaion rationalzation
2018-06-07 steelskin Fuchsia: Change fdio include path.
2018-06-04 misterg Upstream, cl/199129756
2018-05-31 steelskin Clean up
2018-05-30 fdegans Remvoe launchpad dependency from Fuchsia.
2018-05-23 misterg formatting changes
2018-05-23 misterg Formatting changes

Created with:
  roll-dep src/third_party/googletest/src

Bug:  848028 ,  850757 
Change-Id: I561501321fb200d0cf140fa8cde61e1afa593121
Reviewed-on: https://chromium-review.googlesource.com/1087361
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566149}
[modify] https://crrev.com/408ec2cbbca7d90cd5016ebba53497573fb8daa3/DEPS
[modify] https://crrev.com/408ec2cbbca7d90cd5016ebba53497573fb8daa3/third_party/googletest/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1e07a285197b2f0acffd67ff26aac853ca35a11

commit e1e07a285197b2f0acffd67ff26aac853ca35a11
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue Jun 12 00:05:32 2018

Remove the extra include_dir for "fdio" package header.

All necessary changes have landed in Chromium so this is no longer
necessary.

Bug:  850757 
Change-Id: Ie27e0c2a037c60b164455d80817f14e8e074e7dd
Reviewed-on: https://chromium-review.googlesource.com/1096337
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566214}
[modify] https://crrev.com/e1e07a285197b2f0acffd67ff26aac853ca35a11/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni

Owner: scottmg@chromium.org
Sending back to Scott for the remaining cleanup in Crashpad, which I believe should roll out at the same time as the launchpad deprecation.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6

commit bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Jun 12 16:47:21 2018

fuchsia: Update includes for new fdio header location

Also includes a gtest roll, which includes a change in gtest to do the
same thing. This also removes the link against launchpad which is no
longer necessary, and will be removed from the SDK soon.

Bug: crashpad:196,  chromium:848028 ,  chromium:850757 
Change-Id: Ica8632a6157b585d6b44073e05bf7aa43253e305
Reviewed-on: https://chromium-review.googlesource.com/1096353
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

[modify] https://crrev.com/bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6/DEPS
[modify] https://crrev.com/bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6/client/crashpad_client_fuchsia.cc
[modify] https://crrev.com/bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6/test/multiprocess_exec_fuchsia.cc
[modify] https://crrev.com/bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6/third_party/gtest/BUILD.gn
[modify] https://crrev.com/bff3594594abe4fbba8a30e4ee9c2c2b69e93bb6/tools/run_with_crashpad.cc

Cc: -fdegans@chromium.org
Owner: fdegans@chromium.org
Status: Fixed (was: Started)
I think Fabrice did all the work here.

Sign in to add a comment