New issue
Advanced search Search tips

Issue 850755 link

Starred by 3 users
Status: Fixed
Owner:
sclit...@chromium.org
Closed: Jun 2018
Cc:
rajendrant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor lazy frame loading logic out of HTMLFrameOwnerElement

Project Member Reported by sclit...@chromium.org, Jun 7 2018 
Right now there's quite a lot of lazyload-specific logic in HTMLFrameOwnerElement. Most of this should be refactored out into a new file to make the code cleaner and avoid cluttering HTMLFrameOwnerElement.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d76c564d2425f2be7183da7e5379565c76103104

commit d76c564d2425f2be7183da7e5379565c76103104
Author: Scott Little <sclittle@chromium.org>
Date: Mon Jun 11 18:25:00 2018

LazyLoad: Refactor lazy frame loading logic into it's own class.

This CL moves most of the lazy frame loading code out of
HTMLFrameOwnerElement and into a new class, LazyFrameObserver. This
should help make the code cleaner and reduce the code clutter in
HTMLFrameOwnerElement.

Bug:  850755 
Change-Id: I47e245a1ad60b0872a466d02d6517b43d3ad0ee8
Reviewed-on: https://chromium-review.googlesource.com/1092036
Commit-Queue: Scott Little <sclittle@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566066}
[modify] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/html/BUILD.gn
[modify] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/html/html_frame_owner_element.h
[add] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/html/lazy_load_frame_observer.cc
[add] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/html/lazy_load_frame_observer.h
[rename] https://crrev.com/d76c564d2425f2be7183da7e5379565c76103104/third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc

Comment 2 by sclit...@chromium.org, Jun 11 2018

Status: Fixed (was: Started)
►

Sign in to add a comment