New issue
Advanced search Search tips

Issue 850745 link

Starred by 1 user
Status: Fixed
Owner:
penghuang@chromium.org
Closed: Jun 2018
Cc:
vmi...@chromium.org
ericrk@chromium.org
cblume@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 848388



Sign in to add a comment

Vulkan + SkiaRenderer crashes

Project Member Reported by cblume@chromium.org, Jun 7 2018 
In the SkiaRenderer ctor it calls output_surface_->context_provider()->ContextCapabilities();
But in a Vulkan build, the call to context_provider() returns nullptr. Dereferencing that will cause a crash.

There is a VulkanContextProvider but it isn't yet in a position where it can be used in a Vulkan build instead.

Comment 1 by cblume@chromium.org, Jun 19 2018

Cc: penghuang@chromium.org
Peng ran into this as well and provided a stack trace:

Received signal 11 SEGV_MAPERR 000000000000
#0 0x7f23d9643b5c base::debug::StackTrace::StackTrace()
#1 0x7f23d9643631 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f23ce10d0c0 <unknown>
#3 0x7f23ca970383 viz::SkiaRenderer::BeginDrawingFrame()
#4 0x7f23ca93413a viz::DirectRenderer::DrawFrame()
#5 0x7f23ca93a569 viz::Display::DrawAndSwap()
#6 0x7f23ca946e90 viz::DisplayScheduler::DrawAndSwap()
#7 0x7f23ca9464eb viz::DisplayScheduler::AttemptDrawAndSwap()
#8 0x7f23ca945da6 viz::DisplayScheduler::OnBeginFrameDeadline()
#9 0x7f23ca948d44 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz16DisplaySchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#10 0x7f23ca948ffc _ZN4base8internal22CancelableCallbackImplINS_17RepeatingCallbackIFvvEEEE16ForwardRepeatingIJEEEvDpT_
#11 0x7f23ca948d44 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz16DisplaySchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#12 0x7f23d956df40 base::debug::TaskAnnotator::RunTask()
#13 0x7f23d9599c76 base::internal::IncomingTaskQueue::RunTask()
#14 0x7f23d959da57 base::MessageLoop::RunTask()
#15 0x7f23d959de6a base::MessageLoop::DeferOrRunPendingTask()
#16 0x7f23d959e0fe base::MessageLoop::DoWork()
#17 0x7f23d95a09b9 base::MessagePumpGlib::Run()
#18 0x7f23d959d381 base::MessageLoop::Run()
#19 0x7f23d95d09b6 base::RunLoop::Run()
#20 0x556b8efa2f48 ChromeBrowserMainParts::MainMessageLoopRun()
#21 0x7f23d6a30f37 content::BrowserMainLoop::RunMainMessageLoopParts()
#22 0x7f23d6a34293 content::BrowserMainRunnerImpl::Run()
#23 0x7f23d6a2cec4 content::BrowserMain()
#24 0x7f23d75006fa content::RunBrowserProcessMain()
#25 0x7f23d75017c6 content::ContentMainRunnerImpl::Run()
#26 0x7f23d98b56bf service_manager::Main()
#27 0x7f23d74ff564 content::ContentMain()
#28 0x556b8e9c31b3 ChromeMain
#29 0x7f23cbf8e2b1 __libc_start_main
#30 0x556b8e9c302a _start

Comment 2 by cblume@chromium.org, Jun 19 2018

Cc: -penghuang@chromium.org cblume@chromium.org
Owner: penghuang@chromium.org
Peng is looking into this.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed237d078027bb322370ea62345569bbe99ad364

commit ed237d078027bb322370ea62345569bbe99ad364
Author: Peng Huang <penghuang@chromium.org>
Date: Wed Jun 20 15:21:48 2018

Make --enable-vulkan work with SkiaRenderer without SkDDL.

Bug: 848388,  850745 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6bacef1ca791ff7e00769258f3bce99ef4954b59
Reviewed-on: https://chromium-review.googlesource.com/1106614
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568848}
[modify] https://crrev.com/ed237d078027bb322370ea62345569bbe99ad364/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/ed237d078027bb322370ea62345569bbe99ad364/components/viz/service/display/skia_renderer.h

Comment 4 by penghuang@chromium.org, Jun 20 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment