VR: Removing black overlay crashes when using multiple Activities in VR. |
||||
Issue descriptionIt's entirely possible that during the DON flow, the user leaves Chrome while the black overlay is showing, then switches to a difference Chrome Activity and tries to enter VR, crashing when the black overlay isn't found. This can be done using CCT WebVR, and CTA in VR. We should just get rid of the static state and rely on the presence of the view for the Activity to track whether the black overlay is currently shown. go/crash/a220888bc26264d0 is one example of this happening on standalone where an existing (now fixed) bug makes this easier to repro.
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38456c37a027fbdb027c6481445aed936d40420e commit 38456c37a027fbdb027c6481445aed936d40420e Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jun 08 15:30:09 2018 VR: Prevent crash from double-removing black overlay. The static member variable to keep track of whether the black overlay is added can fail when we switch Activities while entering VR when the black overlay is added. In practice without other bugs this should be borderline impossible to make happen, but it crops up now and again, like in the linked bug. We should instead just track the overlay per-activity. Bug: 850741 Change-Id: I8849786972f216d7b628e2c8938579261ecd66b6 Reviewed-on: https://chromium-review.googlesource.com/1091699 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#565639} [modify] https://crrev.com/38456c37a027fbdb027c6481445aed936d40420e/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jun 8 2018
,
Jun 13 2018
,
Jun 13 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mthiesse@chromium.org
, Jun 8 2018