New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850734 link

Starred by 1 user
Status: Fixed
Owner:
█ jrbarnette@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
englab-sys-cros@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make 'reverify_unknown' use repair instead of verify

Reported by jrbarnette@chromium.org, Jun 7 2018 
Every 8 hours, we run a job that looks for idle DUTs, and schedules
a verify task to make sure that the DUTs have up-to-date status.
The source for the script is contrib/reverify_unknown.

We should change that script to schedule "repair" in place of "verify":
  * For a working DUT, repair does the same thing as verify.
  * For a broken DUT, repair will fix the DUT (or mark it definitively
    broken) faster than verify.
  * Repair tasks will also update DUT labels, meaning DUTs labels will
    stay up-to-date even on idle DUTs.

For reference, see bug 849908 for an example where this would have helped
(probably).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/337748e48fec0c70d943c9bafc467f36cf9f220c

commit 337748e48fec0c70d943c9bafc467f36cf9f220c
Author: Min Qin <qinmin@chromium.org>
Date: Thu Jun 07 23:44:49 2018

Escape json string for download tracing

The filename and URL may contain special characters that require escaping
Or otherwise the json file won't open

BUG= 850734 

Change-Id: Ic4164cd0512c0ba288b6039b2b4bd8dc4f63bb0d
Reviewed-on: https://chromium-review.googlesource.com/1091391
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565467}
[modify] https://crrev.com/337748e48fec0c70d943c9bafc467f36cf9f220c/components/download/internal/common/download_item_impl.cc

Comment 2 by johndhong@chromium.org, Jun 11 2018

Cc: englab-sys-cros@google.com
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2e9747f30574ff4e2425f9029c3056c917e6d88a

commit 2e9747f30574ff4e2425f9029c3056c917e6d88a
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Jun 16 05:16:41 2018

[autotest] Use 'repair' instead of 'verify' in 'reverify_unknown'

It turns out that, when checking the status of idle DUTs in
the `reverify_unknown` script, it's preferable to use repair tasks
in place of verify:
  * For a working DUT, performance between repair and verify is
    comparable, and repair will also update DUT labels.
  * For a broken DUT, repair is faster, because failing verify
    causes a repair task anyway.

BUG= chromium:850734 
TEST=None

Change-Id: Iab25493a0df9bde05a4a17745ccdf9c45de574f5
Reviewed-on: https://chromium-review.googlesource.com/1102557
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/2e9747f30574ff4e2425f9029c3056c917e6d88a/contrib/reverify_unknown

Comment 4 by jkop@chromium.org, Jun 21 2018

Owner: jrbarnette@chromium.org
Status: Started (was: Untriaged)
Fixed?

Comment 5 by jrbarnette@chromium.org, Jun 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment