New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

In deployment, use 'repair' instead of 'verify' at the end.

Reported by jrbarnette@chromium.org, Jun 7 2018

Issue description

At the end of any successful deployment, we schedule a verify
task to create a status history for the new DUT.  We should
schedule a repair task instead:  The repair task will make sure
labels are detected properly.  We've learned (see bug 849908) that
some label detection doesn't work when run from the deploy script.

We could also consider removing automatic label detection from
the deploy script altogether, in favor of letting the follow-on
repair task do the work.

 
Cc: englab-sys-cros@google.com
Labels: OS-Chrome
Labels: Chase-Pending
Labels: -Chase-Pending
- Only happens on new DUT deployment
- Only happens if HWTest aren't enabled on the board (since HWTest would have gone and updated the labels as a side effect).

We found out when performance team told us labels were incorrect.

So, not Chase level.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4d4fca5266c6e0f21c1293b19d237d88f27ae560

commit 4d4fca5266c6e0f21c1293b19d237d88f27ae560
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Sat Jun 16 05:16:55 2018

[autotest] Use 'repair' in place of 'verify' in deployment.

At the end of a `deploy` command, we need to schedule a special task
on the successful DUTs in order to get their status up-to-date.
This changes the special task from repair to verify to deal with
certain edge cases relating to getting labels applied correctly.

BUG= chromium:850729 
TEST=None

Change-Id: I60dc61f4f82768c53fcdbd735a79e418284907f7
Reviewed-on: https://chromium-review.googlesource.com/1102356
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/4d4fca5266c6e0f21c1293b19d237d88f27ae560/site_utils/deployment/install.py

Comment 5 by jkop@chromium.org, Jun 21 2018

Owner: jrbarnette@chromium.org
Status: Started (was: Untriaged)
Fixed?
Status: Fixed (was: Started)

Sign in to add a comment