New issue
Advanced search Search tips

Issue 850725 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 848375
issue 850728



Sign in to add a comment

Get Vulkan building on Android

Project Member Reported by cblume@chromium.org, Jun 7 2018

Issue description

Vulkan currently only builds on Linux with X11.
Get Vulkan building on Android as well.
 
Blocking: 848375
Blocking: 850728
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4264428b06a891e13315d57ffb04532d7c6d7b8

commit e4264428b06a891e13315d57ffb04532d7c6d7b8
Author: Chris Blume <cblume@chromium.org>
Date: Tue Jul 10 04:56:24 2018

Fix Vulkan build on Android

Building for Android with Vulkan support previously did not work. There
was some existing Android + Vulkan code which needed a little clean up.

This patch enables Vulkan support on Android builds.

BUG=842302, 850725 ,848375

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I077fe775c7d387e5c65c0024e88421ba47ce6280
Reviewed-on: https://chromium-review.googlesource.com/1110754
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573613}
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/android_webview/browser/parent_output_surface.cc
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/android_webview/browser/parent_output_surface.h
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/browser/BUILD.gn
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/content/renderer/android/synchronous_layer_tree_frame_sink.cc
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/BUILD.gn
[add] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/android/BUILD.gn
[rename] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/android/vulkan_implementation_android.cc
[rename] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/android/vulkan_implementation_android.h
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/features.gni
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/init/BUILD.gn
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/gpu/vulkan/init/vulkan_factory.cc
[modify] https://crrev.com/e4264428b06a891e13315d57ffb04532d7c6d7b8/skia/config/SkVulkanConfig.h

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b94ba6bf5473fb6506895620a21ca5246d3068a

commit 7b94ba6bf5473fb6506895620a21ca5246d3068a
Author: Chris Blume <cblume@chromium.org>
Date: Thu Oct 25 20:39:11 2018

Enable Vulkan on Android builds

Vulkan is currently disabled on Android builds. They were once enabled
but caused a binary size increase. We decided to disable Vulkan support
to give us time to investigate the binary size increase.

I investigated and wrote some patches that would allow us to keep the
binary size low on devices that cannot use Vulkan. However, those
patches are forced to increase complexity beyond the point we want to
support. So we're just going to re-enable Vulkan and accept the binary
size increase.

We'll loop back and double check before shipping a build with Vulkan to
double check the binary size hasn't increased further. Additionally,
we'll re-disable before each branch point until it will be used.

This patch will re-enable Vulkan on Android builds.

BUG= 850725 

Binary-Size: Increase is due to new Vulkan code paths and so cannot be avoided.
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I248425d99529ef255497f05e5cf023afa9832804
Reviewed-on: https://chromium-review.googlesource.com/c/1287043
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602840}
[modify] https://crrev.com/7b94ba6bf5473fb6506895620a21ca5246d3068a/gpu/vulkan/android/vulkan_implementation_android.cc
[modify] https://crrev.com/7b94ba6bf5473fb6506895620a21ca5246d3068a/gpu/vulkan/features.gni

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 10

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6456fc70059d28d1ccdf88e1bbe2d88bb2bce468

commit 6456fc70059d28d1ccdf88e1bbe2d88bb2bce468
Author: Andrew Grieve <agrieve@chromium.org>
Date: Mon Dec 10 18:47:43 2018

Android: Disable Vulcan for beta branch to save binary size.

Going to do this until the feature is fully ready.

This reverts commit 7b94ba6bf5473fb6506895620a21ca5246d3068a.

Bug:  850725 ,  913044 
Change-Id: I0d968803e76e29ba583220434afa14a4581617c3
Reviewed-on: https://chromium-review.googlesource.com/c/1368408
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#219}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/6456fc70059d28d1ccdf88e1bbe2d88bb2bce468/gpu/vulkan/features.gni

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6456fc70059d28d1ccdf88e1bbe2d88bb2bce468

Commit: 6456fc70059d28d1ccdf88e1bbe2d88bb2bce468
Author: agrieve@chromium.org
Commiter: agrieve@chromium.org
Date: 2018-12-10 18:47:43 +0000 UTC

Android: Disable Vulcan for beta branch to save binary size.

Going to do this until the feature is fully ready.

This reverts commit 7b94ba6bf5473fb6506895620a21ca5246d3068a.

Bug:  850725 ,  913044 
Change-Id: I0d968803e76e29ba583220434afa14a4581617c3
Reviewed-on: https://chromium-review.googlesource.com/c/1368408
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#219}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment