New issue
Advanced search Search tips

Issue 850721 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-XR



Sign in to add a comment

Add support for native controller interaction for VR tests

Project Member Reported by bsheedy@chromium.org, Jun 7 2018

Issue description

We currently have support for directly interacting with VR browser UI elements, which works well. However, it should be pretty easy to also support interacting with elements by actually pointing the controller at them and simulating button presses in order to cover a larger amount of the production code in tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5465c4209eeef7235672d710b7ca404fb65cd899

commit 5465c4209eeef7235672d710b7ca404fb65cd899
Author: bsheedy <bsheedy@chromium.org>
Date: Tue Jun 12 17:16:40 2018

VR: Support clicking on native UI elements with fake controller actions

Adds support for VR instrumentation and browser tests to click on VR
browser UI elements by simulating the controller pointing at them and
clicking the button. This fully replaces the ability to send events
directly to native UI elements during tests.

Bug:  850721 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I91c92669b2810af89a79cecc5d3d17135383b5be
Reviewed-on: https://chromium-review.googlesource.com/1091872
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566476}
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestVrShellDelegate.java
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellDialogTest.java
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NativeUiUtils.java
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/android/vr/vr_shell_gl.h
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/vr/ui.cc
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/vr/ui.h
[modify] https://crrev.com/5465c4209eeef7235672d710b7ca404fb65cd899/chrome/browser/vr/ui_test_input.h

Status: Fixed (was: Assigned)
Components: Internals>XR

Sign in to add a comment