New issue
Advanced search Search tips

Issue 850720 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Jun 2018
Cc:
waff...@chromium.org
mxnguyen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Handle error-unknownApplication in update_client

Project Member Reported by sorin@chromium.org, Jun 7 2018 
The status="error-unknownApplication" protocol response is handled as a generic UPDATE_RESPONSE_NOT_FOUND. For experiment and quality metrics reasons, we'd like to handle this more specifically.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa416553c83b7baa4b5e34f442959f7684669366

commit aa416553c83b7baa4b5e34f442959f7684669366
Author: Sorin Jianu <sorin@chromium.org>
Date: Fri Jun 08 19:46:46 2018

Handle app status errors such as error-unknownApplication in update_client.

This change introduces new error codes for these responses.

Bug:  850720 
Change-Id: I85462e964a573bf310b7b0ae5e9180e2e87eafdc
Reviewed-on: https://chromium-review.googlesource.com/1091876
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565719}
[add] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/test/data/update_client/updatecheck_reply_unknownapp.xml
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/BUILD.gn
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/protocol_parser.cc
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/protocol_parser_unittest.cc
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/update_client_errors.h
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/aa416553c83b7baa4b5e34f442959f7684669366/components/update_client/update_engine.cc

Comment 2 by sorin@chromium.org, Jun 8 2018

Status: Fixed (was: Started)
►

Sign in to add a comment