New issue
Advanced search Search tips

Issue 850719 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Downloads MD Refresh: Pause/resume/retry buttons not refreshed.

Project Member Reported by dpa...@chromium.org, Jun 7 2018

Issue description

See screenshots.

@bettes: Is the margin between the buttons OK? (It is same as before, but the buttons did not have borders before).
 
downloads_before.png
17.8 KB View Download
downloads_after.png
16.7 KB View Download
Cc: bettes@chromium.org
Actually the previous UI was explicitly setting the "Cancel" button font color to gray. But that is not in accordance with the new spec. See updated screenshot.
or_alternative.png
16.6 KB View Download
Yeah, let's 

- keep the margins 8dp between each button
- convert RESUME to a primary button (blue fill with white text)
- CANCEL is WAI (white fill with blue text) 
- PAUSE should remain as a white fill and blue text
Owner: rbpotter@chromium.org
Status: Started (was: Available)
Screenshots after proposed change at https://crrev.com/c/1101923:
DownloadsPaused.png
19.5 KB View Download
DownloadsResumed.png
19.7 KB View Download
DownloadsCancelled.png
13.5 KB View Download
DownloadsDangerous.png
14.9 KB View Download
DownloadsDangerous2.png
18.2 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4308ace4619507a2502f713746a699636885876f

commit 4308ace4619507a2502f713746a699636885876f
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Jun 18 19:24:07 2018

WebUI MD Refresh: Refresh downloads buttons

Bug:  850719 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I63fb963d90fe8b240fce80b52f8b852d5c77f311
Reviewed-on: https://chromium-review.googlesource.com/1101923
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568101}
[modify] https://crrev.com/4308ace4619507a2502f713746a699636885876f/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/4308ace4619507a2502f713746a699636885876f/chrome/browser/resources/md_downloads/item.js

Comment 8 by dpa...@chromium.org, Jun 26 2018

Status: Fixed (was: Started)

Sign in to add a comment