Downloads MD Refresh: Pause/resume/retry buttons not refreshed. |
|||
Issue descriptionSee screenshots. @bettes: Is the margin between the buttons OK? (It is same as before, but the buttons did not have borders before).
,
Jun 7 2018
Actually the previous UI was explicitly setting the "Cancel" button font color to gray. But that is not in accordance with the new spec. See updated screenshot.
,
Jun 7 2018
Yeah, let's - keep the margins 8dp between each button - convert RESUME to a primary button (blue fill with white text) - CANCEL is WAI (white fill with blue text)
,
Jun 7 2018
- PAUSE should remain as a white fill and blue text
,
Jun 14 2018
,
Jun 15 2018
Screenshots after proposed change at https://crrev.com/c/1101923:
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4308ace4619507a2502f713746a699636885876f commit 4308ace4619507a2502f713746a699636885876f Author: rbpotter <rbpotter@chromium.org> Date: Mon Jun 18 19:24:07 2018 WebUI MD Refresh: Refresh downloads buttons Bug: 850719 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I63fb963d90fe8b240fce80b52f8b852d5c77f311 Reviewed-on: https://chromium-review.googlesource.com/1101923 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568101} [modify] https://crrev.com/4308ace4619507a2502f713746a699636885876f/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/4308ace4619507a2502f713746a699636885876f/chrome/browser/resources/md_downloads/item.js
,
Jun 26 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Jun 7 2018