Issue metadata
Sign in to add a comment
|
'cros_sdk' cros-sdk download fails during chroot creation
Reported by
michael....@intel.com,
Jun 7 2018
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36 Steps to reproduce the problem: 1. cros_sdk --delete 2. rm .cache/sdks/* 3. cros_sdk --create What is the expected behavior? The latest cros-sdk tar file is downloaded. What went wrong? The cros-sdk tar file is not downloaded due to a change in RunCurl() in chromite/lib/retry_util.py. RunCurl() uses the env option to pass a single environment variable to RunCommandWithRetries(). This causes curl to run in an environment where only that single variable is present. Some of the variables needed by curl are missing, such as the proxy settings. It should be using the extra_env option so the single variable is added to the environment instead of replacing it. Did this work before? Yes Chrome version: 64.0.3282.186 Channel: n/a OS Version: Ubuntu 16.04 Flash Version: This bug was introduced by "1a3e67e cros_chrome_sdk: should not raise on goma fetch failure."
,
Jun 8 2018
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/2b43d1533a61651629ffeaa61057b92295466d13 commit 2b43d1533a61651629ffeaa61057b92295466d13 Author: Mike Mason <michael.w.mason@intel.com> Date: Fri Jun 08 06:33:47 2018 retry_util: fix environment variable reset in RunCommandWithRetries call In lib/retry_util.py, a call to RunCommandWithRetries() in RunCurl() sets the env option instead of the extra_env option. This wipes out the environment variables needed by curl, including the proxy settings, causing the cros-sdk tar file download to fail during 'cros_sdk --create'. The script should use extra_env instead of env so the given variables are added to the environment instead of replacing it. BUG= chromium:850717 TEST=cros_sdk --create Change-Id: I6232f878ffde1faf24b70c433e1b7dd832ee351d Signed-off-by: Mike Mason <michael.w.mason@intel.com> Reviewed-on: https://chromium-review.googlesource.com/1091286 Commit-Ready: Michael W Mason <michael.w.mason@intel.com> Tested-by: Neha Pandey <nehuniversal@gmail.com> Tested-by: Kevin L Derossett <kevin.l.derossett@intel.com> Reviewed-by: Kevin L Derossett <kevin.l.derossett@intel.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2b43d1533a61651629ffeaa61057b92295466d13/lib/retry_util.py
,
Jun 14 2018
@Mike Mason: Requesting you to close this issue if there is no further work to be done here. Adding label "TE-NeedsTriageHelp". Thanks!
,
Jun 29 2018
@Vamshi Kommuri: This is ready to be closed, but as a non-Googler, I don't have permission to close it. I don't see anything in the UI that would allow me to do that. Someone with permission will have to close it.
,
Jul 2
As per the comment#3 fix has been landed and from the confirmation given in comment#5 marking it as Fixed. Thanks! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by michael....@intel.com
, Jun 7 2018