Issue metadata
Sign in to add a comment
|
The Text-to-Speech settings page breaks when the Android voice is present |
||||||||||||||||||||||||
Issue descriptionThe TTS "android" voice has an empty string for language and extension, causing a JS assertion error in the TTS settings page. Maybe the TTS voices shown shouldn't include those without any language? Or, we could have a drop-down specifically for voices with no language, but that sounds more complex.
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7 commit 2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7 Author: Katie D <katie@chromium.org> Date: Tue Jun 12 21:39:22 2018 Handle system (ARC++) text-to-speech voice in TTS settings page. The ARC++ voice is built-in, so it does not have an extension ID. It also lacks a default language. Handle voices without adefault language in the TTS settings page by adding a drop-down to select a default voice when no particular language is specified. Handle voices without extension ID by not making an empty extension ID in a voice something that keeps a match from occuring in tts_controller_impl::VoiceMatches. Bug: 850702 Change-Id: Ia06c485ee3e90b7bbb0c13bcae0a30d234e0abd6 Reviewed-on: https://chromium-review.googlesource.com/1092071 Reviewed-by: David Tseng <dtseng@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#566581} [modify] https://crrev.com/2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7/chrome/app/chromeos_strings.grdp [add] https://crrev.com/2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7/chrome/app/chromeos_strings_grdp/IDS_TEXT_TO_SPEECH_SETTINGS_NO_LANGUAGE.png.sha1 [modify] https://crrev.com/2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7/chrome/browser/speech/tts_controller_impl.cc [modify] https://crrev.com/2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7/chrome/browser/speech/tts_controller_unittest.cc [modify] https://crrev.com/2ad8e3dbd6864896f1087e4e6ae1c7054bf242f7/chrome/browser/ui/webui/settings/tts_handler.cc
,
Jun 13 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2520b39fe638fe236dbbbaf0a8181d7a5eebc47c commit 2520b39fe638fe236dbbbaf0a8181d7a5eebc47c Author: Katie D <katie@chromium.org> Date: Thu Jun 14 16:49:13 2018 Clean up tts_handler per comments on another change. This removes a TODO for unnecessary work, and uses FireWebUIListener to send data to the frontend JS. For comments, see https://chromium-review.googlesource.com/c/chromium/src/+/1092071/2/chrome/browser/ui/webui/settings/tts_handler.cc. Bug: 850702 Change-Id: I3891d8d73af3e8f2f63a823b917910e2ee24dfdc Reviewed-on: https://chromium-review.googlesource.com/1099191 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#567306} [modify] https://crrev.com/2520b39fe638fe236dbbbaf0a8181d7a5eebc47c/chrome/browser/ui/webui/settings/tts_handler.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by katie@chromium.org
, Jun 8 2018Status: Started (was: Assigned)