New issue
Advanced search Search tips

Issue 850689 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: support set-cookie in the network interception w/ network service

Project Member Reported by pfeldman@chromium.org, Jun 7 2018

Issue description

http/tests/inspector-protocol/network/interception-set-cookie.js needs to pass.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1381120f746b25c52b531e8763bc46a1b31513e6

commit 1381120f746b25c52b531e8763bc46a1b31513e6
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Oct 18 21:10:10 2018

DevTools: support cookies in URLLoader-based network interceptor

Bug:  850689 , 838291 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I4017d89466de05936b697385436e6519934a9f19
Reviewed-on: https://chromium-review.googlesource.com/c/1282443
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600907}
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/devtools_url_loader_interceptor.cc
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-patterns.js
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/url-fragment-expected.txt
[modify] https://crrev.com/1381120f746b25c52b531e8763bc46a1b31513e6/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/url-fragment.js

Status: Fixed (was: Assigned)

Sign in to add a comment