With P2P sharing flag disabled, sharing from DH to Xender will show error |
||||||
Issue descriptionWith P2P sharing flag disabled, sharing from DH to Xender will show error of 'sorry, the resource cannot resolve'. Expectation: share URL for it. Potential issue: in DownloadUtils.createShareIntent, the MIME type is not correct when sharing in the aforementioned scenario.
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3e88ec9af112514b329e38bb0a7afa58dd22fa9 commit f3e88ec9af112514b329e38bb0a7afa58dd22fa9 Author: Yafei Duan <romax@chromium.org> Date: Mon Jun 11 18:31:52 2018 [Offline Pages] Use text/plain when sharing URLs. If P2P sharing flag is not enabled, it's expected to share the page by URL. However there was an error in createShareIntent that the MIME type will be parsed as "text/html", leading to sharing error. Also this change included a fix so that EXTRA_STREAM will only be added if there are one or more URIs to share. Bug: 850686 Change-Id: Id82aa39a5b2dc2f469c73f85a8298435b05e6417 Reviewed-on: https://chromium-review.googlesource.com/1093391 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#566070} [modify] https://crrev.com/f3e88ec9af112514b329e38bb0a7afa58dd22fa9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
,
Jun 11 2018
,
Jun 11 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 12 2018
Tested on TOT local build and works fine. Will test on canary channel once it's available.
,
Jun 12 2018
Please verify in canary
,
Jun 12 2018
Just verified in 69.0.3456.0 that the fix works as expected.
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bb21dcbdc4913a166116db88a5ad6d7a99f9bb4 commit 3bb21dcbdc4913a166116db88a5ad6d7a99f9bb4 Author: Yafei Duan <romax@chromium.org> Date: Wed Jun 13 19:52:54 2018 [Offline Pages] Use text/plain when sharing URLs. If P2P sharing flag is not enabled, it's expected to share the page by URL. However there was an error in createShareIntent that the MIME type will be parsed as "text/html", leading to sharing error. Also this change included a fix so that EXTRA_STREAM will only be added if there are one or more URIs to share. Bug: 850686 Change-Id: Id82aa39a5b2dc2f469c73f85a8298435b05e6417 Reviewed-on: https://chromium-review.googlesource.com/1093391 Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#566070}(cherry picked from commit f3e88ec9af112514b329e38bb0a7afa58dd22fa9) Reviewed-on: https://chromium-review.googlesource.com/1099616 Reviewed-by: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#341} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/3bb21dcbdc4913a166116db88a5ad6d7a99f9bb4/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
,
Jun 13 2018
Merged into M68 branch, marking the issue as fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by romax@chromium.org
, Jun 7 2018