New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850674 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR


Sign in to add a comment

☂ VR Dynamic Feature Module (DFM)

Project Member Reported by cjgrant@chromium.org, Jun 7 2018

Issue description

This umbrella bug represents work to move code (both native and Java) into an Android dynamic feature module, so as to minimize binary size impact on non-VR users.

It's too early to break out implementation bugs, but I made this to attach pre-existing bugs to that are affected by componentization.


 
Blockedon: 664306

Comment 2 by tiborg@chromium.org, Jun 19 2018

Blockedon: 854358
Labels: -M-70 Target-70
Blockedon: 862639
Summary: ☂ VR DFM (was: ☂ Code Componentization)
Starting to add implementation bugs for the creation and Java split work.
Labels: -Proj-VR
Summary: ☂ VR Dynamic Feature Module (DFM) (was: ☂ VR DFM)
Components: -UI>Browser>VR Internals>XR>VR
Blockedon: 862681
Blockedon: 862689
Blockedon: 862690
Blockedon: 862694
Blockedon: 862696
Blockedon: 862702
Blockedon: 862705
Blockedon: 862706
Blocking: 862707
Blockedon: 862719
Blockedon: 863064
Blocking: -862707
Blockedon: 838013
Blockedon: -838013
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d25962853b4898b6e6e163a222eea863d3ded4b

commit 3d25962853b4898b6e6e163a222eea863d3ded4b
Author: Ian Vollick <vollick@chromium.org>
Date: Mon Jul 30 20:07:14 2018

[vr] Split vr_ui and vr_base out of vr_common

This is derived from cjgrant@'s prototype and design (see
crrev.com/c/1134053)

It breaks a vr_ui target out of vr_common. The vr_base target
exists to satisfy the dependencies of vr_ui since it cannot
depend on vr_common.

Bug: 850674
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iae0e11701213fca70e744b93228836a192e38065
Reviewed-on: https://chromium-review.googlesource.com/1154194
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579140}
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/assets_loader.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/input_event.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/metrics/metrics_helper.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/metrics/session_metrics_helper.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/model/assets.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/model/controller_model.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/model/omnibox_suggestions.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/model/text_input_info.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/model/toolbar_state.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/platform_ui_input_delegate.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/pose_util.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/testapp/BUILD.gn
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/text_edit_action.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/ui.h
[add] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/ui_factory.cc
[add] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/ui_factory.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/ui_initial_state.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/ui_interface.h
[add] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/vr_base_export.h
[modify] https://crrev.com/3d25962853b4898b6e6e163a222eea863d3ded4b/chrome/browser/vr/vr_geometry_util.h

Labels: -Target-70 Target-71
Bumping to M71 as discussed.
Blockedon: 874564
Blockedon: 875059
Blockedon: 695937
VR magic window needs to not depend on the GVR path ( issue 695937 ) so that we don't need to worry about whether the app is installed, especially since no user gesture is required.

We should probably also have a blocking bug for implementing the install flow for the VR presentation (Cardboard/Daydream) path.
Blocking: 883015
Blockedon: 837965
Cc: -tiborg@chromium.org
Labels: -Target-71 Target-72
Owner: tiborg@chromium.org
Status: Started (was: Available)
Blockedon: 901920
Blockedon: 914494
Labels: VR-DFM
Labels: -Target-72 Target-73
Blockedon: 920746
Blockedon: 921660

Comment 35 by tiborg@chromium.org, Jan 18 (4 days ago)

Blockedon: 923539

Comment 36 by tiborg@chromium.org, Jan 18 (4 days ago)

Blockedon: 923541

Comment 37 by tiborg@chromium.org, Jan 18 (4 days ago)

Blockedon: 923545

Sign in to add a comment