New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850671 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Monitor pipeline completion

Project Member Reported by lijeffrey@chromium.org, Jun 7 2018

Issue description

Pipeline triggering and completion should be monitored separately in order to track real time error rates
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/902c3c2a8a12331248d8d49e7515e5b7d6bd5a1e

commit 902c3c2a8a12331248d8d49e7515e5b7d6bd5a1e
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Jun 08 20:31:07 2018

[Findit] Flake Analyzer - Adding monitoring for pipeline completion

In order to monitor real-time error rates, completion events and error
events need to be incremented near-simultaneously. Currently total
triggered pipelines are counted at triggered time, not completion time
which throws off the metric timings. e.g. If many analyses are triggered
at once but then relatively few analyses later, then after several hours
those analyses fail, the graph of triggered vs errors is actually incorrect
due to the time offset.

This change introduces a monitoring event when the main pipeline is
finalized also to trigger a completion event which should be used for
error rate metrics.

Bug:  850671 
Change-Id: I60b1dcca523e15a1f091730eab670e255f38ed8e
Reviewed-on: https://chromium-review.googlesource.com/1091491
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/902c3c2a8a12331248d8d49e7515e5b7d6bd5a1e/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/902c3c2a8a12331248d8d49e7515e5b7d6bd5a1e/appengine/findit/common/monitoring.py

Status: Fixed (was: Assigned)

Sign in to add a comment