New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850652 link

Starred by 6 users
Status: Started
Owner:
jbudorick@chromium.org
Cc:
torne@chromium.org
█ cma...@chromium.org
ctzsm@chromium.org
ntfschr@chromium.org
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocking:
issue 844173



Sign in to add a comment

Upgrade chromium to the P SDK

Project Member Reported by jbudorick@chromium.org, Jun 7 2018 
in particular:
 - platforms;android-28
 - build-tools;android-28.0.0
 - platform-tools 28.0.0

blocking bug tl;dr: need to fix how we build against the now-legacy testing libs (https://developer.android.com/preview/features/legacy-testing-libs)

Comment 1 by wnwen@chromium.org, Jun 14 2018

Cc: wnwen@chromium.org ctzsm@chromium.org
IIRC Shimi already did quite a bit of work on this front in issue 807251

Comment 2 by jbudorick@chromium.org, Jun 14 2018 

yep, and it needs updating.

Comment 3 by ntfschr@chromium.org, Jun 16 2018

Cc: ntfschr@chromium.org
jbudorick@ are we taking any extra steps to make sure we don't break WebView (I'm thinking of  issue 789754 )?

Comment 4 by jbudorick@chromium.org, Jun 16 2018 

#3: hrm, good question. I think the circumstances under which that occurred would still occur today due to our continued reliance on public_android_sdk.

Comment 5 by twelling...@chromium.org, Jun 18 2018

Blockedon: 844173

Comment 6 by jbudorick@chromium.org, Jun 21 2018

Status: Started (was: Assigned)
Discussed with the webview folks offline. Also planning to update //third_party/android_system_sdk.

Working on this locally on top of https://chromium-review.googlesource.com/c/chromium/src/+/1102915 and https://chromium-review.googlesource.com/c/chromium/src/+/1106483. Still have a few kinks to work out, particularly re aapt2 + system_webview_apk.

Comment 7 by jbudorick@chromium.org, Jun 21 2018

Blockedon: -844173
Blocking: 844173

Comment 8 by torne@chromium.org, Jun 21 2018 

Thanks John; feel free to send code reviews/questions my way about any of the webview stuff at any point.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0330351096b9e2a515cd438eb6c9b1326316327

commit d0330351096b9e2a515cd438eb6c9b1326316327
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jun 22 15:04:09 2018

Use an integer for android_sdk_version.

Bug: 850652
Change-Id: I5493037339fb7675aa942893c5e9654c653b071a
Reviewed-on: https://chromium-review.googlesource.com/1106483
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569632}
[modify] https://crrev.com/d0330351096b9e2a515cd438eb6c9b1326316327/build/config/android/config.gni
[modify] https://crrev.com/d0330351096b9e2a515cd438eb6c9b1326316327/tools/android/sdk_updater/update_sdk.py
[add] https://crrev.com/d0330351096b9e2a515cd438eb6c9b1326316327/tools/android/sdk_updater/update_sdk_tests.py
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 24 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/8fdfe11826494d272ddc9d53cac2d1335daf89f0

commit 8fdfe11826494d272ddc9d53cac2d1335daf89f0
Author: John Budorick <jbudorick@google.com>
Date: Sun Jun 24 17:01:04 2018
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/130499e25286f4d56acafa252fee09f3cc595c49

commit 130499e25286f4d56acafa252fee09f3cc595c49
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Jun 25 20:17:43 2018

Update to platforms;android-28.

Bug: 850652
Change-Id: I67407333b0dc99415db0d4f8d489faf2eac1d489
Reviewed-on: https://chromium-review.googlesource.com/1112707
Reviewed-by: agrieve <agrieve@chromium.org>

[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc410-ml/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/stat_sys_signal_evdo_0.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-am/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/layout-watch/input_method_extract_view.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/fonts/NotoSansLimbu-Regular.ttf
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ic_menu_start_conversation.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/fonts/NotoSansTaiTham-Regular.ttf
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc200-lv/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/divider_vertical_dark.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ic_menu_crop.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ab_transparent_dark_holo.9.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc280-fr-rCA/strings.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc170-da/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/list_selected_holo_dark.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ic_lock_idle_lock.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/dropdown_disabled_focused_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/raw-tr/nodomain.html
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc250-uz/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/pointer_nodrop.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/list_selector_pressed_holo_dark.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/layout/date_picker_header_material.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc950-en-rGB/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/spinner_ab_disabled_holo_light.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/ab_share_pack_mtrl_alpha.9.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc313-mnc100-ja/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/skins/WXGA800-7in/select.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/layout-notround-watch/alert_dialog_title_material.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/btn_plus_selected.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/title_bar.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/stat_sys_battery_15.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/btn_dropdown_disabled_focused.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc200-zh-rTW/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc950-lv/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-ca-rES/donottranslate-maps.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/divider_vertical_bright_opaque.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/sym_action_chat.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc030-si/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/ic_media_route_connected_light_19_mtrl.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc200-be/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/spinner_black_16.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc170-km/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/layout/global_actions_item.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/pointer_zoom_out_large_icon.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/slice_remote_input_bg.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/btn_star_on_normal_holo_dark.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc313-mnc100-ur/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/menu_background.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/dialog_middle_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-tr/donottranslate-cldr.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc302-mnc370-hi/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc302-mnc370-kk/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc210-ja/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc312-mnc670-tl/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc280-en-rIN/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/jog_tab_bar_right_end_confirm_gray.9.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc312-mnc670-ka/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/stat_sys_signal_evdo_2.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ab_solid_dark_holo.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc660-az/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/divider_vertical_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ic_menu_recent_history.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/skins/WQVGA400/select.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc001-mnc01-be/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ic_user_secure.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/panel_bg_holo_dark.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/ic_notification_block.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/color/primary_text_material_light.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/btn_keyboard_key_trans_selected.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ic_media_route_connecting_dark_22_mtrl.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/textfield_search_empty.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/progressbar_indeterminate2.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/list_section_divider_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/color/primary_text_leanback_formwizard_dark.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ic_btn_search_go.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc310-tr/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/anim/dialog_exit.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/textfield_focused_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/pointer_zoom_out_large.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc240-th/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc380-hi/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ic_media_route_connecting_light_07_mtrl.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc302-mnc720-kk/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/textfield_bg_disabled_holo_dark.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/ic_media_route_connecting_dark_25_mtrl.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc030-zh-rCN/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc240-af/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/btn_search_dialog_default.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/stat_sys_download_anim4.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/btn_check_on_disabled_holo_light.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/color/background_cache_hint_selector_material_light.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/emo_im_laughing.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/ic_media_route_connected_light_24_mtrl.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/btn_rating_star_off_normal_holo_dark.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/btn_default_small_selected.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/status_bar_header_background.9.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc001-mnc01-ml/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc280-hy/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/anim/swipe_window_enter.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/btn_default_transparent.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc313-mnc100-en-rAU/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/stat_sys_download_anim3.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc560-mn/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc380-de/strings.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/fonts/NotoSerif-BoldItalic.ttf
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc313-mnc100-lo/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/stat_sys_battery_charge_anim85.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc030-af/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/ab_transparent_dark_holo.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/quickcontact_badge_overlay_focused_dark.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/numberpicker_up_selected.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/anim/ft_avd_toarrow_rectangle_5_animation.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ic_media_route_connected_light_25_mtrl.png
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc280-fa/strings.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc311-mnc180-eu/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc950-b+sr+Latn/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/stat_sys_r_signal_2_cdma.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ab_share_pack_holo_dark.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ic_media_route_connected_dark_24_mtrl.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/ic_jog_dial_vibrate_on.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/perm_group_phone_calls.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/spinner_focused_holo_dark_am.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxxhdpi/ic_media_route_connected_light_28_mtrl.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-vi-watch/strings.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc311-mnc180-iw/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc560-gu/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/btn_check_off_holo.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc660-hy/strings.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc030-cs/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/anim/push_down_in_no_alpha.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/fonts/NotoSansMalayalamUI-Regular.ttf
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/animator/leanback_setup_fragment_close_exit.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-ro/donottranslate-cldr.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/btn_toggle_on_pressed_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc490-fi/strings.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc560-ka/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/skins/WXGA720/arrow_left.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/btn_group_disabled_holo_light.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/ft_avd_toarrow.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/ic_perm_group_app_info.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxxhdpi/ic_star_half_black_16dp.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/ic_menu_sort_by_size.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc380-el/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/btn_toggle_bg.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/btn_check_off_focused_holo_light.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/stat_sys_download_anim2.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/textfield_search_empty_default.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/rate_star_small_half_holo_light.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/list_selector_background_focused.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/layout/am_compat_mode_dialog.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/layout/text_edit_suggestions_window.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-hdpi/ic_menu_always_landscape_portrait.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/btn_star_on_pressed_holo_dark.png
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc030-es-rUS/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values/styles.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/fonts/NotoSansEthiopic-Bold.ttf
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable/time_picker_editable_background.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xxhdpi/ic_menu_allfriends.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-xhdpi/btn_switch_to_off_mtrl_00002.9.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc380-pt/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc380-es-rUS/strings.xml
[add] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc312-mnc670-sr/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-ldpi/ic_menu_mylocation.png
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc800/config.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc200-es-rUS/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc800-cs/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/raw-pl/nodomain.html
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/values-mcc310-mnc200-ja/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/interpolator/linear_out_slow_in.xml
[delete] https://crrev.com/3545ab5b9883087a54cb9e5337c32617cb2a443d/sdk/platforms/android-27/data/res/values-mcc310-mnc560-ar/strings.xml
[rename] https://crrev.com/130499e25286f4d56acafa252fee09f3cc595c49/sdk/platforms/android-28/data/res/drawable-mdpi/ic_menu_cut_holo_light.png
[rename] https

Comment 12 by jbudorick@chromium.org, Jun 26 2018 

Roll CL is ready to go in https://chromium-review.googlesource.com/c/chromium/src/+/1112729 % approval re //third_party/android_system_sdk.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8

commit 2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Jun 27 02:33:57 2018

Upgrade chromium to the Android P DP3 SDK.

This only includes the upgrade to platforms;android-28. build-tools and
platform-tools upgrades to follow.

Requires http://crrev.com/c/1112707.
There will be a matching internal CL.

Bug: 850652
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I99c50246f326ffa0b1190d7473b5343613804573
Reviewed-on: https://chromium-review.googlesource.com/1112729
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570638}
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/DEPS
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/apk/java/AndroidManifest.xml
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/glue/BUILD.gn
[add] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/glue/java/src/com/android/webview/chromium/TracingControllerAdapter.java
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/glue/java/src/com/android/webview/chromium/WebViewDelegateFactory.java
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/android_webview/tools/automated_ui_tests/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/base/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/android/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/android/gyp/compile_resources.py
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/android/gyp/util/resource_utils.py
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/config/android/config.gni
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/config/android/internal_rules.gni
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/config/android/rules.gni
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/config/android/sdk.gni
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/build/secondary/third_party/android_tools/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/chrome/android/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/chrome/android/java/res/values-v27/styles.xml
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/components/cronet/android/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/components/invalidation/impl/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/java/src/org/chromium/content/browser/ContentClassFactory.java
[add] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/java/src/org/chromium/content/browser/selection/AdditionalMenuItemProviderImpl.java
[add] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/java/src/org/chromium/content/browser/selection/MagnifierAnimator.java
[add] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/java/src/org/chromium/content/browser/selection/MagnifierWrapper.java
[add] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/java/src/org/chromium/content/browser/selection/MagnifierWrapperImpl.java
[add] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/junit/src/org/chromium/content/browser/selection/MagnifierAnimatorTest.java
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/content/public/android/junit/src/org/chromium/content/browser/selection/SelectionPopupControllerTest.java
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/device/BUILD.gn
[modify] https://crrev.com/2d7e42f08f486ca3d5e28176f5ea0e3fb5bde0e8/testing/android/reporter/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/6ce859f8bae5d8a6fdf2a3d138401cfd3c758bdb

commit 6ce859f8bae5d8a6fdf2a3d138401cfd3c758bdb
Author: John Budorick <jbudorick@google.com>
Date: Wed Jun 27 05:37:23 2018
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bea9ba774c231d2753408d05988517591c3d0fa1

commit bea9ba774c231d2753408d05988517591c3d0fa1
Author: Tao Bai <michaelbai@chromium.org>
Date: Wed Jun 27 23:51:23 2018

Add missing WebViewChromiumFactoryProviderForP

Bug: 850652
Change-Id: Ib170181ac3e0d52a0494de2b2ce01662e975e4af
Reviewed-on: https://chromium-review.googlesource.com/1117652
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570939}
[modify] https://crrev.com/bea9ba774c231d2753408d05988517591c3d0fa1/android_webview/glue/BUILD.gn
[add] https://crrev.com/bea9ba774c231d2753408d05988517591c3d0fa1/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProviderForP.java

Comment 16 by jbudorick@chromium.org, Jul 3

Blockedon: -841695

Comment 17 by cma...@chromium.org, Jul 9 

Hey John, is this now completed?

Comment 18 by jbudorick@chromium.org, Jul 9 

no, still need to do build-tools and platform-tools. folks can land code that uses the P SDK, though, since platforms has landed.
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58f43363ce344677d24194cc97344ed375b11bd3

commit 58f43363ce344677d24194cc97344ed375b11bd3
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Mon Jul 16 21:56:40 2018

Remove ClassRegister part 1.

We still need to do 3-way patch to avoid break downstream. We remove
the usage of ClassRegister first then remove the declaration in part 2.

part 2: http://crrev/c/1137105
Downstream CL: http://crrev/i/651721

Bug: 850652
Change-Id: I9148fdd7dfcb61e4f804b23e817e5bbd3dabc75d
Reviewed-on: https://chromium-review.googlesource.com/1138815
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575440}
[modify] https://crrev.com/58f43363ce344677d24194cc97344ed375b11bd3/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2b5dd70426417bec49bf65796458e95e63857ae7

commit 2b5dd70426417bec49bf65796458e95e63857ae7
Author: Shimi Zhang <ctzsm@google.com>
Date: Tue Jul 17 18:52:07 2018

Comment 22 by ntfschr@chromium.org, Jul 18 

ctzsm@ I'm hitting an issue related to ClassRegister. Is my checkout misconfigured, or do others have the same bug?

$ # try to build any of "chrome_apk", "chrome_modern_apk", or "monochrome_apk"
...
Warning: org.chromium.chrome.browser.ClassRegister: can't find referenced class org.chromium.chrome.browser.ClassRegisterImpl
Warning: org.chromium.chrome.browser.ClassRegister: can't find referenced class org.chromium.chrome.browser.ClassRegisterImpl
Warning: org.chromium.chrome.browser.ClassRegister: can't find referenced class org.chromium.chrome.browser.ClassRegisterImpl
Warning: there were 3 unresolved references to classes or interfaces.

Comment 23 by ctzsm@chromium.org, Jul 18 

ntfschr@, yeah we hit that proguard warning yesterday, it should be fine now. CL in #c21 resolve this issue, it wasn't propagated to downstream until last night. Sorry for the inconvenience.
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7259fe14ee467fb7286ad6c65589fefaabe60f2e

commit 7259fe14ee467fb7286ad6c65589fefaabe60f2e
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Tue Oct 23 19:31:33 2018

[Android] Inline isAtLeastP and targetAtLeastP

P SDK is rolled to public, we can inline these two methods now.

Bug: 850652
Change-Id: Ib2828752bdda8be5ba4f1e1d5fc84c7fd315db79
Reviewed-on: https://chromium-review.googlesource.com/c/1289434
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602055}
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/android_webview/glue/java/src/com/android/webview/chromium/FontPreloadingWorkaround.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/android_webview/java/src/org/chromium/android_webview/AwSettings.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/base/android/build_info.cc
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/base/android/build_info.h
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/base/android/java/src/org/chromium/base/BuildInfo.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/chrome/android/java/src/org/chromium/chrome/browser/InsetObserverView.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTest.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/content/child/runtime_features.cc
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java
[modify] https://crrev.com/7259fe14ee467fb7286ad6c65589fefaabe60f2e/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java

Comment 25 by tsniatow...@vewd.com, Dec 6 

jbudorick@, will platform-tools be upgraded to 28 too? We just noticed on our end that some tools get confused by the versions being out of sync (namely, in a gradle-based build some linters silently don't run)

Comment 26 by jbudorick@chromium.org, Dec 6 

#25: yeah, someone else asked about that recently as well; going to try to upgrade over the next few weeks, time permitting.
Project Member

Comment 27 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/android_tools/+/e958d6ea74442d4e0849bb8a018d215a0e78981d

commit e958d6ea74442d4e0849bb8a018d215a0e78981d
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Dec 12 21:42:15 2018

Update sdk/platform-tools to version 28.0.1.

Bug: 850652
Change-Id: I5facc0eae289afcb26ac94ad3513dd0612c52dab
Reviewed-on: https://chromium-review.googlesource.com/c/1372579
Reviewed-by: Peter Wen <wnwen@chromium.org>

[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/docs/apidoc/epydoc.js
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_utils/py_utils/tempfile_ext.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/py_vulcanize/html_module_unittest.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-singlequote-font.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/escape_03.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-dbquote-font.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_utils/py_utils/test_data/discoverable_classes/another_discover_dummyclass.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-base64-doublequotes.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/host_utils.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/escape_00.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/docs/apidoc/help.html
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/decimals.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_trace_event/py_trace_event/trace_event_impl/log.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/py_vulcanize/js_utils.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/escape_06.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/opacity-filter.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/zeros.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/py_vulcanize/html_generation_controller.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/sdk/adb_wrapper.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/first_00.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/profile_chrome/chrome_startup_tracing_agent.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/escape_05.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/comment_02.css
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/sqlite3
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-base64-noquotes.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/url_03.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/docs/PROVIDES
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/parallelizer_test.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-realdata-doublequotes.css
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/docs/persistent_device_list.md
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-realdata-yuiapp.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/url_03.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/cmd_helper_test.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/border-none.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-nonbase64-singlequotes.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/decimals.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/py_vulcanize/fake_fs_unittest.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/setup.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/atrace_helper/jni/libmemtrack_wrapper.h
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/decimals.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/url_08.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/bench/cssmin.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/bug2527998.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/apk_helper_test.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/UPSTREAM_REVISION
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/video_recorder.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-base64-eof.css
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/sload_f2fs
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/device_recovery.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-nonbase64-singlequotes.css
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/systrace/output_generator.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/docs/CHANGES
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/py_vulcanize/resource_loader.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/systrace/tracing_agents/atrace_agent.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/run_tests.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/string-in-comment.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/atgroup_09.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/docs/apidoc/epydoc.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/py_vulcanize/strip_js_comments_unittest.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/atrace_helper/jni/file_utils.cc
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/bench/jsmin.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/docs/PROVIDES
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/logging_common.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/apk_helper.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/atgroup_11.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/bench/main.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-nonbase64-doublequotes.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/font-face.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/atgroup_09.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/comment_01.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/systrace/tracing_agents/battor_trace_agent.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/escape_03.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/atgroup_02.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/docs/apidoc/crarr.png
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/url_05.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/atrace_helper/jni/libmemtrack_wrapper.cc
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/comment_02.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/color-simple.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/media-multi.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/flash_device.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/color.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/bug2527998.out
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/atrace_helper/jni/process_memory_stats.h
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/atgroup_07.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-realdata-noquotes.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/system_app.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-noquote-multiline-font.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/bench/wikipedia.min.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-realdata-singlequotes.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/dependency_manager/dependency_manager/manager.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/escape_00.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/comment.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/bench/jquery-1.7.1.js
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/pseudo.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/escape_03.out
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/cpufreq.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/usb_hubs.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/dataurl-realdata-yuiapp.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/comment_03.css
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/sdk/version_codes.py
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/adb
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/color-simple.css.min
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/keyboard.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/background-position.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/media-multi.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/bench/DateTimeShortcuts.js
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/box-model-hack.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/docs/SUMMARY
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/url_03.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/star-underscore-hacks.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/find_usb_devices.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/zeros.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/url_00.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/bench/jsmin_2_0_9.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/preserve-strings.css.min
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_utils/py_utils/__init__.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/url_04.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-realdata-doublequotes.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/pseudo.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_utils/py_utils/atexit_with_log.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-dbquote-font.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/first_00.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/first_01.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/hprof-conv
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/bench/__init__.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/preserve-strings.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/android/tools/system_app_test.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/comment.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/docs/apidoc/api-objects.txt
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/systrace/systrace_trace_viewer.html
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/atgroup_04.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/url_05.out.b
[modify] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/devil/devil/utils/timeout_retry.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/docs/apidoc/crarr.png
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/url_08.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/charset-media.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/atgroup_08.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/url_00.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_utils/py_utils/camel_case_unittest.py
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/dataurl-nonbase64-noquotes.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/comment_02.out
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/out/comment.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/star-underscore-hacks.css.min
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/out/escape_01.out.b
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rjsmin/MANIFEST
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/systrace/atrace_helper/jni/time_utils.h
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/main/comment_04.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/systrace/catapult/common/py_vulcanize/third_party/rcssmin/tests/yui/bug2527974.css
[add] https://crrev.com/e958d6ea74442d4e0849bb8a018d215a0e78981d/sdk/platform-tools/s
Project Member

Comment 28 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119cc81899d5613ef628a40bb35b6b16176d7bc0

commit 119cc81899d5613ef628a40bb35b6b16176d7bc0
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Dec 13 14:51:57 2018

Roll android_tools to pick up platform-tools 28.0.1.

Bug: 850652
Change-Id: I95436baa95af68546841a9bb978f8dbb0f233345
Reviewed-on: https://chromium-review.googlesource.com/c/1374358
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616313}
[modify] https://crrev.com/119cc81899d5613ef628a40bb35b6b16176d7bc0/DEPS
[modify] https://crrev.com/119cc81899d5613ef628a40bb35b6b16176d7bc0/third_party/android_sdk/cipd_platform-tools.yaml

Comment 29 by tsniatow...@vewd.com, Dec 17 

cool, thanks. is a build-tools roll also planned?

Comment 30 by jbudorick@chromium.org, Dec 17 

#29: yeah, will try to get to it this week.
►

Sign in to add a comment