New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850645 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Jul 26
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

Flake analysis results are not indexed

Project Member Reported by st...@chromium.org, Jun 7 2018 
Page URL: https://findit-for-me.appspot.com/waterfall/list-flakes?result_status=30

 Description:

For all flake analyses in the new pipelines, results are not indexed properly
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4b8004eed60eb4c2474d222fd25230c341d79277

commit 4b8004eed60eb4c2474d222fd25230c341d79277
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Jun 14 20:55:28 2018

[Findit] Flake Analyzer - Set result_status when pipeline completes

Set result status after Flake Analyzer has come to a conclusion successfully.
Note these values should not be set in OnFinalized, as that is called when
pipelines abort which may not be correct (e.g. setting NOT_FOUND_UNTRIAGED
for an analysis that ran into an exception early on would be incorrect for
determining whether the conclusion is correct which is what result_status
represents).

Bug:  850645 
Change-Id: If0100301af5c8fa6cc68956ff0b059498fa22838
Reviewed-on: https://chromium-review.googlesource.com/1097795
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/4b8004eed60eb4c2474d222fd25230c341d79277/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/4b8004eed60eb4c2474d222fd25230c341d79277/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py

Comment 2 by lijeffrey@chromium.org, Jul 26

Status: Verified (was: Assigned)

Comment 3 by lijeffrey@chromium.org, Sep 10 

 Issue 832722  has been merged into this issue.
►

Sign in to add a comment