Filter toggles behave funny in hosted mode
Reported by
ing...@cloudflare.com,
Jun 7 2018
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0 Steps to reproduce the problem: 1. Set up devtools in hosted mode. 2. Try to click any item on any filter bar. What is the expected behavior? Current item is selected, everything else is cleared. What went wrong? Current item becomes enabled, but also all of the other items change their state to the opposite. See the attached screencast for example. Did this work before? N/A Chrome version: 69.0.3451.0 Channel: canary OS Version: OS X 10.13 Flash Version: I have a fix ready, just thought I'd create a bug with a screencast for the reference first.
,
Jun 11 2018
,
Jun 11 2018
FWIW the mentioned fix in review is here: https://chromium-review.googlesource.com/#/c/1091312/
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/447883683661cf3fc7c1296dfa9f379510948ada commit 447883683661cf3fc7c1296dfa9f379510948ada Author: Ingvar Stepanyan <ingvar@cloudflare.com> Date: Tue Jun 12 14:06:28 2018 Fix toggles in hosted mode Fix `FilterBar::_update` to pass `false` for disabled items and not `undefined` as `classList.toggle` treats them differently. Bug: 850641 Change-Id: I964c528ad6da495e2fd4078cde415e7cc250a13f Reviewed-on: https://chromium-review.googlesource.com/1091312 Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#566409} [modify] https://crrev.com/447883683661cf3fc7c1296dfa9f379510948ada/third_party/blink/renderer/devtools/front_end/ui/FilterBar.js
,
Jun 12 2018
The fix has been merged; not sure if I have rights to close the issue though (don't see any option to do that in UI).
,
Jun 14 2018
Oh, finally fix this bug! I had reported this bug a year ago: https://bugs.chromium.org/p/chromium/issues/detail?id=717426 No idea why not get fixed on that time, just the same one line changed.
,
Oct 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by krajshree@chromium.org
, Jun 8 2018