New issue
Advanced search Search tips

Issue 850624 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Sign in to add a comment

User navigation prediction

Project Member Reported by chelu@chromium.org, Jun 7 2018

Issue description

Feature description:

The goal of this project is to explore if Chrome can automatically predict the URL of the user’s next navigation (or a set of likely URLs) without depending on hints from the web developer. If the prediction rate is found to be high, then in the future, Chrome can experiment with preloading some of the resources (or preresolving / preconnecting to the hosts of the resources) necessary for the next navigation while the user is reading/interacting with the current webpage.

Design doc: https://docs.google.com/document/d/1BXnEottEZEpRKhwVT3F1S4Lb8kf13EWIyzXMKmj8JFY/edit?usp=sharing
Slides: https://docs.google.com/presentation/d/10gArtBLMQwMIE-nYuBJsmy1aXnOJwUm6VwhcW6506Wg/edit?usp=sharing

Eng owner: chelu@, tbansal@
Product owner: tbansal@

 
Components: -Blink>HTML>A Blink>Loader
Summary: User navigation prediction (was: User navigation )

Comment 2 by chelu@chromium.org, Jun 7 2018

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50da573f8f17aa7182dc42d312ddf0d6a2710d2c

commit 50da573f8f17aa7182dc42d312ddf0d6a2710d2c
Author: Lu Chen <chelu@chromium.org>
Date: Fri Jun 15 04:07:19 2018

Record properties of clicked anchor elements.

When the user clicks an anchor link, the following metrics
will be reported to UMA:
- clickable area;
- distance to root top;
- distance to visible top;
- inside iframe or not;

Bug: 850624.
Change-Id: Ic99ce8a67b05b5d284535fa2d521c659578681d0
Reviewed-on: https://chromium-review.googlesource.com/1089375
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567543}
[modify] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/third_party/blink/renderer/core/html/BUILD.gn
[add] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[add] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/third_party/blink/renderer/core/html/anchor_element_metrics.h
[add] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
[modify] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/50da573f8f17aa7182dc42d312ddf0d6a2710d2c/tools/metrics/histograms/histograms.xml

Comment 4 by chelu@chromium.org, Jun 19 2018

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b07353cf0e9896e194317cf84d8356684798746

commit 0b07353cf0e9896e194317cf84d8356684798746
Author: Lu Chen <chelu@chromium.org>
Date: Tue Jun 26 02:22:38 2018

More anchor element features are added.

When the user clicks an anchor link, the following new metrics
will be reported to UMA:

- distance from the center of the anchor element to visible top;
- distance to root bottom;
- contains an image or not;
- target url has the same origin or not;
- target url is simply incremented by one from source url or not;
- area of the element that intersects the viewport (visible area);

Bug: 850624.
Change-Id: I1d46f389bf6e5b94371db9340baddebd47e03488
Reviewed-on: https://chromium-review.googlesource.com/1103444
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570301}
[modify] https://crrev.com/0b07353cf0e9896e194317cf84d8356684798746/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/0b07353cf0e9896e194317cf84d8356684798746/third_party/blink/renderer/core/html/anchor_element_metrics.h
[modify] https://crrev.com/0b07353cf0e9896e194317cf84d8356684798746/third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
[modify] https://crrev.com/0b07353cf0e9896e194317cf84d8356684798746/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1

commit 5bec7a30f217ecc1aa2e48cc5277a9c6827023d1
Author: Lu Chen <chelu@chromium.org>
Date: Tue Jun 26 18:52:32 2018

Send anchor element metrics to the browser process.

Use mojom to send metrics of anchor elements from the renderer process
to the browser process. In future CLs, the features on the browser side
will be aggregated. Features from both renderer and browser
will be analyzed and used to take some actions accordingly.

Bug: 850624
Change-Id: Iaf36b64c5668db6ccf6b61c6ff7ffe40367f436b
Reviewed-on: https://chromium-review.googlesource.com/1105402
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570476}
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/browser/BUILD.gn
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/browser/chrome_content_browser_client.cc
[add] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/browser/navigation_predictor/OWNERS
[add] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/browser/navigation_predictor/navigation_predictor.cc
[add] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/browser/navigation_predictor/navigation_predictor.h
[add] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/chrome/test/BUILD.gn
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/third_party/blink/public/mojom/loader/navigation_predictor.mojom
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/third_party/blink/renderer/core/html/anchor_element_metrics.h
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/5bec7a30f217ecc1aa2e48cc5277a9c6827023d1/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ab57ac60df711bc6a4b6c68a23e374c41c1da6

commit 27ab57ac60df711bc6a4b6c68a23e374c41c1da6
Author: Lu Chen <chelu@chromium.org>
Date: Wed Jun 27 01:10:45 2018

Move static functions to anonymous namespace.

Move static private functions in AnchorElementMetrics to anonymous namespace.

Bug: 850624
Change-Id: I5429b8ce97d9259a761f16717bad3e3ae88fe774
Reviewed-on: https://chromium-review.googlesource.com/1115814
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570609}
[modify] https://crrev.com/27ab57ac60df711bc6a4b6c68a23e374c41c1da6/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/27ab57ac60df711bc6a4b6c68a23e374c41c1da6/third_party/blink/renderer/core/html/anchor_element_metrics.h
[modify] https://crrev.com/27ab57ac60df711bc6a4b6c68a23e374c41c1da6/third_party/blink/renderer/core/html/anchor_element_metrics_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 3

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9ecec290e797566bdbbe41459d68a4045e29b5e

commit f9ecec290e797566bdbbe41459d68a4045e29b5e
Author: Lu Chen <chelu@chromium.org>
Date: Thu Jul 12 19:15:39 2018

Add bad IPC message check at the browser.

Add bad IPC message check to UpdateAnchorElementMetrics. The browser
will kill the renderer process when it receives a bad message.

Bug: 850624
Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
Reviewed-on: https://chromium-review.googlesource.com/1128259
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574669}
[modify] https://crrev.com/f9ecec290e797566bdbbe41459d68a4045e29b5e/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/f9ecec290e797566bdbbe41459d68a4045e29b5e/chrome/browser/navigation_predictor/navigation_predictor.h
[modify] https://crrev.com/f9ecec290e797566bdbbe41459d68a4045e29b5e/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
[modify] https://crrev.com/f9ecec290e797566bdbbe41459d68a4045e29b5e/tools/metrics/histograms/histograms.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5bda119363ba1815c3d970434177c573bb2d4d

commit 2c5bda119363ba1815c3d970434177c573bb2d4d
Author: Lu Chen <chelu@chromium.org>
Date: Thu Jul 19 21:32:18 2018

Associate mojom sender with document.

In this CL, each document is associated with a mojom sender to
send anchor element metrics to the browser process. Both OnClick
and OnLoad in subsequent CLs use this shared interface.

Bug: 850624
Change-Id: Id7cd36d8f5e1b976ab2e2df17884f0a3805177ff
Reviewed-on: https://chromium-review.googlesource.com/1135980
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576638}
[modify] https://crrev.com/2c5bda119363ba1815c3d970434177c573bb2d4d/third_party/blink/renderer/core/html/BUILD.gn
[modify] https://crrev.com/2c5bda119363ba1815c3d970434177c573bb2d4d/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[add] https://crrev.com/2c5bda119363ba1815c3d970434177c573bb2d4d/third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
[add] https://crrev.com/2c5bda119363ba1815c3d970434177c573bb2d4d/third_party/blink/renderer/core/html/anchor_element_metrics_sender.h

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598

commit b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598
Author: Lu Chen <chelu@chromium.org>
Date: Tue Jul 24 19:21:10 2018

Get and send anchor element metrics in the viewport.

After a webpage is loaded, get metrics of anchor elements in the
viewport and send them to the browser process. These metrics,
together with metrics extracted in the browser process, are used to
compute and record anchor element navigation overall score.

This navigation score will be used to decide what
action (e.g.,preload, prerender) to take, (or choose to do nothing).

Bug: 850624
Change-Id: Ieb85bc0b048f5ec6cb174c41e9b3d72639b393c9
Reviewed-on: https://chromium-review.googlesource.com/1119201
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577634}
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/chrome/browser/navigation_predictor/navigation_predictor.h
[add] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/chrome/test/BUILD.gn
[add] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/chrome/test/data/navigation_predictor/simple_page_with_anchors.html
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/common/features.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/public/common/features.h
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/public/mojom/loader/navigation_predictor.mojom
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/html/anchor_element_metrics.h
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/html/anchor_element_metrics_sender.h
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/b1b31c055dbf36a3fe44e8fe8c7f6617a2db0598/tools/metrics/histograms/histograms.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a7c6714b07e49ceb227874c53beddb811a4a3e6

commit 9a7c6714b07e49ceb227874c53beddb811a4a3e6
Author: Lu Chen <chelu@chromium.org>
Date: Fri Jul 27 17:31:54 2018

Add tbansal@ as owner to histograms AnchorElementMetrics.*.

Also a typo is fixed.

Bug: 850624
Change-Id: I48e73389406327d373ce3c4e269a141314bf3bc7
Reviewed-on: https://chromium-review.googlesource.com/1152178
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578693}
[modify] https://crrev.com/9a7c6714b07e49ceb227874c53beddb811a4a3e6/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 27

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bec133271603dba855b8ac2593ddf08e97a5d8c1

commit bec133271603dba855b8ac2593ddf08e97a5d8c1
Author: Lu Chen <chelu@chromium.org>
Date: Fri Jul 27 23:56:03 2018

Record timing information of anchor element clicks.

Record duration between page load and first click, and intervals
between consecutive clicks. This timing information can help us
analyze the available opportunities to perform preload (and other
pre* mechanisms).

Bug: 850624
Change-Id: I8924d6409ce5695e0d9eb56e9be87b7bf5bfc5c3
Reviewed-on: https://chromium-review.googlesource.com/1149415
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578867}
[modify] https://crrev.com/bec133271603dba855b8ac2593ddf08e97a5d8c1/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/bec133271603dba855b8ac2593ddf08e97a5d8c1/chrome/browser/navigation_predictor/navigation_predictor.h
[modify] https://crrev.com/bec133271603dba855b8ac2593ddf08e97a5d8c1/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[modify] https://crrev.com/bec133271603dba855b8ac2593ddf08e97a5d8c1/tools/metrics/histograms/histograms.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a29004ae71d76280154cb85bc8328bfc81e7b98

commit 2a29004ae71d76280154cb85bc8328bfc81e7b98
Author: Lu Chen <chelu@chromium.org>
Date: Mon Jul 30 22:30:17 2018

Processing of anchor metrics in the browser process.

In this CL, metrics from the renderer process are processed in the
browser. We extract document level metrics (e.g., number of links),
as well as derived features (e.g., area rank).

The calculated navigation scores (and other info) from onLoad are
stored and can be looked up when an anchor element is clicked.

Bug: 850624
Change-Id: I3a7516d3a991dc278441fb925822efa780a84b8d
Reviewed-on: https://chromium-review.googlesource.com/1132680
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579203}
[modify] https://crrev.com/2a29004ae71d76280154cb85bc8328bfc81e7b98/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/2a29004ae71d76280154cb85bc8328bfc81e7b98/chrome/browser/navigation_predictor/navigation_predictor.h
[modify] https://crrev.com/2a29004ae71d76280154cb85bc8328bfc81e7b98/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[modify] https://crrev.com/2a29004ae71d76280154cb85bc8328bfc81e7b98/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
[add] https://crrev.com/2a29004ae71d76280154cb85bc8328bfc81e7b98/chrome/test/data/navigation_predictor/anchors_different_area.html
[modify] https://crrev.com/2a29004ae71d76280154cb85bc8328bfc81e7b98/tools/metrics/histograms/histograms.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ab753ccbe1e2857ed05d287424aecae1a5fa80

commit 16ab753ccbe1e2857ed05d287424aecae1a5fa80
Author: Lu Chen <chelu@chromium.org>
Date: Tue Jul 31 21:49:36 2018

Use finch to control scaling factors of each feature.

Finch is used to control the scales of each feature when
calculating navigation scores.

This CL is blocked on 1132680.

Bug: 850624
Change-Id: I422f1e7f9f9db17530694d7445ab1233976f5930
Reviewed-on: https://chromium-review.googlesource.com/1152037
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579582}
[modify] https://crrev.com/16ab753ccbe1e2857ed05d287424aecae1a5fa80/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/16ab753ccbe1e2857ed05d287424aecae1a5fa80/chrome/browser/navigation_predictor/navigation_predictor.h
[modify] https://crrev.com/16ab753ccbe1e2857ed05d287424aecae1a5fa80/chrome/browser/navigation_predictor/navigation_predictor_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee2eeee1cf347d431106c33af262ceb03c0a61e2

commit ee2eeee1cf347d431106c33af262ceb03c0a61e2
Author: Lu Chen <chelu@chromium.org>
Date: Tue Jul 31 22:18:45 2018

Add recording of visible href site engagement scores.

Add recording of AnchorElementMetrics.Visible.HrefEngagementScore2.

Bug: 850624
Change-Id: I5291067e2b9f1edfb8dd4e23fca3df802a153228
Reviewed-on: https://chromium-review.googlesource.com/1156000
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579594}
[modify] https://crrev.com/ee2eeee1cf347d431106c33af262ceb03c0a61e2/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/ee2eeee1cf347d431106c33af262ceb03c0a61e2/tools/metrics/histograms/histograms.xml

Project Member

Comment 18 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4170f3f7b62325bac50f4d0b6672d4595c12fbfa

commit 4170f3f7b62325bac50f4d0b6672d4595c12fbfa
Author: Lu Chen <chelu@chromium.org>
Date: Wed Aug 01 19:52:15 2018

Add recording of the root document height.

Add recording of AnchorElementMetrics.Clicked.RatioRootHeight.

Bug: 850624
Change-Id: Ia5ff57cc729cf7d577a59967f473c50da99e1e3b
Reviewed-on: https://chromium-review.googlesource.com/1157282
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Lu Chen <chelu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579906}
[modify] https://crrev.com/4170f3f7b62325bac50f4d0b6672d4595c12fbfa/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/4170f3f7b62325bac50f4d0b6672d4595c12fbfa/third_party/blink/renderer/core/html/anchor_element_metrics.h
[modify] https://crrev.com/4170f3f7b62325bac50f4d0b6672d4595c12fbfa/tools/metrics/histograms/histograms.xml

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b870c2c6af135ec950a78acb6f3d0d6068800dfd

commit b870c2c6af135ec950a78acb6f3d0d6068800dfd
Author: Lu Chen <chelu@chromium.org>
Date: Thu Aug 02 00:11:04 2018

Add recording of engagement score of external href.

Add recording of AnchorElementMetrics.*.HrefEngagementScoreExternal.

Bug: 850624
Change-Id: I049b5847beb76a80a7c30077373f50079cee061c
Reviewed-on: https://chromium-review.googlesource.com/1157551
Commit-Queue: Lu Chen <chelu@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580003}
[modify] https://crrev.com/b870c2c6af135ec950a78acb6f3d0d6068800dfd/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/b870c2c6af135ec950a78acb6f3d0d6068800dfd/tools/metrics/histograms/histograms.xml

Project Member

Comment 20 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee5a096ff63455739fbbf2e79b6eb7aea6611f7

commit 5ee5a096ff63455739fbbf2e79b6eb7aea6611f7
Author: Tarun Bansal <tbansal@chromium.org>
Date: Sat Sep 22 01:09:33 2018

Add NavigationPredictor to fieldtrial_testing_config

The field trial is enabled for Android only.

Change-Id: I6ddddf15369da72b91d1e90a9d02bc9d0d61eb27
Bug: 850624
Reviewed-on: https://chromium-review.googlesource.com/1239034
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593401}
[modify] https://crrev.com/5ee5a096ff63455739fbbf2e79b6eb7aea6611f7/testing/variations/fieldtrial_testing_config.json

Cc: -tbansal@chromium.org chelu@chromium.org
Owner: tbansal@chromium.org
Status: Started (was: Assigned)
Blockedon: 891719 871521 899109 891736 899098
Blockedon: 893864 893855
Blockedon: 899339
Blockedon: 899400
Blockedon: 899406
Blockedon: 903884
Blockedon: 903945
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/290d578e4aa4458206ceb564744ef3d7c43c7c9a

commit 290d578e4aa4458206ceb564744ef3d7c43c7c9a
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Nov 12 21:08:12 2018

Include anchor element metrics that differ from one from document URL

Currently, the render process sends the statistics of
only the anchor elements that are in the viewport to
the browser. This CL changes it to also include the
anchor elements whose target URL is one digit different
from the document URL.

Note that there is still a limit of 40 on the count of anchor
elements that are sent from the render to the browser process.

Change-Id: I4083e3605095a44700cc2178615713ede6e0dde2
Bug: 850624
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1329848
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607328}
[modify] https://crrev.com/290d578e4aa4458206ceb564744ef3d7c43c7c9a/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[add] https://crrev.com/290d578e4aa4458206ceb564744ef3d7c43c7c9a/chrome/test/data/navigation_predictor/long_page_with_anchors-1.html
[modify] https://crrev.com/290d578e4aa4458206ceb564744ef3d7c43c7c9a/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/290d578e4aa4458206ceb564744ef3d7c43c7c9a/third_party/blink/renderer/core/html/anchor_element_metrics.h

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa9be2897840783b56146d69021ed259e5bac879

commit fa9be2897840783b56146d69021ed259e5bac879
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Nov 14 20:23:46 2018

Revert "Include anchor element metrics that differ from one from document URL"

This reverts commit 290d578e4aa4458206ceb564744ef3d7c43c7c9a.

Reason for revert: Crashes renderer

Original change's description:
> Include anchor element metrics that differ from one from document URL
> 
> Currently, the render process sends the statistics of
> only the anchor elements that are in the viewport to
> the browser. This CL changes it to also include the
> anchor elements whose target URL is one digit different
> from the document URL.
> 
> Note that there is still a limit of 40 on the count of anchor
> elements that are sent from the render to the browser process.
> 
> Change-Id: I4083e3605095a44700cc2178615713ede6e0dde2
> Bug: 850624
> TBR: ryansturm@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/1329848
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607328}

TBR=kinuko@chromium.org,tbansal@chromium.org,ryansturm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 850624,905224
Change-Id: I8fe41adb0434d410eb6fd2244e525c05037585f2
Reviewed-on: https://chromium-review.googlesource.com/c/1335664
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608105}
[modify] https://crrev.com/fa9be2897840783b56146d69021ed259e5bac879/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[delete] https://crrev.com/19f9a541235436db865c01288520cd9c16f3129f/chrome/test/data/navigation_predictor/long_page_with_anchors-1.html
[modify] https://crrev.com/fa9be2897840783b56146d69021ed259e5bac879/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/fa9be2897840783b56146d69021ed259e5bac879/third_party/blink/renderer/core/html/anchor_element_metrics.h

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 14

Labels: merge-merged-3610
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360712ef4f774cabcbe48700d36046005ff95d27

commit 360712ef4f774cabcbe48700d36046005ff95d27
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Nov 14 23:18:11 2018

Revert "Include anchor element metrics that differ from one from document URL"

This reverts commit 290d578e4aa4458206ceb564744ef3d7c43c7c9a.

Reason for revert: Crashes renderer

Original change's description:
> Include anchor element metrics that differ from one from document URL
> 
> Currently, the render process sends the statistics of
> only the anchor elements that are in the viewport to
> the browser. This CL changes it to also include the
> anchor elements whose target URL is one digit different
> from the document URL.
> 
> Note that there is still a limit of 40 on the count of anchor
> elements that are sent from the render to the browser process.
> 
> Change-Id: I4083e3605095a44700cc2178615713ede6e0dde2
> Bug: 850624
> TBR: ryansturm@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/1329848
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607328}

TBR=kinuko@chromium.org,tbansal@chromium.org,ryansturm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 850624,905224
Change-Id: I8fe41adb0434d410eb6fd2244e525c05037585f2
Reviewed-on: https://chromium-review.googlesource.com/c/1335664
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#608105}(cherry picked from commit fa9be2897840783b56146d69021ed259e5bac879)
Reviewed-on: https://chromium-review.googlesource.com/c/1336551
Cr-Commit-Position: refs/branch-heads/3610@{#4}
Cr-Branched-From: 070b13aa73c17a7fbe958d30352de51880f9582e-refs/heads/master@{#607838}
[modify] https://crrev.com/360712ef4f774cabcbe48700d36046005ff95d27/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[delete] https://crrev.com/c93601c939689d6964bcd6e47e951dcd22d0ab0d/chrome/test/data/navigation_predictor/long_page_with_anchors-1.html
[modify] https://crrev.com/360712ef4f774cabcbe48700d36046005ff95d27/third_party/blink/renderer/core/html/anchor_element_metrics.cc
[modify] https://crrev.com/360712ef4f774cabcbe48700d36046005ff95d27/third_party/blink/renderer/core/html/anchor_element_metrics.h

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77cd8b89e0339c081175f42484965e36d2891e8c

commit 77cd8b89e0339c081175f42484965e36d2891e8c
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Nov 26 16:52:30 2018

Include anchor element metrics that differ from one from document URL

Currently, the render process sends the statistics of
only the anchor elements that are in the viewport to
the browser. This CL changes it to also include the
anchor elements whose target URL is one digit different
from the document URL.

Note that there is still a limit of 40 on the count of anchor
elements that are sent from the render to the browser process.

Bug: 850624
Change-Id: I25443e44959c768b869f5b852a28baf5b0271034
Reviewed-on: https://chromium-review.googlesource.com/c/1344268
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610861}
[modify] https://crrev.com/77cd8b89e0339c081175f42484965e36d2891e8c/chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
[add] https://crrev.com/77cd8b89e0339c081175f42484965e36d2891e8c/chrome/test/data/navigation_predictor/long_page_with_anchors-1.html
[modify] https://crrev.com/77cd8b89e0339c081175f42484965e36d2891e8c/third_party/blink/renderer/core/html/anchor_element_metrics.cc

Blockedon: 908725
Project Member

Comment 34 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c65b27478bbd4a73ec8e8260c7cc1d305d40071

commit 2c65b27478bbd4a73ec8e8260c7cc1d305d40071
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Dec 12 22:18:24 2018

Update field trial config to match finch params

Change-Id: I26447006b81184d805527dc3c41bffd1ccf72a59
Bug: 850624
Reviewed-on: https://chromium-review.googlesource.com/c/1374518
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616081}
[modify] https://crrev.com/2c65b27478bbd4a73ec8e8260c7cc1d305d40071/testing/variations/fieldtrial_testing_config.json

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment