New issue
Advanced search Search tips

Issue 850597 link

Starred by 1 user
Status: Assigned
Owner:
tmartino@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use string instead of string16 for icon in Autofill Suggestion

Project Member Reported by tmartino@chromium.org, Jun 7 2018 
This is not a user-facing string, so we can save a few bytes and in theory be more consistent with the rest of Chrome by using a string instead of a string16.

Comment 1 by est...@chromium.org, Jun 7 2018 

The reason to use the correct string type is that you're saving on conversions and you're making the meaning more self-evident. string16 always implies user-facing, so if someone reads

  string16 icon;

they would be led to assume it's some text on screen associated with an icon.
►

Sign in to add a comment