Issue 850594 link

Starred by 3 users

Issue metadata

Status:	Assigned
Owner:	robliao@chromium.org
Components:	Internals>Views
EstimatedDays:	----
NextAction:	----
OS:	Mac
Pri:	2
Type:	Bug
Proj-MacViews MacViews-Browser Target-70 M-70 Group-Tests Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired

Blocking:
issue 845389

MacViews: fullscreen element tests are broken

Project Member Reported by ellyjo...@chromium.org, Jun 7 2018

Issue description

I think these are misbehaving because of MacViews' janky fullscreen.

SitePerProcessInteractiveBrowserTest.FullscreenElementInABAAndExitViaEscapeKey
SitePerProcessInteractiveBrowserTest.FullscreenElementInABAAndExitViaJS
BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc
SitePerProcessInteractiveBrowserTest.FullscreenElementInSubframe

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48a689e2976d5b507bf6544a784a9228c27c4a14

commit 48a689e2976d5b507bf6544a784a9228c27c4a14
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Jun 07 18:14:35 2018

macviews: disable a few fullscreen tests

These tests are hitting some corner case of MacViews fullscreen.

TBR=sky@chromium.org

Bug: 850594
Change-Id: I7ee54c3d1076ef29007c89ff573013a0514ace1a
Reviewed-on: https://chromium-review.googlesource.com/1091136
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565349}
[modify] https://crrev.com/48a689e2976d5b507bf6544a784a9228c27c4a14/chrome/browser/site_per_process_interactive_browsertest.cc
[modify] https://crrev.com/48a689e2976d5b507bf6544a784a9228c27c4a14/chrome/browser/ui/browser_command_controller_interactive_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afd059ad87eb7e45a6bf154f0d91d32d13e72222

commit afd059ad87eb7e45a6bf154f0d91d32d13e72222
Author: Tim Schumann <tschumann@chromium.org>
Date: Mon Jun 11 10:44:46 2018

Disable itePerProcessInteractiveBrowserTest.FullscreenElementInABAAndExitViaJS

This test is flaky on Linux. Given that it's also not working well on Mac, I just disabled
it completely.

TBR=sky@chromium.org

Bug: 851236, 850594
Change-Id: I6a1a3194dcc32d0e49dcecc23bc26f86086c4eb5
Reviewed-on: https://chromium-review.googlesource.com/1095175
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565957}
[modify] https://crrev.com/afd059ad87eb7e45a6bf154f0d91d32d13e72222/chrome/browser/site_per_process_interactive_browsertest.cc