New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850589 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Reset ArcSupervisionTransition flag if ARC container is delete

Project Member Reported by brunokim@chromium.org, Jun 7 2018

Issue description

ArcSupervisionTransition tracks whether the user has transitioned from a child to a regular account and vice-versa. This setting is necessary to block access to ARC if it's still being updated or has failed to update itself.

We should reset the flag to NO_TRANSITION if the ARC container is recreated manually, or via other means.

 
Cc: brunokim@chromium.org
Owner: hgrandinetti@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f5cb50024fe59188ca1471085dc750990b9af4e

commit 0f5cb50024fe59188ca1471085dc750990b9af4e
Author: Henrique Grandinetti <hgrandinetti@chromium.org>
Date: Thu Jul 19 12:41:05 2018

Reset ArcSupervisionTransition when ARC is disabled.

Bug:  850589 
Change-Id: Ic7fbe53143ac5ffb940822a0af76e89f5060e084
Reviewed-on: https://chromium-review.googlesource.com/1142207
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#576457}
[modify] https://crrev.com/0f5cb50024fe59188ca1471085dc750990b9af4e/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/0f5cb50024fe59188ca1471085dc750990b9af4e/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc

Status: Fixed (was: Assigned)
Labels: -Type-Task Hotlist-Unichrome-ARCSupervision Merge-Request-69 Hotlist-Unichrome-Geller Type-Bug
Changing the type to bug, as the change in comment #2 did not made into the M69 cut and without it, it does creates a bug to the user.

Also requesting a cherry-pick.
Status: Started (was: Fixed)
Keeping it open until we merge into M69.
For the record here's the bug report: https://bugs.chromium.org/p/chromium/issues/detail?id=866174#c5
Labels: -Merge-Request-69
Status: Fixed (was: Started)
Actually, this made into the M69 cut, so I am closing the bug and removing the merge request tag.

Sign in to add a comment