In fact, correction, this seems to affect all Windows. And it's not "nothing" that happens, but the window gets maximized, which is quite frustrating.

This might actually be the same bug as  issue 828429  so feel free to dup in.

We did this on purpose for tabbed windows, but we might want to re-allow this on popup/app windows.

Ah, yeah, it needs to only happen for tabbed windows.  I thought they used a different window frame.  Blargh.  Should block release, as we shouldn't regress this for windows with icons, it's basic platform-native functionality.  So P2.  My bad.

They (sorta) did before custom titlebar, which maybe explains your confusion. I forgot too though, when I reviewed it :)

Any movement on this bug?

@6: Given that I've been in office one total day since comment 3, no, there is no movement on this bug :)

I will make sure to fix it before we launch, but it might be awhile.  Patches welcome if you want to try and chip in a fix sooner, it shouldn't be too complicated a fix to implement.

okay no problems. Monday is the day I ping bugs I opened to check they haven't been forgotten, so you being away was purely a coincidence. :)

Is it worth making this a release blocker, as per comment #3?

All Refresh Pri 0-2 bugs are currently "release blocking" on my list.

With NTB back on the trailing position, how does that impact the top-left corner for app windows?

Since refresh's square-sided tabs mean we can't support HTSYSMENU even for AFTER_TABS NTB, the check in the code (that's causing problems) is for all refresh, so it's still a problem.

Load balancing. Let's give enabling it for all frames a try. If the hit target ends up being too small, we'll reassess.

Why would we put it on for all frames?  Doing that correctly is harder than doing what this asked for.

I'd like to keep this.

I was under the impression that the changes to GlassBrowserFrameView & OpaqueBrowserFrameView were what caused this issue. Since the NTB is back to the AFTER_TABS position, the sys menu region is freed up (kind of). Rolling back the HTSYSMENU changes would enable it again for the tabbed window and the app windows. 

See comment 12; the different tab shape means that once I fix the positioning to not have a giant gap on the left, we still cover a chunk of this region.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f1df1b6f238a42a82110545b06a748bccb20ae

commit 48f1df1b6f238a42a82110545b06a748bccb20ae
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Jul 13 04:01:04 2018

Allow HTSYSMENU on windows with icons.

Bug:  850573 
Test: Open a popup window (e.g. using popuptest.com); double-clicking the window icon should close the window
Change-Id: Iec6b2d192502557f1e95ade99c204a6db58dfff6
Reviewed-on: https://chromium-review.googlesource.com/1136059
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574838}
[modify] https://crrev.com/48f1df1b6f238a42a82110545b06a748bccb20ae/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/48f1df1b6f238a42a82110545b06a748bccb20ae/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Unable to reproduce the issue on eported chrome version 69.0.3451.0 using Windows.
Steps:
---------
1. Launched Chrome 
2. Navigated to "popuptest.com" as per comment #18 
3. Clicked on Multi-PopUp Test and on top left double clicked on window icon.
We have Observed that ""Popup window closed""

@Reporter: Please find the attached screen-cast and let us know if we have missed anything in the process. Could you please help in verifying the fix. 

Thanks..!

Deleted: 850573.mp4 5.8 MB

	850573.mp4 5.8 MB View Download

I don't understand how you're running a build that reports itself as 69.0.3451.0 stable.  We haven't released M69 on the stable channel.

This issue only reproduced in Material Refresh mode, and you were running in pre-refresh.  Enable --top-chrome-md=material-refresh to see the issue.