[Payments] Small changes in the Card unmask dialog |
||||||||||||
Issue description(1) Less padding in the footer view (should be 16dp top and bottom) (2) Blue throbber should be GoogleBlue600 (3) Tooltip icon should be 16dp and not 18dp (4) Permanent error screen should be redone (mocks to follow).
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0aa2b05e08fc7a83eefb9af7846f3ff2146c8f12 commit 0aa2b05e08fc7a83eefb9af7846f3ff2146c8f12 Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Jun 08 02:45:57 2018 [Autofill] Adjust the light grey color of the Card Unmask dialog Also, set the light grey in the Footer section as per mocks. Replaces hardcoded text color values with the GetColor API. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: I4850f65be55df0c4283e194866cfaa54da72fdd3 Reviewed-on: https://chromium-review.googlesource.com/1083015 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565519} [modify] https://crrev.com/0aa2b05e08fc7a83eefb9af7846f3ff2146c8f12/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7430a84ce956318c2fbc862ff365d25e19db77dd commit 7430a84ce956318c2fbc862ff365d25e19db77dd Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Jun 08 03:05:08 2018 [Views] Change the blue on the throbber As per mocks and new style, should be Google Blue 600. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: Ib9ee2112eb0efac2bbbd816dc7c9bd6f53e82471 Reviewed-on: https://chromium-review.googlesource.com/1089577 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#565523} [modify] https://crrev.com/7430a84ce956318c2fbc862ff365d25e19db77dd/ui/native_theme/common_theme.cc
,
Jun 8 2018
mathp@, Could you please let us know exact steps to verify this issue from our end?When we will get this dialog boxes in C#2? Thanks in advance..!
,
Jun 8 2018
#c5, there is no testing to be done at this point. These are very minor visual changes.
,
Jun 8 2018
Before and after: the tooltip icon is now smaller (16 vs 18)
,
Jun 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1182c84d9849940a6f6be3ec22d8b244dc554a53 commit 1182c84d9849940a6f6be3ec22d8b244dc554a53 Author: Mathieu Perreault <mathp@chromium.org> Date: Sat Jun 09 17:18:56 2018 [Views] Change tooltip icon size to 16dp It's not recommended to draw outside the canvas factors (here canvas is 32), and this icon should be 16, as wanted by UX and demonstrated by PNG tooltips which are 16dp. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --draw-view-bounds-rects --test-launcher-interactive Change-Id: I8401c11c60f5926bec81baaf4cb079f93ce87f5c Reviewed-on: https://chromium-review.googlesource.com/1091130 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565888} [modify] https://crrev.com/1182c84d9849940a6f6be3ec22d8b244dc554a53/ui/views/bubble/tooltip_icon.cc
,
Jun 12 2018
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4dac551200179cba3fc763a4e39e4ddfc5381ee3 commit 4dac551200179cba3fc763a4e39e4ddfc5381ee3 Author: Mathieu Perreault <mathp@chromium.org> Date: Tue Jun 12 19:59:20 2018 [Views] Change dialog footnote colors to use GoogleGrey 050 and 200. Per the mocks and designers, the dialog footers should be Grey050 and the top separator Grey200. This replaces the previously harcoded colors. Screenshots on the bug. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --draw-view-bounds-rects --test-launcher-interactive Change-Id: Ic450f161e56074fe04809aa577bce2dae17befd0 Reviewed-on: https://chromium-review.googlesource.com/1096912 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#566540} [modify] https://crrev.com/4dac551200179cba3fc763a4e39e4ddfc5381ee3/ui/views/bubble/bubble_frame_view.cc
,
Jun 13 2018
https://chromium-review.googlesource.com/c/chromium/src/+/1098694 in review See attached screenshots
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b000c5b7d357c8b3ccc134cb2e0c37d1d1d6f94 commit 1b000c5b7d357c8b3ccc134cb2e0c37d1d1d6f94 Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Jun 13 21:38:40 2018 [Payments] Padding and color tweaks in the Card Unmask dialog Making the dialog compliant with mocks. Includes: - Changing the warning icon from the warning triangle to the warning circle. - Vertically centering the warning icon. - Using GetStyle and GetColor to get the appropriate Red color. - Using appropriate dialog insets. - Using appropriate distances between items. - Remove leading margin on New Card link. See screenshots in the bug. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_TemporaryError --draw-view-bounds-rects --test-launcher-interactive Change-Id: I5d28fa8d7bdda4a50ac65def53e49284ad16757c Reviewed-on: https://chromium-review.googlesource.com/1098694 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#566995} [modify] https://crrev.com/1b000c5b7d357c8b3ccc134cb2e0c37d1d1d6f94/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/1b000c5b7d357c8b3ccc134cb2e0c37d1d1d6f94/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9675d8b1468f6f3815c43364feb9e3c0be3b117 commit d9675d8b1468f6f3815c43364feb9e3c0be3b117 Author: Mathieu Perreault <mathp@chromium.org> Date: Thu Jun 14 22:12:44 2018 [Autofill] Reuse overlay for permanent errors in Card unmask dialog Reuse the progress overlay (Throbber with "Confirming card...") to display a permanent error. The Throbber is changed into an error icon, and the error is shown in red. Test is changed to use a long string, for easier UI regression testing. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-interactive Change-Id: I4d92ce0a8535e92f8707edf6f4444c53e80eea3e Reviewed-on: https://chromium-review.googlesource.com/1100336 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#567440} [modify] https://crrev.com/d9675d8b1468f6f3815c43364feb9e3c0be3b117/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc [modify] https://crrev.com/d9675d8b1468f6f3815c43364feb9e3c0be3b117/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/d9675d8b1468f6f3815c43364feb9e3c0be3b117/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195d521f031cd63850ee1325cc90df01e756cd3a commit 195d521f031cd63850ee1325cc90df01e756cd3a Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Jun 15 13:26:12 2018 [Autofill] Update some strings in Card Unmask dialog. Permanent error string and "Update card" links. Bug: 850571 Test: none Change-Id: Ic5f726363336ac7c2e860d8794e3614d3654627d Reviewed-on: https://chromium-review.googlesource.com/1102038 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567623} [modify] https://crrev.com/195d521f031cd63850ee1325cc90df01e756cd3a/components/autofill_strings.grdp [add] https://crrev.com/195d521f031cd63850ee1325cc90df01e756cd3a/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_UNMASK_NEW_CARD_LINK.png.sha1 [add] https://crrev.com/195d521f031cd63850ee1325cc90df01e756cd3a/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_PERMANENT.png.sha1
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d31c147af36834b5c218d3d121adac4b899665c4 commit d31c147af36834b5c218d3d121adac4b899665c4 Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Jun 18 17:33:58 2018 [Payments] Update a string in the card unmask dialog. Updating some screenshots too. Bug: 850571 Change-Id: I97bce0907e85d530f6a22ecfc3d5a0b0a029baee Reviewed-on: https://chromium-review.googlesource.com/1103770 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#568055} [modify] https://crrev.com/d31c147af36834b5c218d3d121adac4b899665c4/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc [modify] https://crrev.com/d31c147af36834b5c218d3d121adac4b899665c4/components/autofill_strings.grdp [modify] https://crrev.com/d31c147af36834b5c218d3d121adac4b899665c4/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_PERMANENT.png.sha1 [add] https://crrev.com/d31c147af36834b5c218d3d121adac4b899665c4/components/autofill_strings_grdp/IDS_AUTOFILL_CARD_UNMASK_PROMPT_ERROR_TRY_AGAIN_CVC.png.sha1
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/232549f0a2363a0648096fad858091321214d46d commit 232549f0a2363a0648096fad858091321214d46d Author: Mathieu Perreault <mathp@chromium.org> Date: Tue Jun 19 02:24:28 2018 [Theme] Adjust default colors (green and red) to be lighter According to designers and internal spec (https://goo.gl/oRp6PA), some colors are a shade lighter. Bug: 850571 Test: Visual Change-Id: I2c593ed0019c9497873f0f8efa42b592e187d89b Reviewed-on: https://chromium-review.googlesource.com/1099687 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#568306} [modify] https://crrev.com/232549f0a2363a0648096fad858091321214d46d/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/232549f0a2363a0648096fad858091321214d46d/ui/native_theme/common_theme.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/100c6dbfb73b158fdc04daae4c5eafae7b4cedae commit 100c6dbfb73b158fdc04daae4c5eafae7b4cedae Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Jun 20 21:56:58 2018 [Payments] Remove the tooltip icon from the Card Unmask dialog If was considered redundant by UX designer and writer. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-intera Change-Id: I3630fabdc7cabec92106d75ed907faa1b72a64b1 Reviewed-on: https://chromium-review.googlesource.com/1107778 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569040} [modify] https://crrev.com/100c6dbfb73b158fdc04daae4c5eafae7b4cedae/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/feb1a55dde8cada98ddb3058993fae60b1133cc0 commit feb1a55dde8cada98ddb3058993fae60b1133cc0 Author: Mathieu Perreault <mathp@chromium.org> Date: Sat Jun 23 22:46:14 2018 [Payments] In permanent error state of unmask, only show Close - Also updating a string per UX writer, to add ellipsis to "Confirming card" - Reordered functions to match header. - Exposing Verification Result from controller Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid_PermanentError --test-launcher-interactive Change-Id: I463709247157bd9a82e708e510d14f1b182a58db Reviewed-on: https://chromium-review.googlesource.com/1105517 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#569909} [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/components/autofill/core/browser/ui/card_unmask_prompt_controller.h [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h [modify] https://crrev.com/feb1a55dde8cada98ddb3058993fae60b1133cc0/components/autofill_strings.grdp
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41933615f82e68565c718638d7db24bcd575bade commit 41933615f82e68565c718638d7db24bcd575bade Author: Mathieu Perreault <mathp@chromium.org> Date: Tue Jun 26 18:05:40 2018 [Payments] Change the CVC icon in the card unmask dialog. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --test-launcher-interactive Change-Id: Ifff7c246587ad9ac59c8dc02bafc2905d81b4758 Reviewed-on: https://chromium-review.googlesource.com/1112499 Reviewed-by: Cait Phillips <caitkp@chromium.org> Reviewed-by: Moe Ahmadi (OOO until July 3) <mahmadi@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570463} [modify] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/OWNERS [modify] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/default_100_percent/autofill/credit_card_cvc_hint.png [modify] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/default_100_percent/autofill/credit_card_cvc_hint_amex.png [modify] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/default_200_percent/autofill/credit_card_cvc_hint.png [modify] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/default_200_percent/autofill/credit_card_cvc_hint_amex.png [add] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/default_300_percent/autofill/credit_card_cvc_hint.png [add] https://crrev.com/41933615f82e68565c718638d7db24bcd575bade/components/resources/default_300_percent/autofill/credit_card_cvc_hint_amex.png
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c383b029f0267950c5515178d35f85a440222be7 commit c383b029f0267950c5515178d35f85a440222be7 Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Jul 04 01:36:38 2018 [Payments] Fix some issues around buttons for Card Unmask dialog - The close button is the now the only button showing if there is a permanent error or a network failure. - State is reset appropriately between dialog shows. - Layout is called on the whole widget when buttons change. Bug: 850571 Change-Id: I1dfe792b49102d8a002d9bcf984e8c6c0844cc58 Reviewed-on: https://chromium-review.googlesource.com/1119164 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572438} [modify] https://crrev.com/c383b029f0267950c5515178d35f85a440222be7/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/c383b029f0267950c5515178d35f85a440222be7/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc [modify] https://crrev.com/c383b029f0267950c5515178d35f85a440222be7/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl_unittest.cc
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44250a6f866c90842d6fc51389c41d03c88962ed commit 44250a6f866c90842d6fc51389c41d03c88962ed Author: Mathieu Perreault <mathp@chromium.org> Date: Wed Jul 04 23:52:51 2018 [Payments] Simplify code for the footnote view in the Card unmask dialog. As mentioned in another review, the |storage_row_| is not needed as there is only one view in the footnote now. Bug: 850571 Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_valid --test-launcher-interactive Change-Id: I99aafcee3eea36e894b2321cb4dafd15167dd69f Reviewed-on: https://chromium-review.googlesource.com/1126210 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#572678} [modify] https://crrev.com/44250a6f866c90842d6fc51389c41d03c88962ed/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc [modify] https://crrev.com/44250a6f866c90842d6fc51389c41d03c88962ed/chrome/browser/ui/views/autofill/card_unmask_prompt_views.h
,
Jul 5
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ma...@chromium.org
, Jun 7 201878.7 KB
78.7 KB View Download
74.2 KB
74.2 KB View Download