VR Browsing - Media Controls are larger causing timestamp of video to be cut off in Full-Screen mode. |
||||||||||
Issue descriptionChrome Version: 69.0.3451.0 OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Enter VR Browsing (2) Launch a video (3) Click the Full-screen icon bottom right. What is the expected result? The controls should remain the same size or at least not grow so much that the timestamp is cut off. See M68 Media Controls for what was there previously. What happens instead? The Media Controls have been enlarged. Because of the larger size the timestamp is cut off. NOTE The enlarging of the controls appears to be a Chrome/Media style change. However outside of VR Browsing the controls are not cut off.
,
Jun 13 2018
,
Jun 14 2018
Thank you for taking a look.
,
Jun 14 2018
,
Jun 14 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daf6f231d72f09a419c3cb0c18c1de4b24d0cafb commit daf6f231d72f09a419c3cb0c18c1de4b24d0cafb Author: Tommy Steimel <steimel@chromium.org> Date: Fri Jun 15 16:26:09 2018 [Media Controls VR] Fix time display and buttons on large videos This CL adds specifications for time display font size and media button background size. This fixes an issue where the time display and media buttons were scaling up with the video size despite being in immersive mode. Bug: 850562 Change-Id: I1d6734f281bcfe2c269ab39efea958bd6087a1b5 Reviewed-on: https://chromium-review.googlesource.com/1101904 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567681} [modify] https://crrev.com/daf6f231d72f09a419c3cb0c18c1de4b24d0cafb/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html [modify] https://crrev.com/daf6f231d72f09a419c3cb0c18c1de4b24d0cafb/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/daf6f231d72f09a419c3cb0c18c1de4b24d0cafb/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
,
Jun 20 2018
Issue is fixed, verified in Chrome Canary 69.0.3466.0
,
Jun 20 2018
,
Jun 20 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aba668d485163bff6b3c91bd039628459572ec5d commit aba668d485163bff6b3c91bd039628459572ec5d Author: Tommy Steimel <steimel@chromium.org> Date: Thu Jun 21 22:47:05 2018 [Media Controls VR] Fix time display and buttons on large videos This CL adds specifications for time display font size and media button background size. This fixes an issue where the time display and media buttons were scaling up with the video size despite being in immersive mode. Bug: 850562 Change-Id: I1d6734f281bcfe2c269ab39efea958bd6087a1b5 Reviewed-on: https://chromium-review.googlesource.com/1101904 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#567681}(cherry picked from commit daf6f231d72f09a419c3cb0c18c1de4b24d0cafb) Reviewed-on: https://chromium-review.googlesource.com/1110900 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#476} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/aba668d485163bff6b3c91bd039628459572ec5d/third_party/WebKit/LayoutTests/media/controls/modern/immersive-mode-adds-css-class.html [modify] https://crrev.com/aba668d485163bff6b3c91bd039628459572ec5d/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/aba668d485163bff6b3c91bd039628459572ec5d/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
,
Jun 26 2018
Verified in Chrome Beta 68.0.3440.39
,
Jun 26 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by asimjour@chromium.org
, Jun 7 2018Status: Assigned (was: Untriaged)