New issue
Advanced search Search tips

Issue 850556 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 843511



Sign in to add a comment

snapshot_unittests's SnapshotAuraTest fail on Win10

Project Member Reported by thakis@chromium.org, Jun 7 2018

Issue description

I'm enabling snapshot_unittests on all bots in https://chromium-review.googlesource.com/c/chromium/src/+/1089655

It fails on win10:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10_chromium_x64_rel_ng/23370

SnapshotAuraTest.RotateAndUIScaleAndScaleFactor
SnapshotAuraTest.PartialBounds
SnapshotAuraTest.DeviceScaleFactor
SnapshotAuraTest.Rotated
SnapshotAuraTest.UIScale
SnapshotAuraTest.RotateAndUIScale
SnapshotAuraTest.FullScreenWindow


Stacks all look like some kind of

[ RUN      ] SnapshotAuraTest.Rotated
../../ui/snapshot/snapshot_aura_unittest.cc(215): error: Expected equality of these values:
  test_bounds.size().ToString()
    Which is: "300x200"
  snapshot.Size().ToString()
    Which is: "200x300"
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF66CC90243+87]
	testing::internal::AssertHelper::operator= [0x00007FF66CC8FDE8+78]
	ui::SnapshotAuraTest_Rotated_Test::TestBody [0x00007FF66C991854+328]
../../ui/snapshot/snapshot_aura_unittest.cc(216): error: Expected equality of these values:
  0u
    Which is: 0
  GetFailedPixelsCount(snapshot)
    Which is: 60000
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF66CC90243+87]
	testing::internal::AssertHelper::operator= [0x00007FF66CC8FDE8+78]
	ui::SnapshotAuraTest_Rotated_Test::TestBody [0x00007FF66C99191B+527]



(The test passes fine on win7: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/8742)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a79a11982af986cf57684fd6f638af69954e9147

commit a79a11982af986cf57684fd6f638af69954e9147
Author: Nico Weber <thakis@chromium.org>
Date: Wed Jun 13 14:13:28 2018

Run snapshot_unittests on all desktop bots.

Adds snapshot_unittests to the main waterfall win bots,
the cros memory bots (already running on the others),
and the clang tot bots (all desktop platforms).

Disables the test on Win10, since it doesn't pass there.

Bug: 843511,850556, 438897 
Change-Id: Ifa577c3fe97bb10544addcd12e69a29a65cff01d
Reviewed-on: https://chromium-review.googlesource.com/1089655
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566825}
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/chromium.win.json
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/a79a11982af986cf57684fd6f638af69954e9147/ui/snapshot/snapshot_aura_unittest.cc

Comment 2 by thakis@chromium.org, Jun 13 2018

Cc: grt@chromium.org
Components: UI
Labels: -OS-Linux OS-Windows
grt, could/should some windows person look at this? The snapshot code is used e.g. by extensions; having it potentially not work on win10 seems potentially a bit worrying.

Comment 3 by grt@chromium.org, Jun 14 2018

Components: -UI UI>Aura
Owner: piman@chromium.org
Status: Assigned (was: Untriaged)
This seems to be a bug in the PrintWindow path for Win 8.1 and over. piman@: I see that you reviewed r462631. Could you either take this or assign it to someone suitable? Thanks.

Comment 4 by piman@chromium.org, Jun 14 2018

Owner: zmo@chromium.org
->zmo for triage
Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
Mass UI Triage.

Sign in to add a comment