Add expiry to unused histograms. |
||||
Issue descriptionAdd expiry to unused histograms. To cleanup histograms that have been unused for long time but still take resources from users add expiry.
,
Jun 8 2018
Isn't this go/expired-histograms-doc? For basically every "unused" histogram that I touch, I am fine with the histogram expiring according to the proposed feature.
,
Jun 8 2018
Good to know! Thanks for chiming in =) (I'm not 100% sure whether that sentiment generalizes to other owners in a similar situation, FWIW – I cc'ed you because I'd *just* seen a Histogram Eraser bug go by where you'd chimed in.) While I'm thinking about it: One somewhat related technical concern that I have is to make sure that we apply the same whitelist for histogram expiry as we do for unused histograms, i.e. the contents of the whitelisted_histograms.txt file. We probably get it "for free" if we're reusing the histogram eraser data, but it's probably a good idea to double-check!
,
Jun 11 2018
Thanks for feedback. I didn't consider looking at whitelisted_histograms.txt but I will now. I am preparing a doc https://docs.google.com/document/d/1UNg3PwwA_weAhg90j225novopRANenrR-RDmRAq2cxA/edit?usp=sharing to document how the list of unused histograms was selected and a way to reproduce it. This is meant to be a one time thing.
,
Jun 11 2018
Thanks, Gayane! Would you mind opening up comment access on the doc, once it's in a state where you're ready for comments? The comment that I would have liked to add at this stage is: I think it would be good to try to get as many of the added expiry dates reviewed by owners as possible. That way, we're less likely to accidentally drop any data that's in an unusual state.
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fee797285bf7504465cc1cfe067189d5df583101 commit fee797285bf7504465cc1cfe067189d5df583101 Author: Gayane Petrosyan <gayane@chromium.org> Date: Thu Jun 21 22:47:12 2018 Add expiry to unused histograms with no owner. Add expiry to histograms that are not used last 6 months but report data in stable. More on how the histograms are selected go/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I30eee223d5ee1a9d0a421e5ab79a207ea420b651 Reviewed-on: https://chromium-review.googlesource.com/1110021 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#569382} [modify] https://crrev.com/fee797285bf7504465cc1cfe067189d5df583101/tools/metrics/histograms/histograms.xml
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d131a76bd53606def93e70e6003ab60c68f1b5eb commit d131a76bd53606def93e70e6003ab60c68f1b5eb Author: Gayane Petrosyan <gayane@chromium.org> Date: Fri Jun 22 14:54:08 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I31665bf71e42f703b38dad45da0891bd81ac669c Reviewed-on: https://chromium-review.googlesource.com/1111475 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569623} [modify] https://crrev.com/d131a76bd53606def93e70e6003ab60c68f1b5eb/tools/metrics/histograms/histograms.xml
,
Jul 4
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef5f0fa88e0bdb0e63054f1343813ceec1e26afd commit ef5f0fa88e0bdb0e63054f1343813ceec1e26afd Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Jul 04 20:19:08 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I612d54210e1fb35cfbbd20d7fccb7b2323a21e29 Reviewed-on: https://chromium-review.googlesource.com/1126165 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572642} [modify] https://crrev.com/ef5f0fa88e0bdb0e63054f1343813ceec1e26afd/tools/metrics/histograms/histograms.xml
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cabd76988d94eded0512486a85426771bef818c3 commit cabd76988d94eded0512486a85426771bef818c3 Author: Gayane Petrosyan <gayane@chromium.org> Date: Mon Jul 09 22:58:56 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I538205f53ba84bf5b2aaf4104a09c080e9aab375 Reviewed-on: https://chromium-review.googlesource.com/1126162 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573500} [modify] https://crrev.com/cabd76988d94eded0512486a85426771bef818c3/tools/metrics/histograms/histograms.xml
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88c5836a63d27282d5bbf99745b1d6292e6ffa5d commit 88c5836a63d27282d5bbf99745b1d6292e6ffa5d Author: Gayane Petrosyan <gayane@chromium.org> Date: Mon Jul 09 23:04:11 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I04beeb4ecf69ca8b8bab1b53114c11d40dfb2ed4 Reviewed-on: https://chromium-review.googlesource.com/1111572 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573505} [modify] https://crrev.com/88c5836a63d27282d5bbf99745b1d6292e6ffa5d/tools/metrics/histograms/histograms.xml
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86d6073b15fc248ec45ddab341c2b81b0caa7a56 commit 86d6073b15fc248ec45ddab341c2b81b0caa7a56 Author: Gayane Petrosyan <gayane@chromium.org> Date: Mon Jul 09 23:14:44 2018 Set an expiry date for unused histograms (Net.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I84a9b876102f223e46da4314a5b616d245a46358 Reviewed-on: https://chromium-review.googlesource.com/1126319 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#573510} [modify] https://crrev.com/86d6073b15fc248ec45ddab341c2b81b0caa7a56/tools/metrics/histograms/histograms.xml
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/701899790eed709bead0b8f61ca147fb3c23ef1c commit 701899790eed709bead0b8f61ca147fb3c23ef1c Author: Gayane Petrosyan <gayane@chromium.org> Date: Mon Jul 09 23:14:59 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I5bb941b74e051648a8863bcc6922f3c43b6eb51f Reviewed-on: https://chromium-review.googlesource.com/1126337 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573511} [modify] https://crrev.com/701899790eed709bead0b8f61ca147fb3c23ef1c/tools/metrics/histograms/histograms.xml
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a172cded1e59686c9d258fd6034553a1504f854 commit 8a172cded1e59686c9d258fd6034553a1504f854 Author: Gayane Petrosyan <gayane@chromium.org> Date: Mon Jul 09 23:21:40 2018 Set an expiry date for unused histograms (Media.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I517af72120c9748a1e2a09756e832bea20000928 Reviewed-on: https://chromium-review.googlesource.com/1126167 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#573514} [modify] https://crrev.com/8a172cded1e59686c9d258fd6034553a1504f854/tools/metrics/histograms/histograms.xml
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ee58ae3992df7549b27ed5aef115c284e9590b0 commit 1ee58ae3992df7549b27ed5aef115c284e9590b0 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jul 10 00:09:37 2018 Set an expiry date for unused histograms (GCM.*, WebHistory.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ida5724a5c8587a72c2474189f8888e6c23b12f24 Reviewed-on: https://chromium-review.googlesource.com/1126206 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#573541} [modify] https://crrev.com/1ee58ae3992df7549b27ed5aef115c284e9590b0/tools/metrics/histograms/histograms.xml
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d420cd60450f33a1ba57d9005065f10cb1333f27 commit d420cd60450f33a1ba57d9005065f10cb1333f27 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jul 10 00:12:13 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ie3dea1da3f7a42b0454a79ea1ca77a153629ddc9 Reviewed-on: https://chromium-review.googlesource.com/1126174 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573543} [modify] https://crrev.com/d420cd60450f33a1ba57d9005065f10cb1333f27/tools/metrics/histograms/histograms.xml
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b7654052b648b6fd2e73617788a87ecacdb7eee commit 7b7654052b648b6fd2e73617788a87ecacdb7eee Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jul 10 01:16:41 2018 Set an expiry date for unused histograms (SBIRS.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: If0342cd7fe8f4059aff7bdabfb5b756a8b895dee Reviewed-on: https://chromium-review.googlesource.com/1111563 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: proberge <proberge@chromium.org> Reviewed-by: Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#573581} [modify] https://crrev.com/7b7654052b648b6fd2e73617788a87ecacdb7eee/tools/metrics/histograms/histograms.xml
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78c0b6990949662b3d0f48c0fb1efbaf0b0a77f2 commit 78c0b6990949662b3d0f48c0fb1efbaf0b0a77f2 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jul 10 21:13:00 2018 Set an expiry date for unused histograms (SBClientDownload.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I0855e4e9699aa106ac75484b14741d6f2adf6704 Reviewed-on: https://chromium-review.googlesource.com/1111470 Reviewed-by: Asanka Herath <asanka@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573906} [modify] https://crrev.com/78c0b6990949662b3d0f48c0fb1efbaf0b0a77f2/tools/metrics/histograms/histograms.xml
,
Jul 10
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b commit b47e22b652e4b3776cf9dd8b3efe3398a8b4078b Author: Victor Costan <pwnall@chromium.org> Date: Mon Jul 23 20:57:02 2018 IndexedDB: Remove WebCore.IndexedDB.FrontEndAPICalls UMA histogram. The metrics have not been used in a while, and have no immediately clear use case. Bug: 850539 Change-Id: If11dcadf946bc66071ecb85aa126981a149193b3 Reviewed-on: https://chromium-review.googlesource.com/1146076 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#577249} [modify] https://crrev.com/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b/third_party/blink/renderer/modules/indexeddb/BUILD.gn [modify] https://crrev.com/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b/third_party/blink/renderer/modules/indexeddb/idb_database.cc [modify] https://crrev.com/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b/third_party/blink/renderer/modules/indexeddb/idb_database.h [modify] https://crrev.com/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b/third_party/blink/renderer/modules/indexeddb/idb_factory.cc [delete] https://crrev.com/743d97bb444ef5c4dbb7611615bce587757afe5b/third_party/blink/renderer/modules/indexeddb/idb_histograms.h [modify] https://crrev.com/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/b47e22b652e4b3776cf9dd8b3efe3398a8b4078b/tools/metrics/histograms/histograms.xml
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d49fdae6d15c7efaee6fb15a25c9b15f51ad6787 commit d49fdae6d15c7efaee6fb15a25c9b15f51ad6787 Author: Victor Costan <pwnall@chromium.org> Date: Mon Jul 30 23:39:20 2018 Remove logging for unused UMA histogram Quota.LRUOriginTypes. Bug: 850539 Change-Id: I24fe05cb8a909ceb181df643aeaf75c5007a4a3d Reviewed-on: https://chromium-review.googlesource.com/1154999 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#579235} [modify] https://crrev.com/d49fdae6d15c7efaee6fb15a25c9b15f51ad6787/storage/browser/quota/quota_database.cc [modify] https://crrev.com/d49fdae6d15c7efaee6fb15a25c9b15f51ad6787/tools/metrics/histograms/enums.xml [modify] https://crrev.com/d49fdae6d15c7efaee6fb15a25c9b15f51ad6787/tools/metrics/histograms/histograms.xml
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee777c019d8c0ea50fc9d224388eb807774787df commit ee777c019d8c0ea50fc9d224388eb807774787df Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Aug 14 16:55:22 2018 Set an expiry date for unused histograms (Extensions.*Permissions*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I7d7e2967caa586a221b50a64b5769c281777e4df Reviewed-on: https://chromium-review.googlesource.com/1126324 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#582946} [modify] https://crrev.com/ee777c019d8c0ea50fc9d224388eb807774787df/tools/metrics/histograms/histograms.xml
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c63da45aa2042236afb37c758119be413262fec commit 1c63da45aa2042236afb37c758119be413262fec Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Aug 14 21:12:22 2018 Set an expiry date for unused histograms (Download.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ic01c7e6444cf45c2cc42bf58a6207bd3216b92f5 Reviewed-on: https://chromium-review.googlesource.com/1126400 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583033} [modify] https://crrev.com/1c63da45aa2042236afb37c758119be413262fec/tools/metrics/histograms/histograms.xml
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/def4c5c79f27879310d32906121d48d3291724f6 commit def4c5c79f27879310d32906121d48d3291724f6 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Aug 21 19:41:26 2018 Set an expiry date for unused histograms (Extension*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ia7d065d7786ece8cdb0dbad78de13c0f9a699290 Reviewed-on: https://chromium-review.googlesource.com/1111473 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#584883} [modify] https://crrev.com/def4c5c79f27879310d32906121d48d3291724f6/tools/metrics/histograms/histograms.xml
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92b6a49660ca370c2354b910a29149b27e6503de commit 92b6a49660ca370c2354b910a29149b27e6503de Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Aug 21 20:49:19 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I437ea5c000a3a4fe3a065dd51641de44a27a6fa9 Reviewed-on: https://chromium-review.googlesource.com/1126321 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584894} [modify] https://crrev.com/92b6a49660ca370c2354b910a29149b27e6503de/tools/metrics/histograms/histograms.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e17cb99474da0d0369b53e4e383ca65acc8ee633 commit e17cb99474da0d0369b53e4e383ca65acc8ee633 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Aug 22 00:35:52 2018 Set an expiry date for unused histograms (Chromoting.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Idac6a13a32465359102228499e05238da53a5e97 Reviewed-on: https://chromium-review.googlesource.com/1111468 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584935} [modify] https://crrev.com/e17cb99474da0d0369b53e4e383ca65acc8ee633/tools/metrics/histograms/histograms.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6466c6d2c02ed48eb1f4c53bce45e9e00c261e00 commit 6466c6d2c02ed48eb1f4c53bce45e9e00c261e00 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Aug 22 17:08:47 2018 Set an expiry date for unused histograms (Conflicts.*, ThirdPartyModules.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I6915b08846dd50f587dded3544b990334615d4bc Reviewed-on: https://chromium-review.googlesource.com/1111597 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#585109} [modify] https://crrev.com/6466c6d2c02ed48eb1f4c53bce45e9e00c261e00/tools/metrics/histograms/histograms.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec0b8cf694a1abca703d7e839b8e2eb49917db42 commit ec0b8cf694a1abca703d7e839b8e2eb49917db42 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Aug 22 17:17:24 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Iaeae7928bc4d14d92db53526373d8e9931ac106a Reviewed-on: https://chromium-review.googlesource.com/1126177 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585116} [modify] https://crrev.com/ec0b8cf694a1abca703d7e839b8e2eb49917db42/tools/metrics/histograms/histograms.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b73d0f475c637143e98ddf5d1a9c439f8b597c9d commit b73d0f475c637143e98ddf5d1a9c439f8b597c9d Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Aug 22 17:19:42 2018 Set an expiry date for unused histograms. These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ie73f2b6256c39cc5b9df211af257f4537d985da6 Reviewed-on: https://chromium-review.googlesource.com/1126201 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#585120} [modify] https://crrev.com/b73d0f475c637143e98ddf5d1a9c439f8b597c9d/tools/metrics/histograms/histograms.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e045e50ff8d784be320df6308ef11a610cbdfb commit b5e045e50ff8d784be320df6308ef11a610cbdfb Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Aug 22 20:37:24 2018 Set an expiry date for unused histograms (NaCl.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ic888995f3a49848ecfe96c2aea55c1d2d365924c Reviewed-on: https://chromium-review.googlesource.com/1126328 Reviewed-by: Derek Schuff <dschuff@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#585233} [modify] https://crrev.com/b5e045e50ff8d784be320df6308ef11a610cbdfb/tools/metrics/histograms/histograms.xml
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9e199aabff7891f506703c7674e719a22072a24 commit e9e199aabff7891f506703c7674e719a22072a24 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Aug 22 21:02:44 2018 Set an expiry date for unused histograms (Network.3G.*, Network.Shill.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ib8f8c0b136f5851e4bd628030bf4b01395bf7e3a Reviewed-on: https://chromium-review.googlesource.com/1111559 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#585241} [modify] https://crrev.com/e9e199aabff7891f506703c7674e719a22072a24/tools/metrics/histograms/histograms.xml
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ab78c0f9fa13ff61fe35fe8d89aa6fbaaa70e9 commit c4ab78c0f9fa13ff61fe35fe8d89aa6fbaaa70e9 Author: Gayane Petrosyan <gayane@chromium.org> Date: Fri Oct 26 00:41:15 2018 Set an expiry date for unused histograms (Search.ContextualSearch*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after M71. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I541a6cba2d620d8a96f92ac3d95a96de54dd63dc Reviewed-on: https://chromium-review.googlesource.com/c/1126200 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#602950} [modify] https://crrev.com/c4ab78c0f9fa13ff61fe35fe8d89aa6fbaaa70e9/tools/metrics/histograms/histograms.xml
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccdb55838495bf86d2db63d291fe2ef68cfca822 commit ccdb55838495bf86d2db63d291fe2ef68cfca822 Author: Gayane Petrosyan <gayane@chromium.org> Date: Fri Oct 26 22:30:07 2018 Set an expiry date for unused histograms (Quickoffice.*) These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I28711dd547ecc0d7ab0c45d507bbdc8749b8d093 Reviewed-on: https://chromium-review.googlesource.com/c/1126170 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603221} [modify] https://crrev.com/ccdb55838495bf86d2db63d291fe2ef68cfca822/tools/metrics/histograms/histograms.xml
,
Dec 14
|
||||
►
Sign in to add a comment |
||||
Comment 1 by isherman@chromium.org
, Jun 8 2018