New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 850538 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

The range of the metrics for the estimated audio buffer delay in AEC3 is too short to cover longer delays

Project Member Reported by peah@chromium.org, Jun 7 2018

Issue description

In AEC3 the size of the audio buffer delay is estimated as a part of aligning the signals. The metrics for that delay are now capped to an upper value which is too short to cover all delays.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/aeb0a6475bccd6942d731a9113817095e4cd0800

commit aeb0a6475bccd6942d731a9113817095e4cd0800
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Jun 13 18:13:21 2018

AEC3: Increase the range of reported echo path delay metrics

TBR: gustaf@webrtc.org
Bug:  webrtc:9375 , chromium:850538 
Change-Id: I037e2cfe24ee297b90b4f70b744f735e43015d92
Reviewed-on: https://webrtc-review.googlesource.com/81748
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23603}
[modify] https://crrev.com/aeb0a6475bccd6942d731a9113817095e4cd0800/modules/audio_processing/aec3/render_delay_controller_metrics.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b29b52eedf21ad5a0c717806e9928dfa935ef0fd

commit b29b52eedf21ad5a0c717806e9928dfa935ef0fd
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 14 00:00:21 2018

Roll src/third_party/webrtc 789221f1101a..aeb0a6475bcc (7 commits)

https://webrtc.googlesource.com/src.git/+log/789221f1101a..aeb0a6475bcc


git log 789221f1101a..aeb0a6475bcc --date=short --no-merges --format='%ad %ae %s'
2018-06-13 peah@webrtc.org AEC3: Increase the range of reported echo path delay metrics
2018-06-13 magjed@webrtc.org Android: Fix VideoTrack behavior for adding/removing VideoSinks
2018-06-13 nisse@webrtc.org Replace all use of rtc::Pathname in generator_unittest.cc.
2018-06-13 danilchap@webrtc.org Introduce list of fields to put into codec agnostic descriptor
2018-06-13 devicentepena@webrtc.org AEC3: Changes to how the reverberation decay is applied.
2018-06-13 jonasolsson@webrtc.org Remove "webrtc_rtp" traces.
2018-06-13 yura.yaroshevich@gmail.com Add ow2_asm license


Created with:
  gclient setdep -r src/third_party/webrtc@aeb0a6475bcc

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:850538 , chromium:852257 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I96d3ed7b7c4bd9a705edda10c15a74623ce6505c
Reviewed-on: https://chromium-review.googlesource.com/1099915
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567052}
[modify] https://crrev.com/b29b52eedf21ad5a0c717806e9928dfa935ef0fd/DEPS

Comment 3 by peah@chromium.org, Jun 14 2018

Status: Fixed (was: Started)
Summary: The range of the metrics for the estimated audio buffer delay in AEC3 is too short to cover longer delays (was: The metrics for the estimated audio buffer delay in AEC3 is too short to cover longer delays)
Labels: M-69

Sign in to add a comment