Clean up KeystoneGlue to use conventional memory management facilities |
||
Issue descriptionFollow-up to issue 847755 for go/postmortem101506. KeystoneGlue uses vanilla Objective-C memory management (manual retain/release) instead of Chromium's C++ helpers. We should clean up the file to use our conventions for memory management to help avoid lifetime issues in the future.
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4322a53d1dcfa85ef9419ad4e74628839f57d721 commit 4322a53d1dcfa85ef9419ad4e74628839f57d721 Author: Robert Sesek <rsesek@chromium.org> Date: Tue Jun 12 01:40:06 2018 Update KeystoneGlue to use scoped_nsobject consistently. Also modernize/clean up a few smaller things. Bug: 850527 Change-Id: Ica7733016156d4b52b6d622f95622879a93f84c3 Reviewed-on: https://chromium-review.googlesource.com/1095595 Reviewed-by: Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#566232} [modify] https://crrev.com/4322a53d1dcfa85ef9419ad4e74628839f57d721/chrome/browser/mac/keystone_glue.h [modify] https://crrev.com/4322a53d1dcfa85ef9419ad4e74628839f57d721/chrome/browser/mac/keystone_glue.mm [modify] https://crrev.com/4322a53d1dcfa85ef9419ad4e74628839f57d721/chrome/browser/mac/keystone_glue_unittest.mm
,
Jun 12 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rsesek@chromium.org
, Jun 7 2018