New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 850525 link

Starred by 1 user
Status: Fixed
Owner:
peah@chromium.org
Closed: Jun 2018
Cc:
█ gustaf@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

For platforms with a high audio buffer latency, the AEC3 delay estimator look window may be too small

Project Member Reported by peah@chromium.org, Jun 7 2018 
Well performing platforms should have a low audio buffer delay (as seen by the AEC). In some cases it has, however, been observed that the audio buffer delay is close to what the delay estimator can handle which means that the delay estimator look window is a bit too short to reliably handle those setups.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/fddaf7528a34e397411a15dd92161339955ff456

commit fddaf7528a34e397411a15dd92161339955ff456
Author: Per Åhgren <peah@webrtc.org>
Date: Mon Jun 11 15:22:59 2018

AEC3: Increase the look window in the delay estimator.

Bug:  webrtc:9374 , chromium:850525 
Change-Id: I587cb7951acf8e5ec92d9941f1979ba2c9887876
Reviewed-on: https://webrtc-review.googlesource.com/81747
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23561}
[modify] https://crrev.com/fddaf7528a34e397411a15dd92161339955ff456/api/audio/echo_canceller3_config.h
[modify] https://crrev.com/fddaf7528a34e397411a15dd92161339955ff456/modules/audio_processing/aec3/echo_canceller3.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f119cda6222de82d8f87f07d2534c723d49d95c1

commit f119cda6222de82d8f87f07d2534c723d49d95c1
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jun 11 20:08:22 2018

Roll src/third_party/webrtc b90e63c62087..24db1c91a14e (7 commits)

https://webrtc.googlesource.com/src.git/+log/b90e63c62087..24db1c91a14e


git log b90e63c62087..24db1c91a14e --date=short --no-merges --format='%ad %ae %s'
2018-06-11 jonasolsson@webrtc.org Remove unused iostream import
2018-06-11 peah@webrtc.org AEC3: Increase the look window in the delay estimator.
2018-06-11 jonasolsson@webrtc.org Remove stringstreams from pc/
2018-06-10 brandtr@webrtc.org Remove default argument in GetSimulcastConfig.
2018-06-09 magjed@webrtc.org Android: Use JavaToNativeString in PeerConnectionFactory_InitializeFieldTrials
2018-06-08 buildbot@webrtc.org Roll chromium_revision e9fcce491e..ffaf1e2ba6 (565609:565764)
2018-06-08 qingsi@google.com Add kNumValues to IceCandidate* enums and move kUnknown to the front.


Created with:
  gclient setdep -r src/third_party/webrtc@24db1c91a14e

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:850525 ,chromium:b/109736242,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I637ca291f6c97423b0e8f65565396fc868b89352
Reviewed-on: https://chromium-review.googlesource.com/1094359
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566119}
[modify] https://crrev.com/f119cda6222de82d8f87f07d2534c723d49d95c1/DEPS

Comment 3 by peah@chromium.org, Jun 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment