IncompatibleApplicationsBrowserTest.InjectIncompatibleDLL fails in viz_browser_tests in official builds |
|||
Issue descriptionviz_browser_tests runs browser_tests with the "viz" feature enabled. I recently added it to the clang tot bots, one of which does official builds. https://ci.chromium.org/buildbot/chromium.clang/ToTWin/1630 [ RUN ] IncompatibleApplicationsBrowserTest.InjectIncompatibleDLL [3640:6664:0607/041501.667:ERROR:network_change_notifier_win.cc(157)] WSALookupServiceBegin failed with: 10108 [3640:4984:0607/041501.667:ERROR:dns_config_service_win.cc(581)] DNS registry watch failed to start. [3640:4984:0607/041501.677:WARNING:dns_config_service_win.cc(669)] Failed to read DnsConfig. [3640:5548:0607/041501.726:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [3640:6152:0607/041501.726:WARNING:net_errors_win.cc(119)] Unknown error 10044 mapped to net::ERR_FAILED [3640:6664:0607/041501.735:WARNING:chrome_browser_main_win.cc(650)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=IncompatibleApplicationsBrowserTest.InjectIncompatibleDLL --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/viz.browser_tests.filter --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir2380_21694\results2380_16493\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\io3xskiz\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir2380_21694\d2380_12528" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=IncompatibleApplicationsWarning,ModuleDatabase,TestFeatureForBrowserTest1,VizDisplayCompositor --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [3640:6152:0607/041501.783:FATAL:gpu_process_host.cc(1539)] Unable to start viz process, giving up.
,
Jun 12 2018
Let's disable the test in the meantime: https://chromium-review.googlesource.com/c/chromium/src/+/1096773
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfbd764e97f6b82cd5824652212d039a80502e68 commit cfbd764e97f6b82cd5824652212d039a80502e68 Author: Hans Wennborg <hans@chromium.org> Date: Tue Jun 12 13:40:10 2018 Disable IncompatibleApplicationsBrowserTest.InjectIncompatibleDLL in viz_browser_tests in official builds Bug: 850517 Change-Id: If948bf58245436ea071b63935f611c879c914307 Reviewed-on: https://chromium-review.googlesource.com/1096773 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#566400} [modify] https://crrev.com/cfbd764e97f6b82cd5824652212d039a80502e68/chrome/browser/conflicts/incompatible_applications_browsertest.cc
,
Jun 14 2018
I was unable to reproduce this locally. :( Maybe if I uploaded by build to swarming I could try to remotely debug it that way, but my previous attempts to do that have mostly failed, so I might let mohsen get around to this.
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1f0724d58855789fd9476282c12bdb65f3e87e9 commit c1f0724d58855789fd9476282c12bdb65f3e87e9 Author: Reid Kleckner <rnk@google.com> Date: Thu Jun 14 18:01:38 2018 Skip IncompatibleApplicationsBrowserTest test setup in viz_browser_tests This test seems to crash on our bots before it reaches the test fixture code. I assume that is failing somewhere in SetUp, but there is no stack trace to confirm that. I'm speculatively disabling some code when this feature flag is set. We'll see if that greens our bots. Also, remove the OFFICIAL_BUILD ifdef check. This code is only compiled when is_chrome_branded is true. NOTRY=True TBR=chrisha@chromium.org, mhosen@chromium.org, mohsen@chromium.org BUG=850517 Change-Id: I9f7e1fc8d826e830fc3e5284bff7e9cd6344fd7b Reviewed-on: https://chromium-review.googlesource.com/1101408 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#567343} [modify] https://crrev.com/c1f0724d58855789fd9476282c12bdb65f3e87e9/chrome/browser/conflicts/incompatible_applications_browsertest.cc
,
Jul 11
+fsamuel@ We wanted to sync up on the expectations of this test. As when Viz is running, being able to bring up the Viz process will necessary for the browser to run.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Jun 7 2018