Top/bottom content inset in menus are inconsistent |
||
Issue descriptionThe top inset seems to be consistent across instances at 10pt. The bottom inset is inconsistently different from the top. Both top and bottom insets should be the same [10pt] in all instances.
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5202b90d8de13309d30bbc60be18f20be19f7276 commit 5202b90d8de13309d30bbc60be18f20be19f7276 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Aug 14 13:56:23 2018 [iOS] Adjust top/bottom insets of Popup Menu The bottom insets of the popup menus were wrong because of a rounding error. This CL adjusts it by rounding at the end of the additions instead of doing everytime a new element is computed. Bug: 850516 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic99c3d71e1f7d8a0b47a3e6453242d4a36007e66 Reviewed-on: https://chromium-review.googlesource.com/1174253 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582902} [modify] https://crrev.com/5202b90d8de13309d30bbc60be18f20be19f7276/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
,
Aug 14
|
||
►
Sign in to add a comment |
||
Comment 1 by gambard@chromium.org
, Jun 18 2018