Issue metadata
Sign in to add a comment
|
Menu selected state has disappeared |
||||||||||||||||||||||
Issue descriptionOther menu's correctly show the selected state on the calling toolbar button, but the menu seems be broken (both for longpress and tap).
,
Jun 18 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b37040b923acca7e59865d923c83c03c6a164e7 commit 0b37040b923acca7e59865d923c83c03c6a164e7 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Jun 19 08:14:09 2018 Fix spotlight state of the tools menu button The spotlighted view wasn't created for the tools menu button. This bug was introduced in the CL moving the creation of the spotlight view from a lazy accessor to a protected method. Bug: 850513 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9bdf63ab0ed7095203a0dad2ce34642912814710 Reviewed-on: https://chromium-review.googlesource.com/1104690 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#568372} [modify] https://crrev.com/0b37040b923acca7e59865d923c83c03c6a164e7/ios/chrome/browser/ui/toolbar/buttons/toolbar_tools_menu_button.mm
,
Jun 19 2018
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20
,
Jun 26 2018
Selected state is displayed correctly both on Tap and Long Tap Verified on iPhone, iPad with Regular and Incognito modes. https://drive.google.com/file/d/1Flg8-sucWWqgRvfaScRIEARVqzSXXmex/view Verified on M69.0.3473.0 canary iOS: 11.4, 12 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Jun 7 2018