Issue metadata
Sign in to add a comment
|
Clip menu subviews to background rounded-rect path |
||||||||||||||||||||||
Issue descriptionWhen a cell is in a highlight state, you can see the background bleeds outside the rounded corners (see attached screenshot). clipsToBounds is obviously correctly set, but I believe cornerRadius is not set on the backing layer. Setting that to 13 should do the trick.
,
Jun 18 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9db2d442460e883dc9a8d670b2f5b6efb614c0d commit d9db2d442460e883dc9a8d670b2f5b6efb614c0d Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Jun 21 16:31:01 2018 Clip the content of the popup menu to its bounds This CL clips the content of the popup menu's table view to its bounds, making sure its content, including the selection highlight respect the bounds set by the rounded corners. Bug: 850511 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I516224790aed23fd88387ac3236d36861697cde3 Reviewed-on: https://chromium-review.googlesource.com/1110129 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569289} [modify] https://crrev.com/d9db2d442460e883dc9a8d670b2f5b6efb614c0d/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/d9db2d442460e883dc9a8d670b2f5b6efb614c0d/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/d9db2d442460e883dc9a8d670b2f5b6efb614c0d/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm [modify] https://crrev.com/d9db2d442460e883dc9a8d670b2f5b6efb614c0d/ios/chrome/browser/ui/popup_menu/popup_menu_view_controller.mm
,
Jun 22 2018
,
Jul 4
The NextAction date has arrived: 2018-07-04 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Jun 7 2018