Non-Regression: Unnecessary traces of toggle mirroring option is seen while opening camera app |
||
Issue descriptionChrome Version: 69.0.3451.0/10758.0.0 dev channel Kip, Daisy & Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Open Camera App and observe Actual: Unwanted traces of toggle mirroring option is seen when opening camera app and disappears Expected: No such issue should be seen This is a Non-Regression issue seen from M62( Issue is seen in Camera app of version 5.0.1) @Yuli: Please confirm the issue
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e commit d1f79fc5d6f8f5aad89f1b6d121790745f483a9e Author: Yuli Huang <yuli@chromium.org> Date: Fri Jun 29 02:50:31 2018 Fix mirror toggle and show it only on certain devices. 1. Show the mirror toggle only on devices having flipping camera. 2. Don't defer showing/hidding the mirror toggle after stream loaded to minimize UI flickering. BUG=chromium:847737, chromium:850467 TEST=Tested by explicitly launching app w/ and w/o mirroring toggle. Change-Id: Id9bd227847f746a61d66f5a0c483e4aea3b6996d Reviewed-on: https://chromium-review.googlesource.com/1117969 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e/src/js/util.js [modify] https://crrev.com/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e/src/js/views/camera.js [modify] https://crrev.com/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e/src/views/main.html
,
Jul 20
Please verify the fix in the next CCA canary release.
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e commit d1f79fc5d6f8f5aad89f1b6d121790745f483a9e Author: Yuli Huang <yuli@chromium.org> Date: Fri Jun 29 02:50:31 2018 Fix mirror toggle and show it only on certain devices. 1. Show the mirror toggle only on devices having flipping camera. 2. Don't defer showing/hidding the mirror toggle after stream loaded to minimize UI flickering. BUG=chromium:847737, chromium:850467 TEST=Tested by explicitly launching app w/ and w/o mirroring toggle. Change-Id: Id9bd227847f746a61d66f5a0c483e4aea3b6996d Reviewed-on: https://chromium-review.googlesource.com/1117969 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e/src/js/util.js [modify] https://crrev.com/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e/src/js/views/camera.js [modify] https://crrev.com/d1f79fc5d6f8f5aad89f1b6d121790745f483a9e/src/views/main.html |
||
►
Sign in to add a comment |
||
Comment 1 by y...@chromium.org
, Jun 8 2018