Relax restrictions on raising oom_score_adj |
||||||||||||
Issue descriptionWhen I try to set chrome oom_score_adj from -1000 to 0 in chrome to solved a chrome memory leak issue, it failed because the following change from android restrict a user to write oom_score_adj: https://chromium.git.corp.google.com/chromiumos/third_party/kernel/+/55541f1ac36fbb6edd94273cab21d69a82d31519 From upstream kernel doc https://www.kernel.org/doc/Documentation/filesystems/proc.txt : The value of /proc/<pid>/oom_score_adj may be reduced no lower than the last value set by a CAP_SYS_RESOURCE process. To reduce the value any lower requires CAP_SYS_RESOURCE. It's not necessary to make oom_score_adj read only. That change has already been reverted on Android, it shall also be reverted on Chrome OS. The Android bug to revert this change: https://b.corp.google.com/issues/63142211
,
Jun 7 2018
,
Jun 7 2018
,
Jun 7 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/78044b8a98d2742dea111a1f830277a94507ae55 commit 78044b8a98d2742dea111a1f830277a94507ae55 Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Thu Jun 07 23:52:22 2018 Revert "fixup! proc: make oom adjustment files user read-only" This reverts commit 87a7a2cfbe48c29e48ed846d939f82d710780d99. BUG= chromium:850457 TEST=none Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: I7a0a18032d3f51feb7f3a6defa9f10b658d086e3 Reviewed-on: https://chromium-review.googlesource.com/1090696 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/78044b8a98d2742dea111a1f830277a94507ae55/fs/proc/base.c
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/54a7ed9ec7a6478ab91bd907486b88672112b55f commit 54a7ed9ec7a6478ab91bd907486b88672112b55f Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Thu Jun 07 23:52:24 2018 Revert "proc: make oom adjustment files user read-only" This reverts commit 55541f1ac36fbb6edd94273cab21d69a82d31519. BUG= chromium:850457 TEST=su chronos and raise /proc/PID/oom_score_adj CQ-DEPEND=CL:1090696 Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: I14debc647cb006847407b3523902953a45c5a39d Reviewed-on: https://chromium-review.googlesource.com/1090858 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/54a7ed9ec7a6478ab91bd907486b88672112b55f/fs/proc/base.c
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e715811a996089a6cd8336715917f9cc6c39390d commit e715811a996089a6cd8336715917f9cc6c39390d Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Jun 08 16:00:12 2018 Revert "ANDROID: fixup! proc: make oom adjustment files user read-only" This reverts commit 5e19c2922cb6142aa65361f700718115aa38d1a6. BUG= chromium:850457 TEST=none Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: If689950c00c9f43b542a5a6c0b92a0668e029631 Reviewed-on: https://chromium-review.googlesource.com/1092565 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e715811a996089a6cd8336715917f9cc6c39390d/fs/proc/base.c
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/10bb244b2fc512683c73562a60d4ef3295ed0f50 commit 10bb244b2fc512683c73562a60d4ef3295ed0f50 Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Jun 08 16:00:14 2018 Revert "ANDROID: proc: make oom adjustment files user read-only" This reverts commit 84813fea44a982a7e8aa42e406eb152077960293. BUG= chromium:850457 TEST=su chronos and raise /proc/PID/oom_score_adj Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: Ib49b2cfde2d99da0839328dc9fb624c72a4a6510 Reviewed-on: https://chromium-review.googlesource.com/1092566 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/10bb244b2fc512683c73562a60d4ef3295ed0f50/fs/proc/base.c
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d95059e57194173def4f6203685d4b9285c6e7db commit d95059e57194173def4f6203685d4b9285c6e7db Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Jun 08 16:00:18 2018 Revert "ANDROID: proc: make oom adjustment files user read-only" This reverts commit c0ec3df8178404486ef4c377b7d1f00a2ba8b94c. BUG= chromium:850457 TEST=su chronos and raise /proc/PID/oom_score_adj Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: I2091bb01710e19850b726cf0b68bf31915b2fe24 Reviewed-on: https://chromium-review.googlesource.com/1092559 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d95059e57194173def4f6203685d4b9285c6e7db/fs/proc/base.c
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6a54b6081d7659fdcb43176a85d946c4d94696cd commit 6a54b6081d7659fdcb43176a85d946c4d94696cd Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Jun 08 16:00:09 2018 Revert "fixup! proc: make oom adjustment files user read-only" This reverts commit deb1413f9e1373230a223a2daa93d2bb6f8193dd. BUG= chromium:850457 TEST=none Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: Ife1e03d52d1b34ddc6361f5dbdb5c87e55f03c23 Reviewed-on: https://chromium-review.googlesource.com/1092562 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/6a54b6081d7659fdcb43176a85d946c4d94696cd/fs/proc/base.c
,
Jun 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e2cfad0662f1753d3896ecbbb673b06d9a0761cc commit e2cfad0662f1753d3896ecbbb673b06d9a0761cc Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Fri Jun 08 16:00:11 2018 Revert "proc: make oom adjustment files user read-only" This reverts commit 1ba6b2f465b0bd71d0c67bf7b0b0a7e7f5989b98. BUG= chromium:850457 TEST=su chronos and raise /proc/PID/oom_score_adj Signed-off-by: Kuo-Hsin Yang <vovoy@chromium.org> Change-Id: I28c09f5b12b3d2c54d4840236e3c849ec452eb8b Reviewed-on: https://chromium-review.googlesource.com/1092563 Commit-Ready: Vovo Yang <vovoy@chromium.org> Tested-by: Vovo Yang <vovoy@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/e2cfad0662f1753d3896ecbbb673b06d9a0761cc/fs/proc/base.c
,
Jun 12 2018
,
Jun 15 2018
,
Jun 15 2018
,
Jun 20 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/319c61a390392fd207ffae39c0eee556e45620ed commit 319c61a390392fd207ffae39c0eee556e45620ed Author: Mike Frysinger <vapier@chromium.org> Date: Wed Jun 27 18:17:37 2018 zygote: stop using suid sandbox for oom adjust on CrOS The patch to the kernel that required this usage has been dropped, so we can drop this suid usage on CrOS now. Bug: 576409 , 850457 Change-Id: I8ea9321f4f233618a239db62a1ecf7a132bc54c8 Reviewed-on: https://chromium-review.googlesource.com/1112815 Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#570843} [modify] https://crrev.com/319c61a390392fd207ffae39c0eee556e45620ed/services/service_manager/zygote/host/zygote_host_impl_linux.cc |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by vovoy@chromium.org
, Jun 7 2018